From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: Change in binary name w/ meson build Date: Fri, 7 Sep 2018 16:24:19 +0100 Message-ID: <20180907152418.GA14360@bricha3-MOBL.ger.corp.intel.com> References: <20180907141342.GA21576@bricha3-MOBL.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Luca Boccassi , Thomas Monjalon , "dev@dpdk.org" To: Shahaf Shuler Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 105014CB3 for ; Fri, 7 Sep 2018 17:24:37 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20180907141342.GA21576@bricha3-MOBL.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 07, 2018 at 03:13:43PM +0100, Bruce Richardson wrote: > On Wed, Sep 05, 2018 at 11:52:10AM +0000, Shahaf Shuler wrote: > > Hi Bruce, > > > > > > Playing w/ meson build I got to know that the binary name for testpmd > > got changed to dpdk-testpmd. > > > > > > Not sure if it was discussed or not before, but such change will affect > > all the automation used to run testpmd w/ the old build system. > > > > > > What is the reason for the change in the name? > > The primary driver was that the autotest binary could not be called "test" > any more, since that is a reserved name. When appending a dpdk prefix to > the test binary, I felt for consistency that other binaries should have a > dpdk prefix too, to indicate that they come from DPDK. If this is a > problem, we can remove the prefix from the binaries easily enough. > Also to point out that when building with meson the scripting is going to have to change anyway, right. The actual build commands are different, the configuration commands are different, and the directories the resulting binaries are placed in are different too. Therefore, I'd like to keep the name prefixes if possible, since for automated tooling on DPDK there are going to have to be lots of other changes anyway. For packagers, the rename I understand could be problematic, but that could probably be solved by symlinks in the install phase. /Bruce