From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manasi Navare Subject: Re: [PATCH 1/3] drm/i915/dp: Fix link retraining comment in intel_dp_long_pulse() Date: Fri, 7 Sep 2018 09:31:03 -0700 Message-ID: <20180907163102.GB23484@intel.com> References: <20180907062135.30054-1-dhinakaran.pandiyan@intel.com> <8736ul4h37.fsf@intel.com> <20180907143236.GE5565@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A49B6E972 for ; Fri, 7 Sep 2018 16:28:11 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180907143236.GE5565@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Jan-Marek Glogowski , intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBTZXAgMDcsIDIwMTggYXQgMDU6MzI6MzZQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIEZyaSwgU2VwIDA3LCAyMDE4IGF0IDAzOjM5OjI0UE0gKzAzMDAsIEphbmkg TmlrdWxhIHdyb3RlOgo+ID4gT24gVGh1LCAwNiBTZXAgMjAxOCwgRGhpbmFrYXJhbiBQYW5kaXlh biA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+IHdyb3RlOgo+ID4gPiBDb21tZW50IGNs YWltcyBsaW5rIG5lZWRzIHRvIGJlIHJldHJhaW5lZCBiZWNhdXNlIHRoZSBjb25uZWN0ZWQgc2lu ayByYWlzZWQKPiA+ID4gYSBsb25nIHB1bHNlIHRvIGluZGljYXRlIGxpbmsgbG9zcy4gSWYgdGhl IHNpbmsgZGlkIHNvLAo+ID4gPiBpbnRlbF9kcF9ob3RwbHVnKCkgd291bGQgaGF2ZSBoYW5kbGVk IGxpbmsgcmV0cmFpbmluZy4gTG9va2luZyBhdCB0aGUKPiA+ID4gbG9ncyBpbiBCdWd6aWxsYSBy ZWZlcmVuY2VkIGluIGNvbW1pdCAnM2NmNzFiYzk5MDRkICgiZHJtL2k5MTU6IFJlLWFwcGx5Cj4g PiA+IFBlcmZvcm0gbGluayBxdWFsaXR5IGNoZWNrLCB1bmNvbmRpdGlvbmFsbHkgZHVyaW5nIGxv bmcgcHVsc2UiIiknLCB0aGUKPiA+ID4gaXNzdWUgaXMgdGhhdCB0aGUgc2luayBkb2VzIG5vdCB0 cmlnZ2VyIGFuIGludGVycnVwdC4gV2Ugd2FudCB0aGUKPiA+ID4gLT5kZXRlY3QoKSBmcm9tIHVz ZXIgc3BhY2UgdG8gY2hlY2sgbGluayBzdGF0dXMgYW5kIHJldHJhaW4uIFZpbGxlJ3MKPiA+ID4g cmV2aWV3IGZvciB0aGUgb3JpZ2luYWwgcGF0Y2ggYWxzbyBpbmRpY2F0ZXMgdGhlIHNhbWUgcm9v dCBjYXVzZS4KPiA+ID4KPiA+ID4gSSBoYXZlIGFsc28gcmVuYW1lZCBsb25nX3B1bHNlKCkgdG8g ZnVsbF9kZXRlY3QoKS4KPiA+IAo+ID4gU2luY2UgaW50ZWxfZHBfZGV0ZWN0KCkgZG9lc24ndCBh Y3R1YWxseSBkbyAqYW55dGhpbmcqIGV4Y2VwdCBza2lwCj4gPiBkZXRlY3Qgc29tZXRpbWVzLCBJ IHRoaW5rICJmdWxsIGRldGVjdCIgaXMgYSBtaXNub21lci4KPiA+IAo+ID4gQXJndWFibHkgeW91 IGNvdWxkIG1lcmdlIGludGVsX2RwX2xvbmdfcHVsc2UoKSBpbnRvIGl0cyBvbmx5IGNhbGxlciwK PiA+IGludGVsX2RwX2RldGVjdCgpLCBhbmQgZG8gYW4gZWFybHkgcmV0dXJuIG9uIHNraXBwaW5n IGRldGVjdC4gWW91IGhhdmUKPiA+IHRvIGxvb2sgYXQgdGhlIGZ1bmN0aW9ucywgYW5kIHdvbmRl ciBpZiB0aGUgY3VycmVudCBzcGxpdCBpcyB0aGUgcmlnaHQKPiA+IG9uZS4KPiAKPiBUaGF0J3Mg cHJldHR5IG11Y2ggd2hhdCBJIHN1Z2dlc3RlZCBlYXJsaWVyLiBBbHRob3VnaCBzb21lb25lIHNo b3VsZAo+IGRvdWJsZSBjaGVjayB0byBtYWtlIHN1cmUgdGhlIGRldGVjdF9kb25lIGZsYWcgZXZl biBtYWtlcyBzZW5zZSB0aGVzZQo+IGRheXMuIE1heWJlIGl0IGRvZXMsIG1heWJlIGl0IGRvZXNu J3QsIEkgZG9uJ3QgcmVjYWxsLgo+CgpZZXMgSSByZW1lbWJlciBkaWdnaW5nIGludG8gdGhlIGRl dGVjdF9kb25lIGZsYWcgZWFybGllci4gU28gdGhlIGhpc3RvcnkKb2YgdGhpcyBmbGFnIGlzIHRo YXQgaXQgd2FzIGFkZGVkIHdoZW4gaW50ZWxfZHBfZGV0ZWN0KCkgd2FzIGJlaW5nIGNhbGxlZApm cm9tIG11bHRpcGxlIHBsYWNlcyBsaWtlIHRoZSBob3RwbHVnIGFuZCBmcm9tIHVzZXJzcGFjZSB0 aHJvdWdoIGRybV9tb2RlX2dldF9jb25uZWN0b3IoKS4KSG93ZXZlciBub3cgdGhhdCBpdHMgY2Fs bGVkIG9ubHkgZnJvbSBvbmUgcGxhY2UsIEkgYmVsaWV2ZSB3ZSBkbyBub3QgbmVlZCB0aGUgZGV0 ZWN0X2RvbmUKZmxhZy4gQW5kIGluIHRoaXMgY2FzZSB3ZSBjYW4ganVzdCBoYXZlIGludGVsX2Rw X2xvbmdfcHVsc2UgZ2V0IG1lcmdlZCB3aXRoIGludGVsX2RwX2RldGVjdCgpCmFuZCBqdXN0IGhh dmUgYWxsIHRoYXQgdW5kZXIgdGhlIF9kZXRlY3QgdW1icmVsbGEuCgpNYW5hc2kKIAo+ID4gCj4g PiBQbGVhc2UgbGV0IG90aGVycyBjaGltZSBpbiB0b28gYmVmb3JlIG1ha2luZyBjaGFuZ2VzLgo+ ID4gCj4gPiBCUiwKPiA+IEphbmkuCj4gPiAKPiA+IAo+ID4gPgo+ID4gPiBDYzogTHl1ZGUgUGF1 bCA8bHl1ZGVAcmVkaGF0LmNvbT4KPiA+ID4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3ly amFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiA+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFA bGludXguaW50ZWwuY29tPgo+ID4gPiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50 ZWwuY29tPgo+ID4gPiBDYzogSmFuLU1hcmVrIEdsb2dvd3NraSA8Z2xvZ293QGZiaWhvbWUuZGU+ Cj4gPiA+IFJlZmVyZW5jZXM6IDNjZjcxYmM5OTA0ZCAoImRybS9pOTE1OiBSZS1hcHBseSAiUGVy Zm9ybSBsaW5rIHF1YWxpdHkgY2hlY2ssIHVuY29uZGl0aW9uYWxseSBkdXJpbmcgbG9uZyBwdWxz ZSIiKQo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFu LnBhbmRpeWFuQGludGVsLmNvbT4KPiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kcC5jIHwgMTcgKysrKystLS0tLS0tLS0tLS0KPiA+ID4gIDEgZmlsZSBjaGFuZ2Vk LCA1IGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQo+ID4gPgo+ID4gPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2RwLmMKPiA+ID4gaW5kZXggNDM2YzIyZGUzM2I2Li5iZWZkYWEwNzZkOGMgMTAwNjQ0 Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+ID4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gPiBAQCAtNTAxMiw3ICs1MDEyLDcg QEAgaW50ZWxfZHBfdW5zZXRfZWRpZChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ID4gPiAg fQo+ID4gPiAgCj4gPiA+ICBzdGF0aWMgaW50Cj4gPiA+IC1pbnRlbF9kcF9sb25nX3B1bHNlKHN0 cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiA+ID4gK2ludGVsX2RwX2Z1bGxfZGV0 ZWN0KHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiA+ID4gIAkJICAgIHN0cnVj dCBkcm1fbW9kZXNldF9hY3F1aXJlX2N0eCAqY3R4KQo+ID4gPiAgewo+ID4gPiAgCXN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoY29ubmVjdG9yLT5iYXNlLmRldik7 Cj4gPiA+IEBAIC01MDc0LDE2ICs1MDc0LDggQEAgaW50ZWxfZHBfbG9uZ19wdWxzZShzdHJ1Y3Qg aW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IsCj4gPiA+ICAJCWdvdG8gb3V0Owo+ID4gPiAgCX0g ZWxzZSB7Cj4gPiA+ICAJCS8qCj4gPiA+IC0JCSAqIElmIGRpc3BsYXkgaXMgbm93IGNvbm5lY3Rl ZCBjaGVjayBsaW5rcyBzdGF0dXMsCj4gPiA+IC0JCSAqIHRoZXJlIGhhcyBiZWVuIGtub3duIGlz c3VlcyBvZiBsaW5rIGxvc3MgdHJpZ2dlcmluZwo+ID4gPiAtCQkgKiBsb25nIHB1bHNlLgo+ID4g PiAtCQkgKgo+ID4gPiAtCQkgKiBTb21lIHNpbmtzIChlZy4gQVNVUyBQQjI4N1EpIHNlZW0gdG8g cGVyZm9ybSBzb21lCj4gPiA+IC0JCSAqIHdlaXJkIEhQRCBwaW5nIHBvbmcgZHVyaW5nIG1vZGVz ZXRzLiBTbyB3ZSBjYW4gYXBwYXJlbnRseQo+ID4gPiAtCQkgKiBlbmQgdXAgd2l0aCBIUEQgZ29p bmcgbG93IGR1cmluZyBhIG1vZGVzZXQsIGFuZCB0aGVuCj4gPiA+IC0JCSAqIGdvaW5nIGJhY2sg dXAgc29vbiBhZnRlci4gQW5kIG9uY2UgdGhhdCBoYXBwZW5zIHdlIG11c3QKPiA+ID4gLQkJICog cmV0cmFpbiB0aGUgbGluayB0byBnZXQgYSBwaWN0dXJlLiBUaGF0J3MgaW4gY2FzZSBubwo+ID4g PiAtCQkgKiB1c2Vyc3BhY2UgY29tcG9uZW50IHJlYWN0ZWQgdG8gaW50ZXJtaXR0ZW50IEhQRCBk aXAuCj4gPiA+ICsJCSAqIENoZWNrIGxpbmsgc3RhdHVzIGluIGNhc2UgdGhlIGxpbmsgd2VudCBv dXQgb2YKPiA+ID4gKwkJICogc3luY2hyb25pemF0aW9uIGFuZCB0aGUgc2luayBkaWQgbm90IHRl bGwgdXMuCj4gPiA+ICAJCSAqLwo+ID4gPiAgCQlzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2Rl ciA9ICZkcF90b19kaWdfcG9ydChpbnRlbF9kcCktPmJhc2U7Cj4gPiA+ICAKPiA+ID4gQEAgLTUx NDksNyArNTE0MSw4IEBAIGludGVsX2RwX2RldGVjdChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29u bmVjdG9yLAo+ID4gPiAgCQkJCXJldHVybiByZXQ7Cj4gPiA+ICAJCX0KPiA+ID4gIAo+ID4gPiAt CQlzdGF0dXMgPSBpbnRlbF9kcF9sb25nX3B1bHNlKGludGVsX2RwLT5hdHRhY2hlZF9jb25uZWN0 b3IsIGN0eCk7Cj4gPiA+ICsJCXN0YXR1cyA9IGludGVsX2RwX2Z1bGxfZGV0ZWN0KGludGVsX2Rw LT5hdHRhY2hlZF9jb25uZWN0b3IsCj4gPiA+ICsJCQkJCSAgICAgIGN0eCk7Cj4gPiA+ICAJfQo+ ID4gPiAgCj4gPiA+ICAJaW50ZWxfZHAtPmRldGVjdF9kb25lID0gZmFsc2U7Cj4gPiAKPiA+IC0t IAo+ID4gSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgo+IAo+ IC0tIAo+IFZpbGxlIFN5cmrDpGzDpAo+IEludGVsCj4gX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=