From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [PATCH net-next] net: dsa: b53: Uninitialized variable in b53_adjust_link() Date: Sat, 8 Sep 2018 11:39:25 +0300 Message-ID: <20180908083925.i5j23wi67m5by2ew@kili.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Lunn , Vivien Didelot , "David S. Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: Florian Fainelli Return-path: Received: from userp2130.oracle.com ([156.151.31.86]:39156 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726291AbeIHNZR (ORCPT ); Sat, 8 Sep 2018 09:25:17 -0400 Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: The "pause" variable is only initialized on BCM5301x. Fixes: 5e004460f874 ("net: dsa: b53: Add helper to set link parameters") Signed-off-by: Dan Carpenter diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c index ea4256cd628b..dbf5b86a07fe 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -1025,7 +1025,7 @@ static void b53_adjust_link(struct dsa_switch *ds, int port, struct b53_device *dev = ds->priv; struct ethtool_eee *p = &dev->ports[port].eee; u8 rgmii_ctrl = 0, reg = 0, off; - int pause; + int pause = 0; if (!phy_is_pseudo_fixed_link(phydev)) return; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Sat, 08 Sep 2018 08:39:25 +0000 Subject: [PATCH net-next] net: dsa: b53: Uninitialized variable in b53_adjust_link() Message-Id: <20180908083925.i5j23wi67m5by2ew@kili.mountain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Florian Fainelli Cc: Andrew Lunn , Vivien Didelot , "David S. Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org The "pause" variable is only initialized on BCM5301x. Fixes: 5e004460f874 ("net: dsa: b53: Add helper to set link parameters") Signed-off-by: Dan Carpenter diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c index ea4256cd628b..dbf5b86a07fe 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -1025,7 +1025,7 @@ static void b53_adjust_link(struct dsa_switch *ds, int port, struct b53_device *dev = ds->priv; struct ethtool_eee *p = &dev->ports[port].eee; u8 rgmii_ctrl = 0, reg = 0, off; - int pause; + int pause = 0; if (!phy_is_pseudo_fixed_link(phydev)) return;