From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 15/20] drm/sun4i: Use drm_fbdev_generic_setup() Date: Mon, 10 Sep 2018 09:28:54 +0200 Message-ID: <20180910072854.zzdu2xjmyp4hxs7g@flea> References: <20180908134648.2582-1-noralf@tronnes.org> <20180908134648.2582-16-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1941108261==" Return-path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 895FA6E22A for ; Mon, 10 Sep 2018 07:29:05 +0000 (UTC) In-Reply-To: <20180908134648.2582-16-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?utf-8?Q?Tr=C3=B8nnes?= Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1941108261== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5wsff7xaxr2qtabr" Content-Disposition: inline --5wsff7xaxr2qtabr Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 08, 2018 at 03:46:43PM +0200, Noralf Tr=F8nnes wrote: > The CMA helper is already using the drm_fb_helper_generic_probe part of > the generic fbdev emulation. This patch makes full use of the generic > fbdev emulation by using its drm_client callbacks. This means that > drm_mode_config_funcs->output_poll_changed and drm_driver->lastclose are > now handled by the emulation code. Additionally fbdev unregister happens > automatically on drm_dev_unregister(). >=20 > The drm_fbdev_generic_setup() call is put after drm_dev_register() in the > driver. This is done to highlight the fact that fbdev emulation is an > internal client that makes use of the driver, it is not part of the > driver as such. If fbdev setup fails, an error is printed, but the driver > succeeds probing. >=20 > Cc: Maxime Ripard > Signed-off-by: Noralf Tr=F8nnes It's hard to tell anything about this patch without context, but is the mali userspace still broken? Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --5wsff7xaxr2qtabr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAluWHTUACgkQ0rTAlCFN r3RYNBAAhtjqvX2ECfW9SS0/Pck1ch0PlCkY4XZkMN2zwDbuKPfgq9PKgUrzNomi fn+lONqe1ocqAojG9T4AOWvkAuB3adBrvrGFfOiv3WWcaNPbfmVwJCcelK92ABkS t87DFbzdNJJS5ZY+1Pr3hnGjnQQhq8faNPSy/QQ9bb0Jfsd5tMKF+ZpRv0jsFLFs nDU4ySsKCj0efKhqJPT5cfetYHCuwZh6p2mMqqrmsXQxN5ADf+XphYddvnOs1otI nPlwk8CVbtFJGbDg+qWMvpXZpgjKhTTUaTKsTHscjyUIxp1X8Z0PpPDBfaHFhGmI 271Pto+fooLDdCHH5l+6uhLLisP6YA/RCtw/3smlfk7zXrI495/bYjDxD9xLJyTe FDdtCcHNAol+aheuyGqggaSkKZfsaO18kLv/747v2b8wwPWFRVXRkexif6jBNXNa py4CZx0S64M5Tya2Hxt9eXxQ6QAuY5baYs3YmcRxTDFiO6xm7fJPm475+I17WQfD TsqaoiJpUEppTQEOtYyc1XNV9klK/lUqV/ql5EUDK/+oK9pu9g7goPcybcxd7pPs mwqhr7JqudPE9HUgPhhPEr7LnKjr//A1ub6D0xygdJxZ+nhnFKKEVzKDLSA2DIzT UukBRVvJDhXj+wpLO4VnjL6+GTUnKcrluUWF+XNjbNUDSC6Be9w= =vCwK -----END PGP SIGNATURE----- --5wsff7xaxr2qtabr-- --===============1941108261== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1941108261==--