From: Guo Ren <ren_guo@c-sky.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
daniel.lezcano@linaro.org, jason@lakedaemon.net, arnd@arndb.de,
c-sky_gcc_upstream@c-sky.com, gnu-csky@mentor.com,
thomas.petazzoni@bootlin.com, wbx@uclibc-ng.org,
green.hu@gmail.com
Subject: Re: [PATCH V3 10/26] csky: IRQ handling
Date: Mon, 10 Sep 2018 15:30:39 +0800 [thread overview]
Message-ID: <20180910073039.GA4022@guoren-Inspiron-7460> (raw)
In-Reply-To: <alpine.DEB.2.21.1809061535040.1570@nanos.tec.linutronix.de>
On Thu, Sep 06, 2018 at 03:39:01PM +0200, Thomas Gleixner wrote:
> On Wed, 5 Sep 2018, Guo Ren wrote:
>
> > +static void (*handle_arch_irq)(struct pt_regs *regs) = NULL;
> > +
> > +void __init set_handle_irq(void (*handle_irq)(struct pt_regs *))
> > +{
> > + if (handle_arch_irq)
> > + return;
> > +
> > + handle_arch_irq = handle_irq;
> > +}
>
> Please don't introduce yet another variant of that. Please use
> CONFIG_GENERIC_IRQ_MULTI_HANDLER which provides that in the generic code.
Ok.
>
> Btw, some of your patches have tab vs. space inconsistencies, e.g.
>
> + siginfo_t info;
> + int fault;
> + unsigned long address = mmu_meh & PAGE_MASK
Thx, I'll re-check.
Best Regards
Guo Ren
next prev parent reply other threads:[~2018-09-10 7:30 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 12:07 [PATCH V3 00/26] C-SKY(csky) Linux Kernel Port Guo Ren
2018-09-05 12:07 ` [PATCH V3 01/26] csky: Build infrastructure Guo Ren
2018-09-05 12:07 ` [PATCH V3 02/26] csky: defconfig Guo Ren
2018-09-06 13:58 ` Arnd Bergmann
2018-09-07 1:43 ` Guo Ren
2018-09-05 12:07 ` [PATCH V3 03/26] csky: Kernel booting Guo Ren
2018-09-05 12:07 ` [PATCH V3 04/26] csky: Exception handling Guo Ren
2018-09-05 12:07 ` [PATCH V3 05/26] csky: System Call Guo Ren
2018-09-06 14:10 ` Arnd Bergmann
2018-09-07 1:47 ` Guo Ren
2018-09-05 12:07 ` [PATCH V3 06/26] csky: Cache and TLB routines Guo Ren
2018-09-06 14:31 ` Arnd Bergmann
2018-09-07 3:04 ` Guo Ren
2018-09-07 8:14 ` Arnd Bergmann
2018-09-07 12:55 ` Guo Ren
2018-09-07 14:13 ` Arnd Bergmann
2018-09-08 2:20 ` Guo Ren
2018-09-05 12:07 ` [PATCH V3 07/26] csky: MMU and page table management Guo Ren
2018-09-05 12:07 ` [PATCH V3 08/26] csky: Process management and Signal Guo Ren
2018-09-05 12:07 ` [PATCH V3 09/26] csky: VDSO and rt_sigreturn Guo Ren
2018-09-06 14:02 ` Arnd Bergmann
2018-09-07 3:07 ` Guo Ren
2018-09-05 12:07 ` [PATCH V3 10/26] csky: IRQ handling Guo Ren
2018-09-06 13:39 ` Thomas Gleixner
2018-09-10 7:30 ` Guo Ren [this message]
2018-09-05 12:07 ` [PATCH V3 11/26] csky: Atomic operations Guo Ren
2018-09-05 12:07 ` [PATCH V3 12/26] csky: ELF and module probe Guo Ren
2018-09-05 12:07 ` [PATCH V3 13/26] csky: Library functions Guo Ren
2018-09-06 14:24 ` Arnd Bergmann
2018-09-06 15:50 ` Geert Uytterhoeven
2018-09-07 5:14 ` Guo Ren
2018-09-07 5:08 ` Guo Ren
2018-09-05 12:07 ` [PATCH V3 14/26] csky: User access Guo Ren
2018-09-05 12:07 ` [PATCH V3 15/26] csky: Debug and Ptrace GDB Guo Ren
2018-09-05 12:07 ` [PATCH V3 16/26] csky: SMP support Guo Ren
2018-09-05 12:07 ` [PATCH V3 17/26] csky: Misc headers Guo Ren
2018-09-06 14:16 ` Arnd Bergmann
2018-09-07 5:17 ` Guo Ren
2018-09-07 8:01 ` Arnd Bergmann
2018-09-07 8:08 ` Guo Ren
2018-09-05 12:07 ` [PATCH V3 18/26] dt-bindings: csky CPU Bindings Guo Ren
2018-09-06 0:37 ` Rob Herring
2018-09-06 1:49 ` Guo Ren
2018-09-05 12:07 ` [PATCH V3 19/26] dt-bindings: timer: gx6605s SOC timer Guo Ren
2018-09-06 0:47 ` Rob Herring
2018-09-06 2:02 ` Guo Ren
2018-09-07 6:41 ` Guo Ren
2018-09-05 12:07 ` [PATCH V3 20/26] dt-bindings: timer: C-SKY Multi-processor timer Guo Ren
2018-09-05 12:08 ` [PATCH V3 21/26] dt-bindings: interrupt-controller: C-SKY APB intc Guo Ren
2018-09-06 0:43 ` Rob Herring
2018-09-06 2:12 ` Guo Ren
2018-09-06 13:05 ` Arnd Bergmann
2018-09-07 5:40 ` Guo Ren
2018-09-07 15:13 ` Rob Herring
2018-09-07 15:13 ` Rob Herring
2018-09-08 2:05 ` Guo Ren
2018-09-08 2:05 ` Guo Ren
2018-09-05 12:08 ` [PATCH V3 22/26] dt-bindings: interrupt-controller: C-SKY SMP intc Guo Ren
2018-09-06 0:45 ` Rob Herring
2018-09-06 2:23 ` Guo Ren
2018-09-06 13:03 ` Arnd Bergmann
2018-09-07 6:07 ` Guo Ren
2018-09-05 12:08 ` [PATCH V3 23/26] clocksource: add gx6605s SOC system timer Guo Ren
2018-09-05 12:08 ` [PATCH V3 24/26] clocksource: add C-SKY SMP timer Guo Ren
2018-09-05 12:08 ` [PATCH V3 25/26] clocksource: add C-SKY timers' build infrastructure Guo Ren
2018-09-05 12:08 ` [PATCH V3 26/26] irqchip: add C-SKY irqchip drivers Guo Ren
2018-09-06 14:35 ` [PATCH V3 00/26] C-SKY(csky) Linux Kernel Port Arnd Bergmann
2018-09-07 2:08 ` Guenter Roeck
2018-09-07 6:40 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910073039.GA4022@guoren-Inspiron-7460 \
--to=ren_guo@c-sky.com \
--cc=arnd@arndb.de \
--cc=c-sky_gcc_upstream@c-sky.com \
--cc=daniel.lezcano@linaro.org \
--cc=gnu-csky@mentor.com \
--cc=green.hu@gmail.com \
--cc=jason@lakedaemon.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.petazzoni@bootlin.com \
--cc=wbx@uclibc-ng.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.