All of lore.kernel.org
 help / color / mirror / Atom feed
* Fwd: [PATCH] tee: optee: log message if dynamic shm is enabled
       [not found] <CAHqM-Qgy7zPjrnNm0Xdyz_F_BYbSPgDfQrkv0tGv_rB1G7tSXg@mail.gmail.com>
@ 2018-09-10  8:57   ` Victor Chong
  0 siblings, 0 replies; 6+ messages in thread
From: Victor Chong @ 2018-09-10  8:57 UTC (permalink / raw)
  To: Jens Wiklander; +Cc: tee-dev, linux-kernel, linux-arm-kernel

Suggested-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Victor Chong <victor.chong@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
---
 drivers/tee/optee/core.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
index e1aafe842d66..cca5c091e55a 100644
--- a/drivers/tee/optee/core.c
+++ b/drivers/tee/optee/core.c
@@ -631,6 +631,9 @@ static struct optee *optee_probe(struct device_node *np)

        optee_enable_shm_cache(optee);

+       if (optee->sec_caps & OPTEE_SMC_SEC_CAP_DYNAMIC_SHM)
+               pr_info("dynamic shared memory is enabled\n");
+
        pr_info("initialized driver\n");
        return optee;
 err:
--
2.17.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Fwd: [PATCH] tee: optee: log message if dynamic shm is enabled
@ 2018-09-10  8:57   ` Victor Chong
  0 siblings, 0 replies; 6+ messages in thread
From: Victor Chong @ 2018-09-10  8:57 UTC (permalink / raw)
  To: linux-arm-kernel

Suggested-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Victor Chong <victor.chong@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
---
 drivers/tee/optee/core.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
index e1aafe842d66..cca5c091e55a 100644
--- a/drivers/tee/optee/core.c
+++ b/drivers/tee/optee/core.c
@@ -631,6 +631,9 @@ static struct optee *optee_probe(struct device_node *np)

        optee_enable_shm_cache(optee);

+       if (optee->sec_caps & OPTEE_SMC_SEC_CAP_DYNAMIC_SHM)
+               pr_info("dynamic shared memory is enabled\n");
+
        pr_info("initialized driver\n");
        return optee;
 err:
--
2.17.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: Fwd: [PATCH] tee: optee: log message if dynamic shm is enabled
  2018-09-10  8:57   ` Victor Chong
@ 2018-09-10  9:20     ` Daniel Thompson
  -1 siblings, 0 replies; 6+ messages in thread
From: Daniel Thompson @ 2018-09-10  9:20 UTC (permalink / raw)
  To: Victor Chong; +Cc: Jens Wiklander, tee-dev, linux-kernel, linux-arm-kernel

On Mon, Sep 10, 2018 at 05:57:28PM +0900, Victor Chong wrote:

This (empty) patch description seems unusually terse! Surely there
should be some clues in the description about why this messages
deserves user/dev/admin attention...


> Suggested-by: Jerome Forissier <jerome.forissier@linaro.org>
> Signed-off-by: Victor Chong <victor.chong@linaro.org>
> Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
> ---
>  drivers/tee/optee/core.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
> index e1aafe842d66..cca5c091e55a 100644
> --- a/drivers/tee/optee/core.c
> +++ b/drivers/tee/optee/core.c
> @@ -631,6 +631,9 @@ static struct optee *optee_probe(struct device_node *np)
> 
>         optee_enable_shm_cache(optee);
> 
> +       if (optee->sec_caps & OPTEE_SMC_SEC_CAP_DYNAMIC_SHM)
> +               pr_info("dynamic shared memory is enabled\n");
> +
>         pr_info("initialized driver\n");
>         return optee;
>  err:
> --
> 2.17.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Fwd: [PATCH] tee: optee: log message if dynamic shm is enabled
@ 2018-09-10  9:20     ` Daniel Thompson
  0 siblings, 0 replies; 6+ messages in thread
From: Daniel Thompson @ 2018-09-10  9:20 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Sep 10, 2018 at 05:57:28PM +0900, Victor Chong wrote:

This (empty) patch description seems unusually terse! Surely there
should be some clues in the description about why this messages
deserves user/dev/admin attention...


> Suggested-by: Jerome Forissier <jerome.forissier@linaro.org>
> Signed-off-by: Victor Chong <victor.chong@linaro.org>
> Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
> ---
>  drivers/tee/optee/core.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
> index e1aafe842d66..cca5c091e55a 100644
> --- a/drivers/tee/optee/core.c
> +++ b/drivers/tee/optee/core.c
> @@ -631,6 +631,9 @@ static struct optee *optee_probe(struct device_node *np)
> 
>         optee_enable_shm_cache(optee);
> 
> +       if (optee->sec_caps & OPTEE_SMC_SEC_CAP_DYNAMIC_SHM)
> +               pr_info("dynamic shared memory is enabled\n");
> +
>         pr_info("initialized driver\n");
>         return optee;
>  err:
> --
> 2.17.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Fwd: [PATCH] tee: optee: log message if dynamic shm is enabled
  2018-09-10  9:20     ` Daniel Thompson
@ 2018-09-10  9:33       ` Victor Chong
  -1 siblings, 0 replies; 6+ messages in thread
From: Victor Chong @ 2018-09-10  9:33 UTC (permalink / raw)
  To: Daniel Thompson; +Cc: Jens Wiklander, tee-dev, linux-kernel, linux-arm-kernel

On Mon, Sep 10, 2018 at 6:20 PM, Daniel Thompson
<daniel.thompson@linaro.org> wrote:
> On Mon, Sep 10, 2018 at 05:57:28PM +0900, Victor Chong wrote:
>
> This (empty) patch description seems unusually terse! Surely there
> should be some clues in the description about why this messages
> deserves user/dev/admin attention...

Ok. Will add description and send out v2.

Thanks

>
>
>> Suggested-by: Jerome Forissier <jerome.forissier@linaro.org>
>> Signed-off-by: Victor Chong <victor.chong@linaro.org>
>> Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
>> ---
>>  drivers/tee/optee/core.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
>> index e1aafe842d66..cca5c091e55a 100644
>> --- a/drivers/tee/optee/core.c
>> +++ b/drivers/tee/optee/core.c
>> @@ -631,6 +631,9 @@ static struct optee *optee_probe(struct device_node *np)
>>
>>         optee_enable_shm_cache(optee);
>>
>> +       if (optee->sec_caps & OPTEE_SMC_SEC_CAP_DYNAMIC_SHM)
>> +               pr_info("dynamic shared memory is enabled\n");
>> +
>>         pr_info("initialized driver\n");
>>         return optee;
>>  err:
>> --
>> 2.17.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Fwd: [PATCH] tee: optee: log message if dynamic shm is enabled
@ 2018-09-10  9:33       ` Victor Chong
  0 siblings, 0 replies; 6+ messages in thread
From: Victor Chong @ 2018-09-10  9:33 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Sep 10, 2018 at 6:20 PM, Daniel Thompson
<daniel.thompson@linaro.org> wrote:
> On Mon, Sep 10, 2018 at 05:57:28PM +0900, Victor Chong wrote:
>
> This (empty) patch description seems unusually terse! Surely there
> should be some clues in the description about why this messages
> deserves user/dev/admin attention...

Ok. Will add description and send out v2.

Thanks

>
>
>> Suggested-by: Jerome Forissier <jerome.forissier@linaro.org>
>> Signed-off-by: Victor Chong <victor.chong@linaro.org>
>> Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
>> ---
>>  drivers/tee/optee/core.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
>> index e1aafe842d66..cca5c091e55a 100644
>> --- a/drivers/tee/optee/core.c
>> +++ b/drivers/tee/optee/core.c
>> @@ -631,6 +631,9 @@ static struct optee *optee_probe(struct device_node *np)
>>
>>         optee_enable_shm_cache(optee);
>>
>> +       if (optee->sec_caps & OPTEE_SMC_SEC_CAP_DYNAMIC_SHM)
>> +               pr_info("dynamic shared memory is enabled\n");
>> +
>>         pr_info("initialized driver\n");
>>         return optee;
>>  err:
>> --
>> 2.17.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-09-10  9:33 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CAHqM-Qgy7zPjrnNm0Xdyz_F_BYbSPgDfQrkv0tGv_rB1G7tSXg@mail.gmail.com>
2018-09-10  8:57 ` Fwd: [PATCH] tee: optee: log message if dynamic shm is enabled Victor Chong
2018-09-10  8:57   ` Victor Chong
2018-09-10  9:20   ` Daniel Thompson
2018-09-10  9:20     ` Daniel Thompson
2018-09-10  9:33     ` Victor Chong
2018-09-10  9:33       ` Victor Chong

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.