All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
	DRI Development <dri-devel@lists.freedesktop.org>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Kees Cook <keescook@chromium.org>,
	linux-fbdev@vger.kernel.org,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 3/4] fbdev: Add FBINFO_HIDE_SMEM_START flag
Date: Mon, 10 Sep 2018 14:51:01 +0200	[thread overview]
Message-ID: <20180910125103eucas1p1e7da7341048a5e54a89e21a94559f576~TCuHaF7jg0750707507eucas1p1q@eucas1p1.samsung.com> (raw)
In-Reply-To: <20180822085405.10787-3-daniel.vetter@ffwll.ch>


On 08/22/2018 10:54 AM, Daniel Vetter wrote:
> DRM drivers really, really, really don't want random userspace to
> share buffer behind it's back, bypassing the dma-buf buffer sharing
> machanism. For that reason we've ruthlessly rejected any IOCTL
> exposing the physical address of any graphics buffer.
> 
> Unfortunately fbdev comes with that built-in. We could just set
> smem_start to 0, but that means we'd have to hand-roll our own fb_mmap
> implementation. For good reasons many drivers do that, but
> smem_start/length is still super convenient.
> 
> Hence instead just stop the leak in the ioctl, to keep fb mmap working
> as-is. A second patch will set this flag for all drm drivers.
> 
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: linux-fbdev@vger.kernel.org
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

WARNING: multiple messages have this Message-ID (diff)
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
	DRI Development <dri-devel@lists.freedesktop.org>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Kees Cook <keescook@chromium.org>,
	linux-fbdev@vger.kernel.org,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 3/4] fbdev: Add FBINFO_HIDE_SMEM_START flag
Date: Mon, 10 Sep 2018 12:51:01 +0000	[thread overview]
Message-ID: <20180910125103eucas1p1e7da7341048a5e54a89e21a94559f576~TCuHaF7jg0750707507eucas1p1q@eucas1p1.samsung.com> (raw)
In-Reply-To: <20180822085405.10787-3-daniel.vetter@ffwll.ch>


On 08/22/2018 10:54 AM, Daniel Vetter wrote:
> DRM drivers really, really, really don't want random userspace to
> share buffer behind it's back, bypassing the dma-buf buffer sharing
> machanism. For that reason we've ruthlessly rejected any IOCTL
> exposing the physical address of any graphics buffer.
> 
> Unfortunately fbdev comes with that built-in. We could just set
> smem_start to 0, but that means we'd have to hand-roll our own fb_mmap
> implementation. For good reasons many drivers do that, but
> smem_start/length is still super convenient.
> 
> Hence instead just stop the leak in the ioctl, to keep fb mmap working
> as-is. A second patch will set this flag for all drm drivers.
> 
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: linux-fbdev@vger.kernel.org
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

  parent reply	other threads:[~2018-09-10 12:51 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180822085418epcas5p30ab8aa4b49ba204f4891760af002bce1@epcas5p3.samsung.com>
2018-08-22  8:54 ` [PATCH 1/4] fbdev: Drop FBINFO_CAN_FORCE_OUTPUT flag Daniel Vetter
2018-08-22  8:54   ` Daniel Vetter
2018-08-22  8:54   ` [PATCH 2/4] vt: Remove vc_panic_force_write Daniel Vetter
2018-08-22  8:59     ` Greg Kroah-Hartman
2018-08-22  8:59       ` Greg Kroah-Hartman
2018-09-11 12:11       ` Daniel Vetter
2018-08-22  8:54   ` [PATCH 3/4] fbdev: Add FBINFO_HIDE_SMEM_START flag Daniel Vetter
2018-08-22  8:54     ` Daniel Vetter
2018-08-22  8:54     ` Daniel Vetter
2018-09-03 16:48     ` Daniel Vetter
2018-09-03 16:48       ` Daniel Vetter
2018-09-03 16:48       ` Daniel Vetter
2018-09-10 12:51     ` Bartlomiej Zolnierkiewicz [this message]
2018-09-10 12:51       ` Bartlomiej Zolnierkiewicz
2018-08-22  8:54   ` [PATCH 4/4] drm/fb: Stop leaking physical address Daniel Vetter
2018-08-22 12:57     ` Sean Paul
2018-08-22 12:57       ` Sean Paul
2018-08-22  9:21   ` ✓ Fi.CI.BAT: success for series starting with [1/4] fbdev: Drop FBINFO_CAN_FORCE_OUTPUT flag Patchwork
2018-08-22 10:09   ` ✓ Fi.CI.IGT: " Patchwork
2018-09-10 12:48   ` [PATCH 1/4] " Bartlomiej Zolnierkiewicz
2018-09-10 12:48     ` Bartlomiej Zolnierkiewicz
2018-09-10 12:48     ` Bartlomiej Zolnierkiewicz
2018-09-11  7:42     ` Daniel Vetter
2018-09-11  7:42       ` Daniel Vetter
2018-09-11  7:42       ` Daniel Vetter
2018-09-11  8:47       ` Bartlomiej Zolnierkiewicz
2018-09-11  8:47         ` Bartlomiej Zolnierkiewicz
2018-09-11  8:47         ` Bartlomiej Zolnierkiewicz
2018-09-11 12:12         ` [Intel-gfx] " Daniel Vetter
2018-09-11 12:12           ` Daniel Vetter
2018-09-11 12:12           ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20180910125103eucas1p1e7da7341048a5e54a89e21a94559f576~TCuHaF7jg0750707507eucas1p1q@eucas1p1.samsung.com' \
    --to=b.zolnierkie@samsung.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=keescook@chromium.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.