All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Frank Rowand <frowand.list@gmail.com>,
	Ley Foon Tan <lftan@altera.com>,
	nios2-dev@lists.rocketboards.org
Subject: [PATCH v3 3/9] nios2: use common rules to build built-in dtb
Date: Mon, 10 Sep 2018 10:03:57 -0500	[thread overview]
Message-ID: <20180910150403.19476-4-robh@kernel.org> (raw)
In-Reply-To: <20180910150403.19476-1-robh@kernel.org>

Using the common build support for built-in dtb files just requires
adding a .dtb.o target to obj-y.

This has the side effect that CONFIG_NIOS2_DTB_SOURCE should now be just
the dts filename in arch/nios2/boot/dts/ directory. Before any path was
supported, but if you want to build in your dtb to the kernel, it should
be in the kernel tree.

Cc: Ley Foon Tan <lftan@altera.com>
Cc: nios2-dev@lists.rocketboards.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
 arch/nios2/Makefile          |  6 ++----
 arch/nios2/boot/Makefile     | 14 --------------
 arch/nios2/boot/dts/Makefile |  2 ++
 arch/nios2/boot/linked_dtb.S | 19 -------------------
 4 files changed, 4 insertions(+), 37 deletions(-)
 delete mode 100644 arch/nios2/boot/linked_dtb.S

diff --git a/arch/nios2/Makefile b/arch/nios2/Makefile
index 50eece1c6adb..db2e78fe65c7 100644
--- a/arch/nios2/Makefile
+++ b/arch/nios2/Makefile
@@ -49,16 +49,14 @@ BOOT_TARGETS = vmImage zImage
 PHONY += $(BOOT_TARGETS) install
 KBUILD_IMAGE := $(nios2-boot)/vmImage
 
-ifneq ($(CONFIG_NIOS2_DTB_SOURCE),"")
-	core-y	+= $(nios2-boot)/
-endif
+core-y	+= $(nios2-boot)/dts/
 
 all: vmImage
 
 archclean:
 	$(Q)$(MAKE) $(clean)=$(nios2-boot)
 
-%.dtb: | scripts
+%.dtb %.dtb.S %.dtb.o: | scripts
 	$(Q)$(MAKE) $(build)=$(nios2-boot)/dts $(nios2-boot)/dts/$@
 
 dtbs:
diff --git a/arch/nios2/boot/Makefile b/arch/nios2/boot/Makefile
index 007586094dde..0b48f1bf086d 100644
--- a/arch/nios2/boot/Makefile
+++ b/arch/nios2/boot/Makefile
@@ -31,20 +31,6 @@ $(obj)/zImage: $(obj)/compressed/vmlinux FORCE
 $(obj)/compressed/vmlinux: $(obj)/vmlinux.gz FORCE
 	$(Q)$(MAKE) $(build)=$(obj)/compressed $@
 
-# Rule to build device tree blobs
-DTB_SRC := $(patsubst "%",%,$(CONFIG_NIOS2_DTB_SOURCE))
-
-# Make sure the generated dtb gets removed during clean
-extra-$(CONFIG_NIOS2_DTB_SOURCE_BOOL) += system.dtb
-
-$(obj)/system.dtb: $(DTB_SRC) FORCE
-	$(call cmd,dtc)
-
-# Ensure system.dtb exists
-$(obj)/linked_dtb.o: $(obj)/system.dtb
-
-obj-$(CONFIG_NIOS2_DTB_SOURCE_BOOL) += linked_dtb.o
-
 targets += $(dtb-y)
 
 $(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y))
diff --git a/arch/nios2/boot/dts/Makefile b/arch/nios2/boot/dts/Makefile
index f66554cd5c45..f6358e395b25 100644
--- a/arch/nios2/boot/dts/Makefile
+++ b/arch/nios2/boot/dts/Makefile
@@ -1 +1,3 @@
 # SPDX-License-Identifier: GPL-2.0
+
+obj-y := $(patsubst "%.dts",%.dtb.o,$(CONFIG_NIOS2_DTB_SOURCE))
diff --git a/arch/nios2/boot/linked_dtb.S b/arch/nios2/boot/linked_dtb.S
deleted file mode 100644
index 071f922db338..000000000000
--- a/arch/nios2/boot/linked_dtb.S
+++ /dev/null
@@ -1,19 +0,0 @@
-/*
- * Copyright (C) 2011 Thomas Chou <thomas@wytron.com.tw>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- *
- */
-.section .dtb.init.rodata,"a"
-.incbin "arch/nios2/boot/system.dtb"
-- 
2.17.1


  parent reply	other threads:[~2018-09-10 15:04 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-10 15:03 [PATCH v3 0/9] Devicetree build consolidation Rob Herring
2018-09-10 15:03 ` Rob Herring
2018-09-10 15:03 ` Rob Herring
2018-09-10 15:03 ` Rob Herring
2018-09-10 15:03 ` [PATCH v3 1/9] powerpc: build .dtb files in dts directory Rob Herring
2018-09-27 13:39   ` Rob Herring
2018-09-10 15:03 ` [PATCH v3 2/9] nios2: " Rob Herring
2018-09-10 15:03 ` Rob Herring [this message]
2018-09-10 15:03 ` [PATCH v3 4/9] nios2: fix building all dtbs Rob Herring
2018-09-10 15:03 ` [PATCH v3 5/9] c6x: use common built-in dtb support Rob Herring
2018-09-10 15:04 ` [PATCH v3 6/9] kbuild: consolidate Devicetree dtb build rules Rob Herring
2018-09-10 15:04   ` Rob Herring
2018-09-10 15:04   ` Rob Herring
2018-09-10 15:04   ` Rob Herring
2018-09-11 15:40   ` Rob Herring
2018-09-11 15:40     ` Rob Herring
2018-09-11 15:40     ` Rob Herring
2018-09-11 15:40     ` Rob Herring
2018-09-11 15:40     ` Rob Herring
2018-09-12  1:00     ` Masahiro Yamada
2018-09-12  1:00       ` Masahiro Yamada
2018-09-12  1:00       ` Masahiro Yamada
2018-09-12  1:00       ` Masahiro Yamada
2018-09-12  1:00       ` Masahiro Yamada
2018-09-13 15:51       ` Geert Uytterhoeven
2018-09-13 15:51         ` Geert Uytterhoeven
2018-09-13 15:51         ` Geert Uytterhoeven
2018-09-13 15:51         ` Geert Uytterhoeven
2018-09-13 15:51         ` Geert Uytterhoeven
2018-09-23 10:31         ` Masahiro Yamada
2018-09-23 10:31           ` Masahiro Yamada
2018-09-23 10:31           ` Masahiro Yamada
2018-09-23 10:31           ` Masahiro Yamada
2018-09-23 10:31           ` Masahiro Yamada
2018-09-28 15:41           ` Rob Herring
2018-09-28 15:41             ` Rob Herring
2018-09-28 15:41             ` Rob Herring
2018-09-28 15:41             ` Rob Herring
2018-09-28 15:41             ` Rob Herring
2018-09-28 15:41             ` Rob Herring
2018-10-01  5:49             ` Masahiro Yamada
2018-10-01  5:49               ` Masahiro Yamada
2018-10-01  5:49               ` Masahiro Yamada
2018-10-01  5:49               ` Masahiro Yamada
2018-10-01  5:49               ` Masahiro Yamada
2018-10-01  5:49               ` Masahiro Yamada
2018-10-01 13:25               ` Rob Herring
2018-10-01 13:25                 ` Rob Herring
2018-10-01 13:25                 ` Rob Herring
2018-10-01 13:25                 ` Rob Herring
2018-10-01 13:25                 ` Rob Herring
2018-10-01 13:25                 ` Rob Herring
2018-10-01 14:48                 ` Masahiro Yamada
2018-10-01 14:48                   ` Masahiro Yamada
2018-10-01 14:48                   ` Masahiro Yamada
2018-10-01 14:48                   ` Masahiro Yamada
2018-10-01 14:48                   ` Masahiro Yamada
2018-10-01 14:48                   ` Masahiro Yamada
2018-09-28 17:21         ` Andreas Färber
2018-09-28 17:21           ` Andreas Färber
2018-09-28 17:21           ` Andreas Färber
2018-09-28 17:21           ` Andreas Färber
2018-09-28 17:21           ` Andreas Färber
2018-09-28 18:41           ` Rob Herring
2018-09-28 18:41             ` Rob Herring
2018-09-28 18:41             ` Rob Herring
2018-09-28 18:41             ` Rob Herring
2018-09-28 18:41             ` Rob Herring
2018-09-28 18:41             ` Rob Herring
2018-10-01  7:53             ` Geert Uytterhoeven
2018-10-01  7:53               ` Geert Uytterhoeven
2018-10-01  7:53               ` Geert Uytterhoeven
2018-10-01  7:53               ` Geert Uytterhoeven
2018-10-01  7:53               ` Geert Uytterhoeven
2018-09-10 15:04 ` [PATCH v3 7/9] powerpc: enable building all dtbs Rob Herring
2018-09-10 15:04 ` [PATCH v3 8/9] c6x: " Rob Herring
2018-09-10 15:04 ` [PATCH v3 9/9] microblaze: " Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180910150403.19476-4-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=lftan@altera.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nios2-dev@lists.rocketboards.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.