From: Tiwei Bie <tiwei.bie@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: Ilya Maximets <i.maximets@samsung.com>,
Nikolay Nikolaev <nicknickolaev@gmail.com>,
zhihong.wang@intel.com, dev@dpdk.org
Subject: Re: [PATCH v2 5/5] vhost: message handling implemented as a callback array
Date: Tue, 11 Sep 2018 09:51:17 +0800 [thread overview]
Message-ID: <20180911015117.GA8195@debian> (raw)
In-Reply-To: <cb341c2e-3b6d-0964-ad5e-d6b657244e7e@redhat.com>
On Mon, Sep 10, 2018 at 06:43:17PM +0200, Maxime Coquelin wrote:
> Hi Ilya,
>
> On 09/10/2018 06:09 PM, Ilya Maximets wrote:
> > Hi Maxime,
> > Thanks for pointing to this patch set. I missed it somehow.
> >
> > This patch could not replace mine [1], because it does not improve
> > the message handling from the error handling point of view. But
> > it completely changes the code, so we need to negotiate the order
> > in which they will be applied or combine them somehow.
>
> By complementary I meant both of your patches add similar things, like
> vhost_user_set_vring_kick() becoming an int (even if Nikolay's version
> doesn't return an error for now).
>
> >
> > So, what's the plan? What do you think?
>
> On one hand Nikolay's series was posted first, and it might be easier to
> just apply your patch on top. On the other hand, your patch fixes an
> issue, so it will be easier to backport it if it is applied first.
>
> I guess we should go for your patch first to ease backporting.
>
> I'd like Tiwei's feedback before applying anything, as he reviewed the
> first versions of both yours and Nikolay's patches.
I also incline to merge the fix patch first, as it needs
to be backported.
>
> > Few comments inline.
> >
> > [1] http://patchwork.dpdk.org/patch/44168/
[...]
next prev parent reply other threads:[~2018-09-11 1:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 19:13 [PATCH v2 0/5] vhost_user.c code cleanup Nikolay Nikolaev
2018-07-19 19:13 ` [PATCH v2 1/5] vhost: unify VhostUserMsg usage Nikolay Nikolaev
2018-09-10 15:04 ` Maxime Coquelin
2018-07-19 19:13 ` [PATCH v2 2/5] vhost: make message handling functions prepare the reply Nikolay Nikolaev
2018-09-10 15:08 ` Maxime Coquelin
2018-07-19 19:13 ` [PATCH v2 3/5] vhost: handle unsupported message types in functions Nikolay Nikolaev
2018-09-10 15:15 ` Maxime Coquelin
2018-07-19 19:13 ` [PATCH v2 4/5] vhost: unify message handling function signature Nikolay Nikolaev
2018-09-10 15:24 ` Maxime Coquelin
2018-07-19 19:13 ` [PATCH v2 5/5] vhost: message handling implemented as a callback array Nikolay Nikolaev
2018-09-10 15:32 ` Maxime Coquelin
2018-09-10 16:09 ` Ilya Maximets
2018-09-10 16:43 ` Maxime Coquelin
2018-09-11 1:51 ` Tiwei Bie [this message]
2018-09-11 9:38 ` [PATCH v2 0/5] vhost_user.c code cleanup Maxime Coquelin
2018-09-12 15:34 ` Nikolay Nikolaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180911015117.GA8195@debian \
--to=tiwei.bie@intel.com \
--cc=dev@dpdk.org \
--cc=i.maximets@samsung.com \
--cc=maxime.coquelin@redhat.com \
--cc=nicknickolaev@gmail.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.