From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9B5EC6778D for ; Tue, 11 Sep 2018 07:34:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6018920865 for ; Tue, 11 Sep 2018 07:34:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="TwOhGWZi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6018920865 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727287AbeIKMcm (ORCPT ); Tue, 11 Sep 2018 08:32:42 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:45719 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726353AbeIKMcm (ORCPT ); Tue, 11 Sep 2018 08:32:42 -0400 Received: by mail-ed1-f68.google.com with SMTP id p52-v6so18407511eda.12 for ; Tue, 11 Sep 2018 00:34:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=GQoWPqbfqOFb0F1rWXeI46EOiKsH46LnXSKEVSaW3Oo=; b=TwOhGWZijh92DhqY6h5dNEzNJ4fFNHtuoas3NxA3tJqQuHj32O6bKgL3eabcOqTAD9 uwCQM1hvtihHFN5caK1U+8UOQyFDZ4J3apiTdasf/GY3MVpzX0oh0YFbmuA9dzv312DM kbFiEbkCs10KVOAXWtKOB9PLXMi3r9EGiXZC0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=GQoWPqbfqOFb0F1rWXeI46EOiKsH46LnXSKEVSaW3Oo=; b=P6Ups7fqqjxz8wEKJZGwdhpbifXnDQwfz9w1a6yFh05KE0IHxGiiokQs0ihVWOk3WC 6HIssWDpL7LAyKRKyKYM5vM/XYm2LUogpOk2odp/tHVW+7u0faERqj6EXhsMME8ZI8Go 4CYGngmgrTJo2YuBDW/+t13uDQQV9+OPEPzjplnPSo/Kk+oSMZYcjgeq1AZkKCTgnVH8 15DDMXzrOfQQ2IiddGCNts8zvWV2uKBHXqq+dMAXfnr+OG+9A74Utlsr6iYSUkqlf0eJ Wal0SwHKOChyC0V3d3Vh5MO8yrU+9HDZsJg9y6jhSuQb6KzB+LKpIoQAZK4lqKoYaegG I72Q== X-Gm-Message-State: APzg51D7GieS3J/I6LqVYxdvJsZiPkS6oxFA/5LI4ffiMLBmxojxxSVA PYhHxNzkHvEpJukP1w+xZSXw1Q== X-Google-Smtp-Source: ANB0VdZUQaLUTZMZNebE2Uo32SHbObAHHWFhv1oPv+DXZsdgWmyX+L165iYyPwNT6vlfWJoj03nhPA== X-Received: by 2002:a50:a38a:: with SMTP id s10-v6mr25598214edb.99.1536651281557; Tue, 11 Sep 2018 00:34:41 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id w20-v6sm18874627edc.12.2018.09.11.00.34.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Sep 2018 00:34:40 -0700 (PDT) Date: Tue, 11 Sep 2018 09:34:39 +0200 From: Daniel Vetter To: YueHaibing Cc: Gustavo Padovan , Maarten Lankhorst , Sean Paul , David Airlie , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH -next] drm: Remove set but not used variable 'config' Message-ID: <20180911073438.GG19774@phenom.ffwll.local> Mail-Followup-To: YueHaibing , Gustavo Padovan , Maarten Lankhorst , Sean Paul , David Airlie , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <1536646814-186429-1-git-send-email-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1536646814-186429-1-git-send-email-yuehaibing@huawei.com> X-Operating-System: Linux phenom 4.14.0-3-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 11, 2018 at 06:20:14AM +0000, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/drm_plane.c: In function 'drm_mode_getplane_res': > drivers/gpu/drm/drm_plane.c:475:26: warning: > variable 'config' set but not used [-Wunused-but-set-variable] > > Signed-off-by: YueHaibing Applied, thanks. -Daniel > --- > drivers/gpu/drm/drm_plane.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c > index 36bf3fe..4a72c68 100644 > --- a/drivers/gpu/drm/drm_plane.c > +++ b/drivers/gpu/drm/drm_plane.c > @@ -472,7 +472,6 @@ int drm_mode_getplane_res(struct drm_device *dev, void *data, > struct drm_file *file_priv) > { > struct drm_mode_get_plane_res *plane_resp = data; > - struct drm_mode_config *config; > struct drm_plane *plane; > uint32_t __user *plane_ptr; > int count = 0; > @@ -480,7 +479,6 @@ int drm_mode_getplane_res(struct drm_device *dev, void *data, > if (!drm_core_check_feature(dev, DRIVER_MODESET)) > return -EINVAL; > > - config = &dev->mode_config; > plane_ptr = u64_to_user_ptr(plane_resp->plane_id_ptr); > > /* > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Tue, 11 Sep 2018 07:34:39 +0000 Subject: Re: [PATCH -next] drm: Remove set but not used variable 'config' Message-Id: <20180911073438.GG19774@phenom.ffwll.local> List-Id: References: <1536646814-186429-1-git-send-email-yuehaibing@huawei.com> In-Reply-To: <1536646814-186429-1-git-send-email-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: YueHaibing Cc: David Airlie , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sean Paul On Tue, Sep 11, 2018 at 06:20:14AM +0000, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/drm_plane.c: In function 'drm_mode_getplane_res': > drivers/gpu/drm/drm_plane.c:475:26: warning: > variable 'config' set but not used [-Wunused-but-set-variable] > > Signed-off-by: YueHaibing Applied, thanks. -Daniel > --- > drivers/gpu/drm/drm_plane.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c > index 36bf3fe..4a72c68 100644 > --- a/drivers/gpu/drm/drm_plane.c > +++ b/drivers/gpu/drm/drm_plane.c > @@ -472,7 +472,6 @@ int drm_mode_getplane_res(struct drm_device *dev, void *data, > struct drm_file *file_priv) > { > struct drm_mode_get_plane_res *plane_resp = data; > - struct drm_mode_config *config; > struct drm_plane *plane; > uint32_t __user *plane_ptr; > int count = 0; > @@ -480,7 +479,6 @@ int drm_mode_getplane_res(struct drm_device *dev, void *data, > if (!drm_core_check_feature(dev, DRIVER_MODESET)) > return -EINVAL; > > - config = &dev->mode_config; > plane_ptr = u64_to_user_ptr(plane_resp->plane_id_ptr); > > /* > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH -next] drm: Remove set but not used variable 'config' Date: Tue, 11 Sep 2018 09:34:39 +0200 Message-ID: <20180911073438.GG19774@phenom.ffwll.local> References: <1536646814-186429-1-git-send-email-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 04CE1892B2 for ; Tue, 11 Sep 2018 07:34:42 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id h33-v6so18422881edb.5 for ; Tue, 11 Sep 2018 00:34:42 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1536646814-186429-1-git-send-email-yuehaibing@huawei.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: YueHaibing Cc: David Airlie , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sean Paul List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBTZXAgMTEsIDIwMTggYXQgMDY6MjA6MTRBTSArMDAwMCwgWXVlSGFpYmluZyB3cm90 ZToKPiBGaXhlcyBnY2MgJy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGUnIHdhcm5pbmc6Cj4gCj4g ZHJpdmVycy9ncHUvZHJtL2RybV9wbGFuZS5jOiBJbiBmdW5jdGlvbiAnZHJtX21vZGVfZ2V0cGxh bmVfcmVzJzoKPiBkcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5lLmM6NDc1OjI2OiB3YXJuaW5nOgo+ ICB2YXJpYWJsZSAnY29uZmlnJyBzZXQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC1idXQtc2V0LXZh cmlhYmxlXQo+IAo+IFNpZ25lZC1vZmYtYnk6IFl1ZUhhaWJpbmcgPHl1ZWhhaWJpbmdAaHVhd2Vp LmNvbT4KCkFwcGxpZWQsIHRoYW5rcy4KLURhbmllbAo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v ZHJtX3BsYW5lLmMgfCAyIC0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGRlbGV0aW9ucygtKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5lLmMgYi9kcml2ZXJzL2dwdS9k cm0vZHJtX3BsYW5lLmMKPiBpbmRleCAzNmJmM2ZlLi40YTcyYzY4IDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9kcm1fcGxhbmUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fcGxh bmUuYwo+IEBAIC00NzIsNyArNDcyLDYgQEAgaW50IGRybV9tb2RlX2dldHBsYW5lX3JlcyhzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+ICAJCQkgIHN0cnVjdCBkcm1fZmlsZSAq ZmlsZV9wcml2KQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX21vZGVfZ2V0X3BsYW5lX3JlcyAqcGxhbmVf cmVzcCA9IGRhdGE7Cj4gLQlzdHJ1Y3QgZHJtX21vZGVfY29uZmlnICpjb25maWc7Cj4gIAlzdHJ1 Y3QgZHJtX3BsYW5lICpwbGFuZTsKPiAgCXVpbnQzMl90IF9fdXNlciAqcGxhbmVfcHRyOwo+ICAJ aW50IGNvdW50ID0gMDsKPiBAQCAtNDgwLDcgKzQ3OSw2IEBAIGludCBkcm1fbW9kZV9nZXRwbGFu ZV9yZXMoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgCWlmICghZHJtX2Nv cmVfY2hlY2tfZmVhdHVyZShkZXYsIERSSVZFUl9NT0RFU0VUKSkKPiAgCQlyZXR1cm4gLUVJTlZB TDsKPiAgCj4gLQljb25maWcgPSAmZGV2LT5tb2RlX2NvbmZpZzsKPiAgCXBsYW5lX3B0ciA9IHU2 NF90b191c2VyX3B0cihwbGFuZV9yZXNwLT5wbGFuZV9pZF9wdHIpOwo+ICAKPiAgCS8qCj4gCj4g X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2 ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAK RGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDov L2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg==