All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Dou Liyang <douly.fnst@cn.fujitsu.com>,
	Pasha Tatashin <Pavel.Tatashin@microsoft.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] Revert "x86/tsc: Consolidate init code"
Date: Tue, 11 Sep 2018 15:15:48 +0300	[thread overview]
Message-ID: <20180911121548.GW5565@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1809101846160.1419@nanos.tec.linutronix.de>

On Mon, Sep 10, 2018 at 06:53:54PM +0200, Thomas Gleixner wrote:
> On Mon, 10 Sep 2018, Ville Syrjälä wrote:
> 
> Good: 1718674.70 BogoMIPS (lpj=2863311530)
> Bad:   859455.59 BogoMIPS (lpj=1431852151)
> 
> while both kernels agree on the CPU frequency of 996MHz. This pretty much
> smells like the 32bit LPJ conversion bug which got fixed in rc3. Does the
> problem persist with rc3?

Indeed looks to be fixed by commit 17f6bac22493 ("x86/tsc:
Prevent result truncation on 32bit"). I both cherry-picked that
on top of rc2 to make sure it really is that commit, and also
tested plain rc3 to make sure it still works.

And comparing the bogomips between the three relevant commits makes
the bug pretty obvious in hindsight:
Calibrating delay loop (skipped), value calculated using timer frequency.. 1718674.70 BogoMIPS (lpj=2863311530)
Calibrating delay loop (skipped), value calculated using timer frequency.. 859455.59 BogoMIPS (lpj=1431852151)
Calibrating delay loop (skipped), value calculated using timer frequency.. 1994.50 BogoMIPS (lpj=3322410)

I suppose we just got very lucky with older kernels.

-- 
Ville Syrjälä
Intel

  reply	other threads:[~2018-09-11 12:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-10 12:19 [PATCH] Revert "x86/tsc: Consolidate init code" Ville Syrjala
2018-09-10 12:48 ` Thomas Gleixner
2018-09-10 13:19   ` Pasha Tatashin
2018-09-10 14:07   ` Ville Syrjälä
2018-09-10 14:47     ` Borislav Petkov
2018-09-10 15:09       ` Ville Syrjälä
2018-09-10 15:25         ` Borislav Petkov
2018-09-10 15:51           ` Ville Syrjälä
2018-09-10 16:06             ` Borislav Petkov
2018-09-10 16:23     ` Thomas Gleixner
2018-09-10 16:46       ` Ville Syrjälä
2018-09-10 17:02         ` Thomas Gleixner
2018-09-11 12:16           ` Ville Syrjälä
2018-09-10 16:53     ` Thomas Gleixner
2018-09-11 12:15       ` Ville Syrjälä [this message]
2018-09-11 20:56         ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180911121548.GW5565@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=Pavel.Tatashin@microsoft.com \
    --cc=douly.fnst@cn.fujitsu.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.