From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA2A5C6778D for ; Tue, 11 Sep 2018 12:16:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58F612088F for ; Tue, 11 Sep 2018 12:16:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58F612088F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727832AbeIKRPn (ORCPT ); Tue, 11 Sep 2018 13:15:43 -0400 Received: from mga07.intel.com ([134.134.136.100]:8089 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727768AbeIKRPn (ORCPT ); Tue, 11 Sep 2018 13:15:43 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2018 05:16:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,360,1531810800"; d="scan'208";a="90706911" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga002.jf.intel.com with SMTP; 11 Sep 2018 05:16:35 -0700 Received: by stinkbox (sSMTP sendmail emulation); Tue, 11 Sep 2018 15:16:35 +0300 Date: Tue, 11 Sep 2018 15:16:35 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Thomas Gleixner Cc: LKML , Dou Liyang , Pavel Tatashin , "H. Peter Anvin" , Peter Zijlstra Subject: Re: [PATCH] Revert "x86/tsc: Consolidate init code" Message-ID: <20180911121635.GX5565@intel.com> References: <20180910121925.27682-1-ville.syrjala@linux.intel.com> <20180910140710.GR5565@intel.com> <20180910164631.GV5565@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 10, 2018 at 07:02:43PM +0200, Thomas Gleixner wrote: > On Mon, 10 Sep 2018, Ville Syrjälä wrote: > > On Mon, Sep 10, 2018 at 06:23:49PM +0200, Thomas Gleixner wrote: > > > 1) My workflow makes things tagged as BUG and REGRESSION urgent > > > automatically while [PATCH] just is queued to the normal pile of > > > backlog, i.e. at the end. It just sprang into my eyes by chance, but in > > > general you might just get the contrary of what you are looking for. > > > > Ah. Might be nice to document that somewhere. I might have to type up > > that git-regression tool for myself, because I'm lazy. > > Well, it's probably different between maintainers, but it's common practice > to have '[REGRESION] sub/sys got fubarred' in the subject. > > > > 2) A proper bug report with proper information (it's documented what should > > > be provided), is way more worth than a patch with a mostly useless > > > change log, which forces me to ask for the proper information instead of > > > having it right away. > > > > I do agree that not having to ask for more information would be nice, > > but hard to generalize because every subsystem needs different things. > > > > In this case you asked for the dmesg, which isn't even mentioned in > > Documentation/admin-guide/reporting-bugs.rst as far as I can see. > > So I'm not quite sure which documentation you're referring to here. > > I didn't look, but I expected dmesg to be part of it and a lot of people > provide it as well as the start point of their bisection. Again, I had to > do a shot into the dark and ask you whether it's fixed in -rc3. bisect > start would have told me. > > So again. That revert patch habit does not make my life easier at all. OK. I'll keep that in mind and try to stick REGRESSION format in the future. -- Ville Syrjälä Intel