From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Horia=20Geant=C4=83?= Subject: [PATCH v2 05/12] crypto: caam - fix implicit casts in endianness helpers Date: Wed, 12 Sep 2018 11:59:30 +0300 Message-ID: <20180912085937.22489-6-horia.geanta@nxp.com> References: <20180912085937.22489-1-horia.geanta@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: linux-kernel@vger.kernel.org, Aymen Sghaier , "David S . Miller" , linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org To: Herbert Xu , Stuart Yoder , Laurentiu Tudor , Li Yang , Roy Pledge , Catalin Marinas , Will Deacon Return-path: In-Reply-To: <20180912085937.22489-1-horia.geanta@nxp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: linux-crypto.vger.kernel.org Rml4IHRoZSBmb2xsb3dpbmcgc3BhcnNlIGVuZGlhbm5lc3Mgd2FybmluZ3M6Cgpkcml2ZXJzL2Ny eXB0by9jYWFtL3JlZ3MuaDo5NToxOiBzcGFyc2U6IGluY29ycmVjdCB0eXBlIGluIHJldHVybiBl eHByZXNzaW9uIChkaWZmZXJlbnQgYmFzZSB0eXBlcykgQEAgICAgZXhwZWN0ZWQgdW5zaWduZWQg aW50IEBAICAgIGdvdCByZXN0cmljdGVkIF9fbGUzMnVuc2lnbmVkIGludCBAQApkcml2ZXJzL2Ny eXB0by9jYWFtL3JlZ3MuaDo5NToxOiAgICBleHBlY3RlZCB1bnNpZ25lZCBpbnQKZHJpdmVycy9j cnlwdG8vY2FhbS9yZWdzLmg6OTU6MTogICAgZ290IHJlc3RyaWN0ZWQgX19sZTMyIFt1c2VydHlw ZV0gPG5vaWRlbnQ+CmRyaXZlcnMvY3J5cHRvL2NhYW0vcmVncy5oOjk1OjE6IHNwYXJzZTogaW5j b3JyZWN0IHR5cGUgaW4gcmV0dXJuIGV4cHJlc3Npb24gKGRpZmZlcmVudCBiYXNlIHR5cGVzKSBA QCAgICBleHBlY3RlZCB1bnNpZ25lZCBpbnQgQEAgICAgZ290IHJlc3RyaWN0ZWQgX19iZTMydW5z aWduZWQgaW50IEBACmRyaXZlcnMvY3J5cHRvL2NhYW0vcmVncy5oOjk1OjE6ICAgIGV4cGVjdGVk IHVuc2lnbmVkIGludApkcml2ZXJzL2NyeXB0by9jYWFtL3JlZ3MuaDo5NToxOiAgICBnb3QgcmVz dHJpY3RlZCBfX2JlMzIgW3VzZXJ0eXBlXSA8bm9pZGVudD4KCmRyaXZlcnMvY3J5cHRvL2NhYW0v cmVncy5oOjkyOjE6IHNwYXJzZTogY2FzdCB0byByZXN0cmljdGVkIF9fbGUzMgpkcml2ZXJzL2Ny eXB0by9jYWFtL3JlZ3MuaDo5MjoxOiBzcGFyc2U6IGNhc3QgdG8gcmVzdHJpY3RlZCBfX2JlMzIK CkZpeGVzOiAyNjFlYTA1OGYwMTYgKCJjcnlwdG86IGNhYW0gLSBoYW5kbGUgY29yZSBlbmRpYW5u ZXNzICE9IGNhYW0gZW5kaWFubmVzcyIpClJlcG9ydGVkLWJ5OiBrYnVpbGQgdGVzdCByb2JvdCA8 bGtwQGludGVsLmNvbT4KU2lnbmVkLW9mZi1ieTogSG9yaWEgR2VhbnTEgyA8aG9yaWEuZ2VhbnRh QG54cC5jb20+Ci0tLQogZHJpdmVycy9jcnlwdG8vY2FhbS9yZWdzLmggfCAyOCArKysrKysrKysr KysrKy0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMTQg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9jcnlwdG8vY2FhbS9yZWdzLmggYi9k cml2ZXJzL2NyeXB0by9jYWFtL3JlZ3MuaAppbmRleCA0ZmI5MWJhMzljMzYuLmNlM2Y5YWQ3MTIw ZiAxMDA2NDQKLS0tIGEvZHJpdmVycy9jcnlwdG8vY2FhbS9yZWdzLmgKKysrIGIvZHJpdmVycy9j cnlwdG8vY2FhbS9yZWdzLmgKQEAgLTcwLDIyICs3MCwyMiBAQAogZXh0ZXJuIGJvb2wgY2FhbV9s aXR0bGVfZW5kOwogZXh0ZXJuIGJvb2wgY2FhbV9pbXg7CiAKLSNkZWZpbmUgY2FhbV90b19jcHUo bGVuKQkJCQlcCi1zdGF0aWMgaW5saW5lIHUjI2xlbiBjYWFtIyNsZW4gIyMgX3RvX2NwdSh1IyNs ZW4gdmFsKQlcCi17CQkJCQkJCVwKLQlpZiAoY2FhbV9saXR0bGVfZW5kKQkJCQlcCi0JCXJldHVy biBsZSMjbGVuICMjIF90b19jcHUodmFsKTsJCVwKLQllbHNlCQkJCQkJXAotCQlyZXR1cm4gYmUj I2xlbiAjIyBfdG9fY3B1KHZhbCk7CQlcCisjZGVmaW5lIGNhYW1fdG9fY3B1KGxlbikJCQkJCQlc CitzdGF0aWMgaW5saW5lIHUjI2xlbiBjYWFtIyNsZW4gIyMgX3RvX2NwdSh1IyNsZW4gdmFsKQkJ CVwKK3sJCQkJCQkJCQlcCisJaWYgKGNhYW1fbGl0dGxlX2VuZCkJCQkJCQlcCisJCXJldHVybiBs ZSMjbGVuICMjIF90b19jcHUoKF9fZm9yY2UgX19sZSMjbGVuKXZhbCk7CVwKKwllbHNlCQkJCQkJ CQlcCisJCXJldHVybiBiZSMjbGVuICMjIF90b19jcHUoKF9fZm9yY2UgX19iZSMjbGVuKXZhbCk7 CVwKIH0KIAotI2RlZmluZSBjcHVfdG9fY2FhbShsZW4pCQkJCVwKLXN0YXRpYyBpbmxpbmUgdSMj bGVuIGNwdV90b19jYWFtIyNsZW4odSMjbGVuIHZhbCkJXAotewkJCQkJCQlcCi0JaWYgKGNhYW1f bGl0dGxlX2VuZCkJCQkJXAotCQlyZXR1cm4gY3B1X3RvX2xlIyNsZW4odmFsKTsJCVwKLQllbHNl CQkJCQkJXAotCQlyZXR1cm4gY3B1X3RvX2JlIyNsZW4odmFsKTsJCVwKKyNkZWZpbmUgY3B1X3Rv X2NhYW0obGVuKQkJCQkJXAorc3RhdGljIGlubGluZSB1IyNsZW4gY3B1X3RvX2NhYW0jI2xlbih1 IyNsZW4gdmFsKQkJXAorewkJCQkJCQkJXAorCWlmIChjYWFtX2xpdHRsZV9lbmQpCQkJCQlcCisJ CXJldHVybiAoX19mb3JjZSB1IyNsZW4pY3B1X3RvX2xlIyNsZW4odmFsKTsJXAorCWVsc2UJCQkJ CQkJXAorCQlyZXR1cm4gKF9fZm9yY2UgdSMjbGVuKWNwdV90b19iZSMjbGVuKHZhbCk7CVwKIH0K IAogY2FhbV90b19jcHUoMTYpCi0tIAoyLjE2LjIKCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E5B5C4646A for ; Wed, 12 Sep 2018 09:00:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C56BF20882 for ; Wed, 12 Sep 2018 09:00:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C56BF20882 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728087AbeILODe (ORCPT ); Wed, 12 Sep 2018 10:03:34 -0400 Received: from inva020.nxp.com ([92.121.34.13]:60264 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727985AbeILODc (ORCPT ); Wed, 12 Sep 2018 10:03:32 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 9481B1A0254; Wed, 12 Sep 2018 10:59:56 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 884971A0144; Wed, 12 Sep 2018 10:59:56 +0200 (CEST) Received: from enigma.ea.freescale.net (enigma.ea.freescale.net [10.171.81.110]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id 093BC205F0; Wed, 12 Sep 2018 10:59:56 +0200 (CEST) From: =?UTF-8?q?Horia=20Geant=C4=83?= To: Herbert Xu , Stuart Yoder , Laurentiu Tudor , Li Yang , Roy Pledge , Catalin Marinas , Will Deacon Cc: "David S . Miller" , Aymen Sghaier , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 05/12] crypto: caam - fix implicit casts in endianness helpers Date: Wed, 12 Sep 2018 11:59:30 +0300 Message-Id: <20180912085937.22489-6-horia.geanta@nxp.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180912085937.22489-1-horia.geanta@nxp.com> References: <20180912085937.22489-1-horia.geanta@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following sparse endianness warnings: drivers/crypto/caam/regs.h:95:1: sparse: incorrect type in return expression (different base types) @@ expected unsigned int @@ got restricted __le32unsigned int @@ drivers/crypto/caam/regs.h:95:1: expected unsigned int drivers/crypto/caam/regs.h:95:1: got restricted __le32 [usertype] drivers/crypto/caam/regs.h:95:1: sparse: incorrect type in return expression (different base types) @@ expected unsigned int @@ got restricted __be32unsigned int @@ drivers/crypto/caam/regs.h:95:1: expected unsigned int drivers/crypto/caam/regs.h:95:1: got restricted __be32 [usertype] drivers/crypto/caam/regs.h:92:1: sparse: cast to restricted __le32 drivers/crypto/caam/regs.h:92:1: sparse: cast to restricted __be32 Fixes: 261ea058f016 ("crypto: caam - handle core endianness != caam endianness") Reported-by: kbuild test robot Signed-off-by: Horia Geantă --- drivers/crypto/caam/regs.h | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/crypto/caam/regs.h b/drivers/crypto/caam/regs.h index 4fb91ba39c36..ce3f9ad7120f 100644 --- a/drivers/crypto/caam/regs.h +++ b/drivers/crypto/caam/regs.h @@ -70,22 +70,22 @@ extern bool caam_little_end; extern bool caam_imx; -#define caam_to_cpu(len) \ -static inline u##len caam##len ## _to_cpu(u##len val) \ -{ \ - if (caam_little_end) \ - return le##len ## _to_cpu(val); \ - else \ - return be##len ## _to_cpu(val); \ +#define caam_to_cpu(len) \ +static inline u##len caam##len ## _to_cpu(u##len val) \ +{ \ + if (caam_little_end) \ + return le##len ## _to_cpu((__force __le##len)val); \ + else \ + return be##len ## _to_cpu((__force __be##len)val); \ } -#define cpu_to_caam(len) \ -static inline u##len cpu_to_caam##len(u##len val) \ -{ \ - if (caam_little_end) \ - return cpu_to_le##len(val); \ - else \ - return cpu_to_be##len(val); \ +#define cpu_to_caam(len) \ +static inline u##len cpu_to_caam##len(u##len val) \ +{ \ + if (caam_little_end) \ + return (__force u##len)cpu_to_le##len(val); \ + else \ + return (__force u##len)cpu_to_be##len(val); \ } caam_to_cpu(16) -- 2.16.2 From mboxrd@z Thu Jan 1 00:00:00 1970 From: horia.geanta@nxp.com (=?UTF-8?q?Horia=20Geant=C4=83?=) Date: Wed, 12 Sep 2018 11:59:30 +0300 Subject: [PATCH v2 05/12] crypto: caam - fix implicit casts in endianness helpers In-Reply-To: <20180912085937.22489-1-horia.geanta@nxp.com> References: <20180912085937.22489-1-horia.geanta@nxp.com> Message-ID: <20180912085937.22489-6-horia.geanta@nxp.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Fix the following sparse endianness warnings: drivers/crypto/caam/regs.h:95:1: sparse: incorrect type in return expression (different base types) @@ expected unsigned int @@ got restricted __le32unsigned int @@ drivers/crypto/caam/regs.h:95:1: expected unsigned int drivers/crypto/caam/regs.h:95:1: got restricted __le32 [usertype] drivers/crypto/caam/regs.h:95:1: sparse: incorrect type in return expression (different base types) @@ expected unsigned int @@ got restricted __be32unsigned int @@ drivers/crypto/caam/regs.h:95:1: expected unsigned int drivers/crypto/caam/regs.h:95:1: got restricted __be32 [usertype] drivers/crypto/caam/regs.h:92:1: sparse: cast to restricted __le32 drivers/crypto/caam/regs.h:92:1: sparse: cast to restricted __be32 Fixes: 261ea058f016 ("crypto: caam - handle core endianness != caam endianness") Reported-by: kbuild test robot Signed-off-by: Horia Geant? --- drivers/crypto/caam/regs.h | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/crypto/caam/regs.h b/drivers/crypto/caam/regs.h index 4fb91ba39c36..ce3f9ad7120f 100644 --- a/drivers/crypto/caam/regs.h +++ b/drivers/crypto/caam/regs.h @@ -70,22 +70,22 @@ extern bool caam_little_end; extern bool caam_imx; -#define caam_to_cpu(len) \ -static inline u##len caam##len ## _to_cpu(u##len val) \ -{ \ - if (caam_little_end) \ - return le##len ## _to_cpu(val); \ - else \ - return be##len ## _to_cpu(val); \ +#define caam_to_cpu(len) \ +static inline u##len caam##len ## _to_cpu(u##len val) \ +{ \ + if (caam_little_end) \ + return le##len ## _to_cpu((__force __le##len)val); \ + else \ + return be##len ## _to_cpu((__force __be##len)val); \ } -#define cpu_to_caam(len) \ -static inline u##len cpu_to_caam##len(u##len val) \ -{ \ - if (caam_little_end) \ - return cpu_to_le##len(val); \ - else \ - return cpu_to_be##len(val); \ +#define cpu_to_caam(len) \ +static inline u##len cpu_to_caam##len(u##len val) \ +{ \ + if (caam_little_end) \ + return (__force u##len)cpu_to_le##len(val); \ + else \ + return (__force u##len)cpu_to_be##len(val); \ } caam_to_cpu(16) -- 2.16.2