From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sakari Ailus Subject: [PATCH v3 14/23] v4l: fwnode: Parse the graph endpoint as last Date: Thu, 13 Sep 2018 00:29:33 +0300 Message-ID: <20180912212942.19641-15-sakari.ailus@linux.intel.com> References: <20180912212942.19641-1-sakari.ailus@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180912212942.19641-1-sakari.ailus@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: linux-media@vger.kernel.org Cc: devicetree@vger.kernel.org, jacopo@jmondi.org, dri-devel@lists.freedesktop.org, slongerbeam@gmail.com, niklas.soderlund@ragnatech.se List-Id: devicetree@vger.kernel.org UGFyc2luZyB0aGUgZ3JhcGggZW5kcG9pbnQgaXMgYWx3YXlzIHN1Y2Nlc3NmdWw7IHRoZXJlZm9y ZSBwYXJzZSBpdCBhcwpsYXN0LgoKU2lnbmVkLW9mZi1ieTogU2FrYXJpIEFpbHVzIDxzYWthcmku YWlsdXNAbGludXguaW50ZWwuY29tPgpUZXN0ZWQtYnk6IFN0ZXZlIExvbmdlcmJlYW0gPHN0ZXZl X2xvbmdlcmJlYW1AbWVudG9yLmNvbT4KLS0tCiBkcml2ZXJzL21lZGlhL3Y0bDItY29yZS92NGwy LWZ3bm9kZS5jIHwgOCArKysrKysrLQogMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwg MSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvdjRsMi1jb3JlL3Y0bDIt Zndub2RlLmMgYi9kcml2ZXJzL21lZGlhL3Y0bDItY29yZS92NGwyLWZ3bm9kZS5jCmluZGV4IGRi ZTBhZGE3NGM2My4uYmRiMGEzNTViNjZiIDEwMDY0NAotLS0gYS9kcml2ZXJzL21lZGlhL3Y0bDIt Y29yZS92NGwyLWZ3bm9kZS5jCisrKyBiL2RyaXZlcnMvbWVkaWEvdjRsMi1jb3JlL3Y0bDItZndu b2RlLmMKQEAgLTMwOCw3ICszMDgsMTEgQEAgc3RhdGljIGludCBfX3Y0bDJfZndub2RlX2VuZHBv aW50X3BhcnNlKHN0cnVjdCBmd25vZGVfaGFuZGxlICpmd25vZGUsCiAKIAlwcl9kZWJ1ZygiPT09 PT0gYmVnaW4gVjRMMiBlbmRwb2ludCBwcm9wZXJ0aWVzXG4iKTsKIAotCWZ3bm9kZV9ncmFwaF9w YXJzZV9lbmRwb2ludChmd25vZGUsICZ2ZXAtPmJhc2UpOworCS8qCisJICogWmVybyB0aGUgZndu b2RlIGdyYXBoIGVuZHBvaW50IG1lbW9yeSBpbiBjYXNlIHdlIGRvbid0IGVuZCB1cCBwYXJzaW5n CisJICogdGhlIGVuZHBvaW50LgorCSAqLworCW1lbXNldCgmdmVwLT5iYXNlLCAwLCBzaXplb2Yo dmVwLT5iYXNlKSk7CiAKIAkvKiBaZXJvIGZpZWxkcyBmcm9tIGJ1c190eXBlIHRvIHVudGlsIHRo ZSBlbmQgKi8KIAltZW1zZXQoJnZlcC0+YnVzX3R5cGUsIDAsIHNpemVvZigqdmVwKSAtCkBAIC0z NTEsNiArMzU1LDggQEAgc3RhdGljIGludCBfX3Y0bDJfZndub2RlX2VuZHBvaW50X3BhcnNlKHN0 cnVjdCBmd25vZGVfaGFuZGxlICpmd25vZGUsCiAJCXJldHVybiAtRUlOVkFMOwogCX0KIAorCWZ3 bm9kZV9ncmFwaF9wYXJzZV9lbmRwb2ludChmd25vZGUsICZ2ZXAtPmJhc2UpOworCiAJcmV0dXJu IDA7CiB9CiAKLS0gCjIuMTEuMAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:41010 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728257AbeIMCgL (ORCPT ); Wed, 12 Sep 2018 22:36:11 -0400 From: Sakari Ailus To: linux-media@vger.kernel.org Cc: devicetree@vger.kernel.org, slongerbeam@gmail.com, niklas.soderlund@ragnatech.se, jacopo@jmondi.org, p.zabel@pengutronix.de, dri-devel@lists.freedesktop.org Subject: [PATCH v3 14/23] v4l: fwnode: Parse the graph endpoint as last Date: Thu, 13 Sep 2018 00:29:33 +0300 Message-Id: <20180912212942.19641-15-sakari.ailus@linux.intel.com> In-Reply-To: <20180912212942.19641-1-sakari.ailus@linux.intel.com> References: <20180912212942.19641-1-sakari.ailus@linux.intel.com> Sender: linux-media-owner@vger.kernel.org List-ID: Parsing the graph endpoint is always successful; therefore parse it as last. Signed-off-by: Sakari Ailus Tested-by: Steve Longerbeam --- drivers/media/v4l2-core/v4l2-fwnode.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c index dbe0ada74c63..bdb0a355b66b 100644 --- a/drivers/media/v4l2-core/v4l2-fwnode.c +++ b/drivers/media/v4l2-core/v4l2-fwnode.c @@ -308,7 +308,11 @@ static int __v4l2_fwnode_endpoint_parse(struct fwnode_handle *fwnode, pr_debug("===== begin V4L2 endpoint properties\n"); - fwnode_graph_parse_endpoint(fwnode, &vep->base); + /* + * Zero the fwnode graph endpoint memory in case we don't end up parsing + * the endpoint. + */ + memset(&vep->base, 0, sizeof(vep->base)); /* Zero fields from bus_type to until the end */ memset(&vep->bus_type, 0, sizeof(*vep) - @@ -351,6 +355,8 @@ static int __v4l2_fwnode_endpoint_parse(struct fwnode_handle *fwnode, return -EINVAL; } + fwnode_graph_parse_endpoint(fwnode, &vep->base); + return 0; } -- 2.11.0