All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Ryan El Kochta <lightn1ngstr1ke@protonmail.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] input-linux: customizable grab toggle keys v3
Date: Thu, 13 Sep 2018 11:04:29 +0200	[thread overview]
Message-ID: <20180913090429.lphnvev7fleup2lx@sirius.home.kraxel.org> (raw)
In-Reply-To: <45OPfGmaK-Sz9ZGzbGSmlE0AgSRiVp3mCkNrkJC2k6s4c9wOOcegenAJ6muFQwlGl1gBTMordKEgVU2tv9dThhXMDKaJPSZ6tNTMclo_n1E=@protonmail.com>

On Mon, Sep 03, 2018 at 04:32:10PM +0000, Ryan El Kochta wrote:
> This patch adds a new option to the input-linux object:
> 
> grab_toggle=key-key-key

"grab-toggle" (no underscore) please.

I'm still not convinced we need that much flexibility.
I would go for a fixed list of combinations.

Suggestion: add a enum to qapi (see QKeyCode in qapi/ui.json for an
example), that way you'll get a bunch of helper code and lookup tables
generated.  Simplifies the option parsing, you can use
object_property_add_enum() then.

> I have also attached the patch contained in the body of this email
> since my mail client does not seem to behave well with patches.
> If this is a problem, please let me know.

Using 'git send-email' is the best way to send out patch mails.

Must be set up once, but when done it is less work for both sending and
receiving side.

cheers,
  Gerd

      reply	other threads:[~2018-09-13  9:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-03 16:32 [Qemu-devel] [PATCH] input-linux: customizable grab toggle keys v3 Ryan El Kochta
2018-09-13  9:04 ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180913090429.lphnvev7fleup2lx@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=lightn1ngstr1ke@protonmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.