From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:45080 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727726AbeINO7V (ORCPT ); Fri, 14 Sep 2018 10:59:21 -0400 Date: Fri, 14 Sep 2018 11:45:38 +0200 From: Gerd Hoffmann To: Dan Carpenter Cc: Sumit Semwal , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] udmabuf: fix error code in map_udmabuf() Message-ID: <20180914094538.xied3d2zgg5b2atr@sirius.home.kraxel.org> References: <20180914065615.GA12043@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180914065615.GA12043@mwanda> Sender: linux-media-owner@vger.kernel.org List-ID: On Fri, Sep 14, 2018 at 09:56:15AM +0300, Dan Carpenter wrote: > We accidentally forgot to set "ret" on this error path so it means we > return NULL instead of an error pointer. The caller checks for NULL and > changes it to an error pointer so it doesn't cause an issue at run time. Pushed to drm-misc-next. thanks, Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Date: Fri, 14 Sep 2018 09:45:38 +0000 Subject: Re: [PATCH] udmabuf: fix error code in map_udmabuf() Message-Id: <20180914094538.xied3d2zgg5b2atr@sirius.home.kraxel.org> List-Id: References: <20180914065615.GA12043@mwanda> In-Reply-To: <20180914065615.GA12043@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: linaro-mm-sig@lists.linaro.org, kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org On Fri, Sep 14, 2018 at 09:56:15AM +0300, Dan Carpenter wrote: > We accidentally forgot to set "ret" on this error path so it means we > return NULL instead of an error pointer. The caller checks for NULL and > changes it to an error pointer so it doesn't cause an issue at run time. Pushed to drm-misc-next. thanks, Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH] udmabuf: fix error code in map_udmabuf() Date: Fri, 14 Sep 2018 11:45:38 +0200 Message-ID: <20180914094538.xied3d2zgg5b2atr@sirius.home.kraxel.org> References: <20180914065615.GA12043@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id 422E16E7CE for ; Fri, 14 Sep 2018 09:45:40 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180914065615.GA12043@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter Cc: linaro-mm-sig@lists.linaro.org, kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBTZXAgMTQsIDIwMTggYXQgMDk6NTY6MTVBTSArMDMwMCwgRGFuIENhcnBlbnRlciB3 cm90ZToKPiBXZSBhY2NpZGVudGFsbHkgZm9yZ290IHRvIHNldCAicmV0IiBvbiB0aGlzIGVycm9y IHBhdGggc28gaXQgbWVhbnMgd2UKPiByZXR1cm4gTlVMTCBpbnN0ZWFkIG9mIGFuIGVycm9yIHBv aW50ZXIuICBUaGUgY2FsbGVyIGNoZWNrcyBmb3IgTlVMTCBhbmQKPiBjaGFuZ2VzIGl0IHRvIGFu IGVycm9yIHBvaW50ZXIgc28gaXQgZG9lc24ndCBjYXVzZSBhbiBpc3N1ZSBhdCBydW4gdGltZS4K ClB1c2hlZCB0byBkcm0tbWlzYy1uZXh0LgoKdGhhbmtzLAogIEdlcmQKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=