Re: [PATCH V3 17/17] block: enable runtime PM for blk-mq

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3014 bytes --]

Hi Ming,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on v4.19-rc3 next-20180913]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Ming-Lei/blk-mq-allow-to-pass-default-queue-flags-for-creating-initializing-queue/20180914-162946
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: x86_64-randconfig-u0-09150658 (attached as .config)
compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/linux/export.h:45:0,
                    from include/linux/linkage.h:7,
                    from include/linux/kernel.h:7,
                    from block/blk-mq.c:7:
   block/blk-mq.c: In function '__blk_mq_free_request':
   block/blk-mq.c:508:7: error: 'struct request_queue' has no member named 'dev'
     if (q->dev)
          ^
   include/linux/compiler.h:58:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^
>> block/blk-mq.c:508:2: note: in expansion of macro 'if'
     if (q->dev)
     ^
   block/blk-mq.c:508:7: error: 'struct request_queue' has no member named 'dev'
     if (q->dev)
          ^
   include/linux/compiler.h:58:42: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                             ^
>> block/blk-mq.c:508:2: note: in expansion of macro 'if'
     if (q->dev)
     ^
   block/blk-mq.c:508:7: error: 'struct request_queue' has no member named 'dev'
     if (q->dev)
          ^
   include/linux/compiler.h:69:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^
>> block/blk-mq.c:508:2: note: in expansion of macro 'if'
     if (q->dev)
     ^
   block/blk-mq.c:509:30: error: 'struct request_queue' has no member named 'dev'
      pm_runtime_mark_last_busy(q->dev);
                                 ^

vim +/if +508 block/blk-mq.c

   493	
   494	static void __blk_mq_free_request(struct request *rq)
   495	{
   496		struct request_queue *q = rq->q;
   497		struct blk_mq_ctx *ctx = rq->mq_ctx;
   498		struct blk_mq_hw_ctx *hctx = blk_mq_map_queue(q, ctx->cpu);
   499		const int sched_tag = rq->internal_tag;
   500	
   501		if (rq->tag != -1)
   502			blk_mq_put_tag(hctx, hctx->tags, ctx, rq->tag);
   503		if (sched_tag != -1)
   504			blk_mq_put_tag(hctx, hctx->sched_tags, ctx, sched_tag);
   505		blk_mq_sched_restart(hctx);
   506		blk_queue_exit(q);
   507	
 > 508		if (q->dev)
   509			pm_runtime_mark_last_busy(q->dev);
   510	}
   511	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31649 bytes --]