From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 377A3C4161C for ; Sat, 15 Sep 2018 12:58:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E3F7421479 for ; Sat, 15 Sep 2018 12:58:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3F7421479 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727747AbeIOSRM (ORCPT ); Sat, 15 Sep 2018 14:17:12 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:44956 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726969AbeIOSRM (ORCPT ); Sat, 15 Sep 2018 14:17:12 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w8FCrRjO002883 for ; Sat, 15 Sep 2018 08:58:16 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2mgx8bxsg8-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 15 Sep 2018 08:58:16 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 15 Sep 2018 13:58:14 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Sat, 15 Sep 2018 13:58:11 +0100 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w8FCwAGD65994972 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 15 Sep 2018 12:58:10 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 11C7942047; Sat, 15 Sep 2018 15:58:00 +0100 (BST) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1B6D242041; Sat, 15 Sep 2018 15:57:59 +0100 (BST) Received: from rapoport-lnx (unknown [9.148.207.116]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Sat, 15 Sep 2018 15:57:58 +0100 (BST) Date: Sat, 15 Sep 2018 15:58:07 +0300 From: Mike Rapoport To: Paul Burton Cc: Serge Semin , Ralf Baechle , James Hogan , Huacai Chen , Michal Hocko , linux-mips@linux-mips.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mips: switch to NO_BOOTMEM References: <1536571398-29194-1-git-send-email-rppt@linux.vnet.ibm.com> <20180914195300.7wnmsph2qhpixm7s@pburton-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180914195300.7wnmsph2qhpixm7s@pburton-laptop> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 18091512-4275-0000-0000-000002BAB631 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18091512-4276-0000-0000-000037C3F676 Message-Id: <20180915125806.GH15191@rapoport-lnx> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-09-15_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=612 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809150142 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 14, 2018 at 12:53:00PM -0700, Paul Burton wrote: > Hi Mike, > > On Mon, Sep 10, 2018 at 12:23:18PM +0300, Mike Rapoport wrote: > > MIPS already has memblock support and all the memory is already registered > > with it. > > > > This patch replaces bootmem memory reservations with memblock ones and > > removes the bootmem initialization. > > > > Since memblock allocates memory in top-down mode, we ensure that memblock > > limit is max_low_pfn to prevent allocations from the high memory. > > > > To have the exceptions base in the lower 512M of the physical memory, its > > allocation in arch/mips/kernel/traps.c::traps_init() is using bottom-up > > mode. > > > > Signed-off-by: Mike Rapoport > > --- > > v2: > > * set memblock limit to max_low_pfn to avoid allocation attempts from high > > memory > > * use boottom-up mode for allocation of the exceptions base > > > > Build tested with *_defconfig. > > Boot tested with qemu-system-mips64el for 32r6el, 64r6el and fuloong2e > > defconfigs. > > Boot tested with qemu-system-mipsel for malta defconfig. > > > > arch/mips/Kconfig | 1 + > > arch/mips/kernel/setup.c | 99 ++++++++-------------------------- > > arch/mips/kernel/traps.c | 3 ++ > > arch/mips/loongson64/loongson-3/numa.c | 34 ++++++------ > > arch/mips/sgi-ip27/ip27-memory.c | 11 ++-- > > 5 files changed, 46 insertions(+), 102 deletions(-) > > Thanks - applied to mips-next for 4.20. > > Apologies for the delay, my son decided to be born a few weeks early & > scupper my plans :) Congratulations! :) > Paul > -- Sincerely yours, Mike.