From: Liviu Dudau <Liviu.Dudau@foss.arm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] misc: Add support for the Arm Versatile Express config bus
Date: Tue, 18 Sep 2018 09:09:33 +0100 [thread overview]
Message-ID: <20180918080932.GB8027@e110455-lin.cambridge.arm.com> (raw)
In-Reply-To: <96170377-b2fc-f3ec-cd4b-24adc3e3126c@denx.de>
On Tue, Sep 18, 2018 at 06:18:48AM +0200, Heiko Schocher wrote:
> Hello Liviu,
>
> Am 17.09.2018 um 18:48 schrieb Liviu Dudau:
> > Add support for the Arm Versatile Express config bus that is
> > being used for exposing various subsystems via a generic
> > configuration bus. This driver adds support for generating
> > transactions on this configuration bus and can be used by
> > other drivers to abstract the communication with the actual
> > function providers.
> >
> > Signed-off-by: Liviu Dudau <liviu.dudau@foss.arm.com>
> > ---
> > drivers/misc/Kconfig | 8 +++
> > drivers/misc/Makefile | 1 +
> > drivers/misc/vexpress_config.c | 127 +++++++++++++++++++++++++++++++++
> > 3 files changed, 136 insertions(+)
> > create mode 100644 drivers/misc/vexpress_config.c
> >
>
> Beside of a nitpick
>
> Reviewed-by: Heiko Schocher <hs@denx.de>
>
> [...]
> > diff --git a/drivers/misc/vexpress_config.c b/drivers/misc/vexpress_config.c
> > new file mode 100644
> > index 0000000000..2cd433d01e
> > --- /dev/null
> > +++ b/drivers/misc/vexpress_config.c
> > @@ -0,1 +1,127 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright (C) 2018 Arm Ltd
> > + * Author: Liviu Dudau <liviu.dudau@foss.arm.com>
> > + *
> > + */
> > +#define DEBUG
>
> Really enable debug?
Sorry, left over from development, I will remove it and re-submit.
Best regards,
Liviu
>
> bye,
> Heiko
> --
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs at denx.de
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
next prev parent reply other threads:[~2018-09-18 8:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 16:48 [U-Boot] [PATCH] misc: Add support for the Arm Versatile Express config bus Liviu Dudau
2018-09-18 4:18 ` Heiko Schocher
2018-09-18 8:09 ` Liviu Dudau [this message]
2018-09-24 15:12 ` [U-Boot] [PATCH v2] " Liviu Dudau
2018-09-28 12:43 ` [U-Boot] [PATCH v3] " Liviu Dudau
2018-10-07 0:28 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180918080932.GB8027@e110455-lin.cambridge.arm.com \
--to=liviu.dudau@foss.arm.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.