From: Steven Rostedt <rostedt@goodmis.org>
To: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Cc: ksummit <ksummit-discuss@lists.linuxfoundation.org>
Subject: Re: [Ksummit-discuss] [MAINTAINER SUMMIT] EXPORT_SYMBOL_GPL
Date: Tue, 18 Sep 2018 09:35:58 -0400 [thread overview]
Message-ID: <20180918093558.7ad355dc@gandalf.local.home> (raw)
In-Reply-To: <20180917072250.5bbcb736@coco.lan>
On Mon, 17 Sep 2018 07:22:50 -0300
Mauro Carvalho Chehab <mchehab+samsung@kernel.org> wrote:
> A common practice there is that, when someone rewrites the implementation
> of some symbol using EXPORT_SYMBOL() is to use EXPORT_SYMBOL_GPL() at
> the new implementation, to make clear about our desire that media modules
> should be GPL'd, but when we do simpler changes (even adding/removing
> parameters at the interface), we tend not to change it[1].
To add to this bike-shed discussion, my view is that if the function is
unique to Linux, it should be EXPORT_SYMBOL_GPL(), and if it is a
common functionality among all operating systems (like request_irq())
then I would consider it EXPORT_SYMBOL().
The tracing infrastructure that we have is unique to Linux and thus
all functions are EXPORT_SYMBOL_GPL(). Proprietary modules can't even
add trace events without breaking that. Although they could use kprobes
and function based events (when we finish that).
-- Steve
prev parent reply other threads:[~2018-09-18 13:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 19:43 [Ksummit-discuss] [MAINTAINER SUMMIT] EXPORT_SYMBOL_GPL Dan Williams
2018-09-13 20:05 ` Guenter Roeck
2018-09-13 20:14 ` Greg KH
2018-09-13 21:04 ` Laurent Pinchart
2018-09-14 6:32 ` Dave Airlie
2018-09-14 7:08 ` Laurent Pinchart
2018-09-16 12:58 ` Wolfram Sang
2018-09-16 22:15 ` Theodore Y. Ts'o
2018-09-17 10:22 ` Mauro Carvalho Chehab
2018-09-18 13:35 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180918093558.7ad355dc@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=ksummit-discuss@lists.linuxfoundation.org \
--cc=mchehab+samsung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.