From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH 5/6] arm64/io: Add header for instrumentation of io operations Date: Tue, 18 Sep 2018 12:47:27 +0100 Message-ID: <20180918114727.GE16498@arm.com> References: <20180917193940.3d68ef88@gandalf.local.home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Sai Prakash Ranjan Cc: Steven Rostedt , Ingo Molnar , Laura Abbott , Kees Cook , Anton Vorontsov , Rob Herring , devicetree@vger.kernel.org, Colin Cross , Jason Baron , Tony Luck , Arnd Bergmann , Catalin Marinas , Joel Fernandes , Masami Hiramatsu , Joe Perches , Jim Cromie , Rajendra Nayak , Vivek Gautam , Sibi Sankar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.orglinux List-Id: linux-arm-msm@vger.kernel.org On Tue, Sep 18, 2018 at 12:40:57PM +0530, Sai Prakash Ranjan wrote: > On 9/18/2018 5:09 AM, Steven Rostedt wrote: > >On Sun, 9 Sep 2018 01:57:06 +0530 > >Sai Prakash Ranjan wrote: > > > >>The new asm-generic/io-instrumented.h will keep arch code > >>clean and separate from instrumented version which traces > >>io register accesses. This instrumented header can later > >>be included in arm as well for tracing io register accesses. > >> > > > >Looks good to me. > > > >Acked-by: Steven Rostedt (VMware) > > > >-- Steve > > Thanks for the ack Steve. > > @Will/Mark/Robin Let me know if you have any review comments, thanks. As I said before, the arm64 bits looks fine to me. I just don't really want to Ack the thing because the patch also contains the asm-generic changes. Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF690C433F4 for ; Tue, 18 Sep 2018 11:47:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8246A206B8 for ; Tue, 18 Sep 2018 11:47:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8246A206B8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729594AbeIRRTW (ORCPT ); Tue, 18 Sep 2018 13:19:22 -0400 Received: from foss.arm.com ([217.140.101.70]:43490 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726768AbeIRRTW (ORCPT ); Tue, 18 Sep 2018 13:19:22 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5A0C71596; Tue, 18 Sep 2018 04:47:09 -0700 (PDT) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 2A0253F557; Tue, 18 Sep 2018 04:47:09 -0700 (PDT) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id 0861A1AE1181; Tue, 18 Sep 2018 12:47:28 +0100 (BST) Date: Tue, 18 Sep 2018 12:47:27 +0100 From: Will Deacon To: Sai Prakash Ranjan Cc: Steven Rostedt , Ingo Molnar , Laura Abbott , Kees Cook , Anton Vorontsov , Rob Herring , devicetree@vger.kernel.org, Colin Cross , Jason Baron , Tony Luck , Arnd Bergmann , Catalin Marinas , Joel Fernandes , Masami Hiramatsu , Joe Perches , Jim Cromie , Rajendra Nayak , Vivek Gautam , Sibi Sankar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Greg Kroah-Hartman , Ingo Molnar , Tom Zanussi , Prasad Sodagudi , tsoni@codeaurora.org, Bryan Huntsman , Tingwei Zhang , mark.rutland@arm.com, robin.murphy@arm.com Subject: Re: [PATCH 5/6] arm64/io: Add header for instrumentation of io operations Message-ID: <20180918114727.GE16498@arm.com> References: <20180917193940.3d68ef88@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 18, 2018 at 12:40:57PM +0530, Sai Prakash Ranjan wrote: > On 9/18/2018 5:09 AM, Steven Rostedt wrote: > >On Sun, 9 Sep 2018 01:57:06 +0530 > >Sai Prakash Ranjan wrote: > > > >>The new asm-generic/io-instrumented.h will keep arch code > >>clean and separate from instrumented version which traces > >>io register accesses. This instrumented header can later > >>be included in arm as well for tracing io register accesses. > >> > > > >Looks good to me. > > > >Acked-by: Steven Rostedt (VMware) > > > >-- Steve > > Thanks for the ack Steve. > > @Will/Mark/Robin Let me know if you have any review comments, thanks. As I said before, the arm64 bits looks fine to me. I just don't really want to Ack the thing because the patch also contains the asm-generic changes. Will From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Tue, 18 Sep 2018 12:47:27 +0100 Subject: [PATCH 5/6] arm64/io: Add header for instrumentation of io operations In-Reply-To: References: <20180917193940.3d68ef88@gandalf.local.home> Message-ID: <20180918114727.GE16498@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Sep 18, 2018 at 12:40:57PM +0530, Sai Prakash Ranjan wrote: > On 9/18/2018 5:09 AM, Steven Rostedt wrote: > >On Sun, 9 Sep 2018 01:57:06 +0530 > >Sai Prakash Ranjan wrote: > > > >>The new asm-generic/io-instrumented.h will keep arch code > >>clean and separate from instrumented version which traces > >>io register accesses. This instrumented header can later > >>be included in arm as well for tracing io register accesses. > >> > > > >Looks good to me. > > > >Acked-by: Steven Rostedt (VMware) > > > >-- Steve > > Thanks for the ack Steve. > > @Will/Mark/Robin Let me know if you have any review comments, thanks. As I said before, the arm64 bits looks fine to me. I just don't really want to Ack the thing because the patch also contains the asm-generic changes. Will