From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] statx: fix compile errors with glibc<2.28
Date: Wed, 19 Sep 2018 09:48:21 +0200 [thread overview]
Message-ID: <20180919074821.GB28540@rei> (raw)
In-Reply-To: <20180919044813.22875-1-liwang@redhat.com>
Hi!
> glibc 2.28 has shipped with a wrapper for the statx() system call.
> Currently the build is broken against it, because sys/stat.h suddenly
> declares all the same types that lapi/stat.h does. Fix it by taking
> the sys/stat.h ones if glibc>=2.28.
>
> include/lapi/stat.h:26:8: error: redefinition of ???struct statx_timestamp???
> include/lapi/stat.h:73:8: error: redefinition of ???struct statx???
What's wrong with the configure checks we do have?
See m4/ltp-statx.m4:
AC_CHECK_TYPES([struct statx],,,[[#include <sys/stat.h>]])
AC_CHECK_TYPES([struct statx_timestamp],,,[[#include <sys/stat.h>]])
That should check exactly if these structures are defined and export the
HAVE_STRUCT_* macros?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2018-09-19 7:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 4:48 [LTP] [PATCH] statx: fix compile errors with glibc<2.28 Li Wang
2018-09-19 7:48 ` Cyril Hrubis [this message]
2018-09-19 9:44 ` Li Wang
2018-09-19 11:40 ` Cyril Hrubis
2018-09-26 14:15 ` [LTP] [PATCH v2] statx: fix compile errors Thadeu Lima de Souza Cascardo
2018-09-26 14:48 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180919074821.GB28540@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.