From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from kirsty.vergenet.net ([202.4.237.240]:43802 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728008AbeISPSN (ORCPT ); Wed, 19 Sep 2018 11:18:13 -0400 Date: Wed, 19 Sep 2018 11:41:04 +0200 From: Simon Horman To: Marek Vasut Cc: Geert Uytterhoeven , Linux ARM , Linux-Renesas , Marek Vasut , Geert Uytterhoeven , Kuninori Morimoto , Wolfram Sang Subject: Re: [PATCH V6] ARM: shmobile: Rework the PMIC IRQ line quirk Message-ID: <20180919094100.gtlxbthzgamixequ@verge.net.au> References: <20180918122340.5478-1-marek.vasut+renesas@gmail.com> <20180919091330.yxnehm2fy5llb2bb@verge.net.au> <7d214a60-e703-c53d-5c98-5da29c34650f@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7d214a60-e703-c53d-5c98-5da29c34650f@gmail.com> Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Wed, Sep 19, 2018 at 11:21:42AM +0200, Marek Vasut wrote: > On 09/19/2018 11:13 AM, Simon Horman wrote: > > On Tue, Sep 18, 2018 at 02:52:53PM +0200, Geert Uytterhoeven wrote: > >> On Tue, Sep 18, 2018 at 2:23 PM Marek Vasut wrote: > >>> Rather than hard-coding the quirk topology, which stopped scaling, > >>> parse the information from DT. The code looks for all compatible > >>> PMICs -- da9063 and da9210 -- and checks if their IRQ line is tied > >>> to the same pin. If so, the code sends a matching sequence to the > >>> PMIC to deassert the IRQ. > >>> > >>> Signed-off-by: Marek Vasut > >>> Cc: Geert Uytterhoeven > >>> Cc: Kuninori Morimoto > >>> Cc: Simon Horman > >>> Cc: Wolfram Sang > >>> Cc: linux-renesas-soc@vger.kernel.org > >>> Acked-by: Wolfram Sang > >>> Tested-by: Geert Uytterhoeven (on Koelsch) > >>> --- > >>> V2: - Replace the DT shared IRQ check loop with memcmp() > >>> - Send the I2C message to deassert the IRQ line to all PMICs > >>> in the list with shared IRQ line instead of just one > >>> - Add comment that this works only in case all the PMICs are > >>> on the same I2C bus > >>> V3: - Drop the addr = 0x00 init > >>> - Drop reinit of argsa in rcar_gen2_regulator_quirk > >>> V4: - Squash regulator_quirk on single line > >>> - Drop !np check in for_each_matching_node_and_match() > >>> - Use argsa in of_irq_parse_one > >>> V5: - Check kzalloc failure > >>> - Rename da...._msgs to da...._msg > >>> - Don't reinit quirk->shared > >>> V6: - Skip invalid entries instead of aborting on them > >> > >> Reviewed-by: Geert Uytterhoeven > > > > Thanks, applied for v4.20. > > > > Marek, these days checkpatch complains if the author of the patch does not > > have a signed offline, and the inconsistency between your > > from and Sign-off the email address trips that check. > > > > Could you consider either a) enhancing checkpatch or b) using > > the same address twice? No need to take any action for this patch. > > Sure, do you know if there's some tweak to git config , so git > send-email uses the m.v+foo@ From address ? Some sort of local config change sounds good to me. As per the follow-up from Geert, it may require some experimentation. From mboxrd@z Thu Jan 1 00:00:00 1970 From: horms@verge.net.au (Simon Horman) Date: Wed, 19 Sep 2018 11:41:04 +0200 Subject: [PATCH V6] ARM: shmobile: Rework the PMIC IRQ line quirk In-Reply-To: <7d214a60-e703-c53d-5c98-5da29c34650f@gmail.com> References: <20180918122340.5478-1-marek.vasut+renesas@gmail.com> <20180919091330.yxnehm2fy5llb2bb@verge.net.au> <7d214a60-e703-c53d-5c98-5da29c34650f@gmail.com> Message-ID: <20180919094100.gtlxbthzgamixequ@verge.net.au> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Sep 19, 2018 at 11:21:42AM +0200, Marek Vasut wrote: > On 09/19/2018 11:13 AM, Simon Horman wrote: > > On Tue, Sep 18, 2018 at 02:52:53PM +0200, Geert Uytterhoeven wrote: > >> On Tue, Sep 18, 2018 at 2:23 PM Marek Vasut wrote: > >>> Rather than hard-coding the quirk topology, which stopped scaling, > >>> parse the information from DT. The code looks for all compatible > >>> PMICs -- da9063 and da9210 -- and checks if their IRQ line is tied > >>> to the same pin. If so, the code sends a matching sequence to the > >>> PMIC to deassert the IRQ. > >>> > >>> Signed-off-by: Marek Vasut > >>> Cc: Geert Uytterhoeven > >>> Cc: Kuninori Morimoto > >>> Cc: Simon Horman > >>> Cc: Wolfram Sang > >>> Cc: linux-renesas-soc at vger.kernel.org > >>> Acked-by: Wolfram Sang > >>> Tested-by: Geert Uytterhoeven (on Koelsch) > >>> --- > >>> V2: - Replace the DT shared IRQ check loop with memcmp() > >>> - Send the I2C message to deassert the IRQ line to all PMICs > >>> in the list with shared IRQ line instead of just one > >>> - Add comment that this works only in case all the PMICs are > >>> on the same I2C bus > >>> V3: - Drop the addr = 0x00 init > >>> - Drop reinit of argsa in rcar_gen2_regulator_quirk > >>> V4: - Squash regulator_quirk on single line > >>> - Drop !np check in for_each_matching_node_and_match() > >>> - Use argsa in of_irq_parse_one > >>> V5: - Check kzalloc failure > >>> - Rename da...._msgs to da...._msg > >>> - Don't reinit quirk->shared > >>> V6: - Skip invalid entries instead of aborting on them > >> > >> Reviewed-by: Geert Uytterhoeven > > > > Thanks, applied for v4.20. > > > > Marek, these days checkpatch complains if the author of the patch does not > > have a signed offline, and the inconsistency between your > > from and Sign-off the email address trips that check. > > > > Could you consider either a) enhancing checkpatch or b) using > > the same address twice? No need to take any action for this patch. > > Sure, do you know if there's some tweak to git config , so git > send-email uses the m.v+foo@ From address ? Some sort of local config change sounds good to me. As per the follow-up from Geert, it may require some experimentation.