From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12547C433F4 for ; Wed, 19 Sep 2018 14:09:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4CEC2151C for ; Wed, 19 Sep 2018 14:09:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4CEC2151C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731969AbeISTrN (ORCPT ); Wed, 19 Sep 2018 15:47:13 -0400 Received: from mga09.intel.com ([134.134.136.24]:61655 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727675AbeISTrM (ORCPT ); Wed, 19 Sep 2018 15:47:12 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Sep 2018 07:09:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,394,1531810800"; d="scan'208";a="258579220" Received: from pqueiros-mobl.ger.corp.intel.com (HELO localhost) ([10.249.37.13]) by orsmga005.jf.intel.com with ESMTP; 19 Sep 2018 07:09:03 -0700 Date: Wed, 19 Sep 2018 17:09:02 +0300 From: Jarkko Sakkinen To: Tomas Winkler Cc: Jason Gunthorpe , Alexander Usyskin , Tadeusz Struk , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 07/20] tpm: move tpm_getcap to tpm1-cmd.c Message-ID: <20180919140902.GB27854@linux.intel.com> References: <20180918093459.19165-1-tomas.winkler@intel.com> <20180918093459.19165-8-tomas.winkler@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180918093459.19165-8-tomas.winkler@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 18, 2018 at 12:34:46PM +0300, Tomas Winkler wrote: > 1. Move tpm_getcap to tpm1-cmd. Rename the function to tpm1_getcap. > 2. Remove unused tpm_getcap_header with unused constant > as this functionality is already implemented using tpm_buf construct. > > Fixes warning: > drivers/char/tpm/tpm-interface.c:452:38: warning: ‘tpm_getcap_header’ defined but not used [-Wunused-const-variable=] > static const struct tpm_input_header tpm_getcap_header = { > ^~~~~~~~~~~~~~~~~ > 3. Drop unused TPM_DIGEST_SIZE. It's already defined in > include/linux/tpm.h Reviewed-by: Jarkko Sakkinen Tested-by: Jarkko Sakkinen /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen) Date: Wed, 19 Sep 2018 17:09:02 +0300 Subject: [PATCH v3 07/20] tpm: move tpm_getcap to tpm1-cmd.c In-Reply-To: <20180918093459.19165-8-tomas.winkler@intel.com> References: <20180918093459.19165-1-tomas.winkler@intel.com> <20180918093459.19165-8-tomas.winkler@intel.com> Message-ID: <20180919140902.GB27854@linux.intel.com> To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Tue, Sep 18, 2018 at 12:34:46PM +0300, Tomas Winkler wrote: > 1. Move tpm_getcap to tpm1-cmd. Rename the function to tpm1_getcap. > 2. Remove unused tpm_getcap_header with unused constant > as this functionality is already implemented using tpm_buf construct. > > Fixes warning: > drivers/char/tpm/tpm-interface.c:452:38: warning: ?tpm_getcap_header? defined but not used [-Wunused-const-variable=] > static const struct tpm_input_header tpm_getcap_header = { > ^~~~~~~~~~~~~~~~~ > 3. Drop unused TPM_DIGEST_SIZE. It's already defined in > include/linux/tpm.h Reviewed-by: Jarkko Sakkinen Tested-by: Jarkko Sakkinen /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com ([134.134.136.24]:61655 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727675AbeISTrM (ORCPT ); Wed, 19 Sep 2018 15:47:12 -0400 Date: Wed, 19 Sep 2018 17:09:02 +0300 From: Jarkko Sakkinen To: Tomas Winkler Cc: Jason Gunthorpe , Alexander Usyskin , Tadeusz Struk , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 07/20] tpm: move tpm_getcap to tpm1-cmd.c Message-ID: <20180919140902.GB27854@linux.intel.com> References: <20180918093459.19165-1-tomas.winkler@intel.com> <20180918093459.19165-8-tomas.winkler@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <20180918093459.19165-8-tomas.winkler@intel.com> Sender: linux-integrity-owner@vger.kernel.org List-ID: On Tue, Sep 18, 2018 at 12:34:46PM +0300, Tomas Winkler wrote: > 1. Move tpm_getcap to tpm1-cmd. Rename the function to tpm1_getcap. > 2. Remove unused tpm_getcap_header with unused constant > as this functionality is already implemented using tpm_buf construct. > > Fixes warning: > drivers/char/tpm/tpm-interface.c:452:38: warning: 'tpm_getcap_header' defined but not used [-Wunused-const-variable=] > static const struct tpm_input_header tpm_getcap_header = { > ^~~~~~~~~~~~~~~~~ > 3. Drop unused TPM_DIGEST_SIZE. It's already defined in > include/linux/tpm.h Reviewed-by: Jarkko Sakkinen Tested-by: Jarkko Sakkinen /Jarkko