From mboxrd@z Thu Jan 1 00:00:00 1970 From: Didier Pallard Subject: [PATCH 1/4] net/e1000: fix missing Tx multi segs capability Date: Wed, 19 Sep 2018 17:04:06 +0200 Message-ID: <20180919150409.22880-2-didier.pallard@6wind.com> References: <20180919150409.22880-1-didier.pallard@6wind.com> Cc: stable@dpdk.org To: dev@dpdk.org Return-path: Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 9E4A54CA6 for ; Wed, 19 Sep 2018 17:04:51 +0200 (CEST) Received: by mail-wm1-f67.google.com with SMTP id q8-v6so7391252wmq.4 for ; Wed, 19 Sep 2018 08:04:51 -0700 (PDT) In-Reply-To: <20180919150409.22880-1-didier.pallard@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating that application will never send multisegmented packets, allowing pmd to choose different tx methods accordingly. In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability that is advertised by pmds, some of them do not advertise it and expect to never receive fragmented packets (octeontx, axgbe) So an ethdev that supports multisegmented packets should properly advertise it. Fixes: e5c05e6590ea ("net/e1000: convert to new Tx offloads API") Cc: stable@dpdk.org Signed-off-by: Didier Pallard --- drivers/net/e1000/em_rxtx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/em_rxtx.c b/drivers/net/e1000/em_rxtx.c index 1103a1839058..087e68304cc8 100644 --- a/drivers/net/e1000/em_rxtx.c +++ b/drivers/net/e1000/em_rxtx.c @@ -1160,6 +1160,7 @@ em_get_tx_port_offloads_capa(struct rte_eth_dev *dev) RTE_SET_USED(dev); tx_offload_capa = + DEV_TX_OFFLOAD_MULTI_SEGS | DEV_TX_OFFLOAD_VLAN_INSERT | DEV_TX_OFFLOAD_IPV4_CKSUM | DEV_TX_OFFLOAD_UDP_CKSUM | -- 2.11.0