From mboxrd@z Thu Jan 1 00:00:00 1970 From: Didier Pallard Subject: [PATCH 2/4] net/fm10k: fix missing Tx multi segs capability Date: Wed, 19 Sep 2018 17:04:07 +0200 Message-ID: <20180919150409.22880-3-didier.pallard@6wind.com> References: <20180919150409.22880-1-didier.pallard@6wind.com> Cc: stable@dpdk.org To: dev@dpdk.org Return-path: Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 5FB234F90 for ; Wed, 19 Sep 2018 17:04:53 +0200 (CEST) Received: by mail-wm1-f67.google.com with SMTP id s12-v6so6669649wmc.0 for ; Wed, 19 Sep 2018 08:04:53 -0700 (PDT) In-Reply-To: <20180919150409.22880-1-didier.pallard@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating that application will never send multisegmented packets, allowing pmd to choose different tx methods accordingly. In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability that is advertised by pmds, some of them do not advertise it and expect to never receive fragmented packets (octeontx, axgbe) So an ethdev that supports multisegmented packets should properly advertise it. Problem was spotted and tested on e1000, should be also present in fm10k. Fixes: 30f3ce999e6a ("net/fm10k: convert to new Tx offloads API") Cc: stable@dpdk.org Signed-off-by: Didier Pallard --- drivers/net/fm10k/fm10k_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index 3359df3c8b9c..7cf5b0314c75 100644 --- a/drivers/net/fm10k/fm10k_ethdev.c +++ b/drivers/net/fm10k/fm10k_ethdev.c @@ -1975,6 +1975,7 @@ static uint64_t fm10k_get_tx_port_offloads_capa(struct rte_eth_dev *dev) RTE_SET_USED(dev); return (uint64_t)(DEV_TX_OFFLOAD_VLAN_INSERT | + DEV_TX_OFFLOAD_MULTI_SEGS | DEV_TX_OFFLOAD_IPV4_CKSUM | DEV_TX_OFFLOAD_UDP_CKSUM | DEV_TX_OFFLOAD_TCP_CKSUM | -- 2.11.0