From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ye Xiaolong <xiaolong.ye@intel.com>
Subject: Re: [PATCH v2 1/2] vhost: introduce API to get vDPA
	device number
Date: Thu, 20 Sep 2018 06:17:25 +0800
Message-ID: <20180919221725.GB42303@intel.com>
References: <20180913180658.20562-1-xiaolong.ye@intel.com>
 <B7F2E978279D1D49A3034B7786DACF406F9AA9ED@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 "Bie, Tiwei" <tiwei.bie@intel.com>,
 "Wang, Zhihong" <zhihong.wang@intel.com>,
 Rami Rosen <roszenrami@gmail.com>, "Wang, Haiyue" <haiyue.wang@intel.com>
To: "Wang, Xiao W" <xiao.w.wang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 4FB041B53
 for <dev@dpdk.org>; Wed, 19 Sep 2018 17:29:31 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <B7F2E978279D1D49A3034B7786DACF406F9AA9ED@SHSMSX101.ccr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 09/19, Wang, Xiao W wrote:
>Hi,
>
>> -----Original Message-----
>> From: Ye, Xiaolong
>> Sent: Friday, September 14, 2018 2:07 AM
>> To: dev@dpdk.org; Maxime Coquelin <maxime.coquelin@redhat.com>; Bie,
>> Tiwei <tiwei.bie@intel.com>; Wang, Zhihong <zhihong.wang@intel.com>
>> Cc: Wang, Xiao W <xiao.w.wang@intel.com>; Rami Rosen
>> <roszenrami@gmail.com>; Wang, Haiyue <haiyue.wang@intel.com>; Ye,
>> Xiaolong <xiaolong.ye@intel.com>
>> Subject: [PATCH v2 1/2] vhost: introduce API to get vDPA device number
>> 
>> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
>> ---
>>  lib/librte_vhost/rte_vdpa.h | 3 +++
>>  lib/librte_vhost/vdpa.c     | 6 ++++++
>>  2 files changed, 9 insertions(+)
>> 
>> diff --git a/lib/librte_vhost/rte_vdpa.h b/lib/librte_vhost/rte_vdpa.h
>> index 90465ca26..b8223e337 100644
>> --- a/lib/librte_vhost/rte_vdpa.h
>> +++ b/lib/librte_vhost/rte_vdpa.h
>> @@ -84,4 +84,7 @@ rte_vdpa_find_device_id(struct rte_vdpa_dev_addr
>> *addr);
>>  struct rte_vdpa_device * __rte_experimental
>>  rte_vdpa_get_device(int did);
>
>add it also to *version.map, so that we can link it as shared lib.

Got it.

>
>> 
>> +/* Get current available vdpa device number */
>> +int __rte_experimental
>> +rte_vdpa_get_device_num(void);
>>  #endif /* _RTE_VDPA_H_ */
>> diff --git a/lib/librte_vhost/vdpa.c b/lib/librte_vhost/vdpa.c
>> index c82fd4370..c2c5dff1d 100644
>> --- a/lib/librte_vhost/vdpa.c
>> +++ b/lib/librte_vhost/vdpa.c
>> @@ -113,3 +113,9 @@ rte_vdpa_get_device(int did)
>> 
>>  	return vdpa_devices[did];
>>  }
>> +
>> +int
>> +rte_vdpa_get_device_num(void)
>> +{
>> +	return vdpa_device_num;
>> +}
>> --
>> 2.17.1
>
>It's better to have a cover letter for a patch set.

Got it, will sent out a cover letter in next iteration.

Thanks,
Xiaolong
>
>BRs,
>Xiao
>