From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF808ECE561 for ; Thu, 20 Sep 2018 06:58:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E09B208A3 for ; Thu, 20 Sep 2018 06:58:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E09B208A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730654AbeITMkA (ORCPT ); Thu, 20 Sep 2018 08:40:00 -0400 Received: from verein.lst.de ([213.95.11.211]:57974 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726028AbeITMkA (ORCPT ); Thu, 20 Sep 2018 08:40:00 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 9408668D79; Thu, 20 Sep 2018 08:58:04 +0200 (CEST) Date: Thu, 20 Sep 2018 08:58:04 +0200 From: Christoph Hellwig To: Ming Lei Cc: Adrian Hunter , "Martin K . Petersen" , "James E . J . Bottomley" , Jens Axboe , Christoph Hellwig , Johannes Thumshirn , Bart Van Assche , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Stanislav Nijnikov , Evan Green , Vinayak Holikatti , Janek Kotas , Vivek Gautam , Asutosh Das , Subhash Jadavani , Sayali Lokhande , Li Wei , Bjorn Andersson , Jaegeuk Kim , Alim Akhtar , Alex Lemberg Subject: Re: [PATCH RFC] scsi: ufs: Disable blk-mq for now Message-ID: <20180920065804.GC13761@lst.de> References: <20180913112848.7807-1-adrian.hunter@intel.com> <20180913120459.GA4965@ming.t460p> <20180914015237.GC11059@ming.t460p> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180914015237.GC11059@ming.t460p> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 14, 2018 at 09:52:38AM +0800, Ming Lei wrote: > However, in previous discussion, it is strongly objected to use > per-driver/device .use_blk_mq switch, so not sure if this way can > be accepted. I don't like the per-driver switch as module_parameter at all and we should never do that. We had some exceptions for drivers to force blk_mq (e.g. virtio), and given that I don't think we'll solve the blk-mq runtime-pm issue for 4.19 and also don't want to revert the default I think this patch is the best compromise for 4.19, with a revert in 4.20 once we have runtime-pm for blk-mq. So: Acked-by: Christoph Hellwig From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH RFC] scsi: ufs: Disable blk-mq for now Date: Thu, 20 Sep 2018 08:58:04 +0200 Message-ID: <20180920065804.GC13761@lst.de> References: <20180913112848.7807-1-adrian.hunter@intel.com> <20180913120459.GA4965@ming.t460p> <20180914015237.GC11059@ming.t460p> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180914015237.GC11059@ming.t460p> Sender: linux-kernel-owner@vger.kernel.org To: Ming Lei Cc: Adrian Hunter , "Martin K . Petersen" , "James E . J . Bottomley" , Jens Axboe , Christoph Hellwig , Johannes Thumshirn , Bart Van Assche , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Stanislav Nijnikov , Evan Green , Vinayak Holikatti , Janek Kotas , Vivek Gautam , Asutosh Das , Subhash Jadavani , Sayali Lokhande , Li Wei , Bjorn Andersson , Jaegeu List-Id: linux-scsi@vger.kernel.org On Fri, Sep 14, 2018 at 09:52:38AM +0800, Ming Lei wrote: > However, in previous discussion, it is strongly objected to use > per-driver/device .use_blk_mq switch, so not sure if this way can > be accepted. I don't like the per-driver switch as module_parameter at all and we should never do that. We had some exceptions for drivers to force blk_mq (e.g. virtio), and given that I don't think we'll solve the blk-mq runtime-pm issue for 4.19 and also don't want to revert the default I think this patch is the best compromise for 4.19, with a revert in 4.20 once we have runtime-pm for blk-mq. So: Acked-by: Christoph Hellwig