✗ Fi.CI.CHECKPATCH: warning for drm/i915: Infoframe precompute/check

From: Patchwork <patchwork@emeril.freedesktop.org>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Infoframe precompute/check
Date: Thu, 20 Sep 2018 19:02:13 -0000	[thread overview]
Message-ID: <20180920190213.23687.63850@emeril.freedesktop.org> (raw)
In-Reply-To: <20180920185145.1912-1-ville.syrjala@linux.intel.com>

== Series Details ==

Series: drm/i915: Infoframe precompute/check
URL   : https://patchwork.freedesktop.org/series/49983/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
a017fc23cf36 video/hdmi: Constify 'buffer' to the unpack functions
0a03b408d82f video/hdmi: Pass buffer size to infoframe unpack functions
5e5b56d27f18 video/hdmi: Constify infoframe passed to the log functions
d0b178dc443b video/hdmi: Constify infoframe passed to the pack functions
0986996f110b video/hdmi: Add an enum for HDMI packet types
72b90dd1fe07 video/hdmi: Handle the MPEG Source infoframe
-:351: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#351: FILE: include/linux/hdmi.h:355:
+	bool field_repeat;

total: 0 errors, 0 warnings, 1 checks, 340 lines checked
41d4768fd109 video/hdmi: Handle the NTSC VBI infoframe
c2cb612d54fa drm/i915: Use memmove() for punching the hole into infoframes
367a7d97dd45 drm/i915: Pass intel_encoder to infoframe functions
cbdd05631044 drm/i915: Add the missing HDMI gamut metadata packet stuff
-:35: WARNING:LONG_LINE: line over 100 characters
#35: FILE: drivers/gpu/drm/i915/i915_reg.h:7956:
+#define HSW_TVIDEO_DIP_GMP_DATA(trans, i)	_MMIO_TRANS2(trans, _HSW_VIDEO_DIP_GMP_DATA_A + (i) * 4)

total: 0 errors, 1 warnings, 0 checks, 55 lines checked
a5c2fe997d55 drm/i915: Return the mask of enabled infoframes from ->inforame_enabled()
570e42f6d35c drm/i915: Store mask of enabled infoframes in the crtc state
05deffb2dac6 drm/i915: Precompute HDMI infoframes
4a85a46081d1 drm/i915: Read out HDMI infoframes
183a843e443c drm/i915/sdvo: Precompute HDMI infoframes
a12eb68ce310 drm/i915/sdvo: Read out HDMI infoframes
e102b1bf70d2 drm/i915: Check infoframe state in intel_pipe_config_compare()
-:70: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects?
#70: FILE: drivers/gpu/drm/i915/intel_display.c:11575:
+#define PIPE_CONF_CHECK_INFOFRAME(name) do { \
+	if (!intel_compare_infoframe(&current_config->infoframes.name, \
+				     &pipe_config->infoframes.name)) { \
+		pipe_config_infoframe_err(dev_priv, adjust, __stringify(name), \
+					  &current_config->infoframes.name, \
+					  &pipe_config->infoframes.name); \
+		ret = false; \
+	} \
+} while (0)

total: 0 errors, 0 warnings, 1 checks, 67 lines checked
cbbbc6773054 drm/i915: Include infoframes in the crtc state dump

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx