From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3DCAC433F4 for ; Thu, 20 Sep 2018 22:05:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 76D4921522 for ; Thu, 20 Sep 2018 22:05:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76D4921522 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388784AbeIUDu4 (ORCPT ); Thu, 20 Sep 2018 23:50:56 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:55792 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728347AbeIUDu4 (ORCPT ); Thu, 20 Sep 2018 23:50:56 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 67E6280749; Fri, 21 Sep 2018 00:05:17 +0200 (CEST) Date: Fri, 21 Sep 2018 00:05:16 +0200 From: Pavel Machek To: "Rafael J. Wysocki" Cc: Ingo Molnar , "Chen, Yu C" , Thomas Gleixner , "Rafael J. Wysocki" , the arch/x86 maintainers , Linux Kernel Mailing List , Linux PM , Len Brown , kookoo.gu@intel.com Subject: Re: [PATCH 04/12][RFC v3] x86, hibernate: Extract the common code of 64/32 bit system Message-ID: <20180920220516.GF27468@xo-6d-61-c0.localdomain> References: <020db877db6a8d39808dfaef2a5162f541f0853b.1537275915.git.yu.c.chen@intel.com> <20180919103405.GA19621@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 2018-09-19 12:36:40, Rafael J. Wysocki wrote: > On Wed, Sep 19, 2018 at 12:34 PM Ingo Molnar wrote: > > > > > > * Rafael J. Wysocki wrote: > > > > > > index 000000000000..fbde8f0e8fe0 > > > > --- /dev/null > > > > +++ b/arch/x86/power/hibernate.c > > > > @@ -0,0 +1,249 @@ > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > +/* > > > > + * Hibernation support for x86 > > > > + * > > > > + * Copyright (c) 2007 Rafael J. Wysocki > > > > + * Copyright (c) 2002 Pavel Machek > > > > + * Copyright (c) 2001 Patrick Mochel > > > > > > I don't think this "copyright" information has any legal bearing any > > > more at this point. > > > > I think that's wrong in general, and it's routine for corporate legal > > departments to insist on specific boilerplate copyright notices when > > OSS code is contributed. > > > > Copying code and then removing copyright notices is frowned upon > > independently as well. > > > > While you can probably talk for your own copyright notice, I'm not sure > > it's true of the two other historic copyright notices that were copied. > > > > So I think it's best practice to preserve all copyright notices as-is. > > OK, let's retain them, then. Thank you, I was about to make same comment as Ingo. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html