From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A13CCC433F4 for ; Fri, 21 Sep 2018 07:32:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6472B21531 for ; Fri, 21 Sep 2018 07:32:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6472B21531 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389570AbeIUNUS (ORCPT ); Fri, 21 Sep 2018 09:20:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60958 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389398AbeIUNUR (ORCPT ); Fri, 21 Sep 2018 09:20:17 -0400 Received: from smtp.corp.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 22DC830001D9; Fri, 21 Sep 2018 07:32:42 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-12-74.pek2.redhat.com [10.72.12.74]) by smtp.corp.redhat.com (Postfix) with ESMTP id 945C389AF5; Fri, 21 Sep 2018 07:32:30 +0000 (UTC) From: Lianbo Jiang To: linux-kernel@vger.kernel.org Cc: kexec@lists.infradead.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, akpm@linux-foundation.org, dan.j.williams@intel.com, thomas.lendacky@amd.com, bhelgaas@google.com, baiyaowei@cmss.chinamobile.com, tiwai@suse.de, bp@suse.de, brijesh.singh@amd.com, dyoung@redhat.com, bhe@redhat.com Subject: [PATCH 1/3 v3] resource: fix an error which walks through iomem resources Date: Fri, 21 Sep 2018 15:32:09 +0800 Message-Id: <20180921073211.20097-2-lijiang@redhat.com> In-Reply-To: <20180921073211.20097-1-lijiang@redhat.com> References: <20180921073211.20097-1-lijiang@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Fri, 21 Sep 2018 07:32:42 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When we walk through iomem resources by calling walk_iomem_res_desc(), the values of the function parameter may be modified in the while loop of __walk_iomem_res_desc(), which will cause us to not get the desired result in some cases. At present, it only restores the original value of res->end, but it doesn't restore the original value of res->flags in the while loop of __walk_iomem _res_desc(). Whenever the find_next_iomem_res() finds a resource and returns the result, the original values of this resource will be modified, which might lead to an error in the next loop. For example: The original value of resource flags is: res->flags=0x80000200(initial value) p->flags _ 0x81000200 _ _ 0x80000200 _ / \ / \ |________|_______A________|____|_....._|______B_________|..........___| 0 0xffffffff (memory address ranges) Note: if ((p->flags & res->flags) != res->flags) continue; When the resource A is found, the original value of this resource flags will be changed to 0x81000200(res->flags=0x81000200), and continue to look for the next resource, when the loop reaches resource B, it can not get the resource B any more(you can refer to the for loop of find_next _iomem_res()), because the value of conditional expression will become true and will also jump the resource B. In fact, we should get the resource A and B when we walk through the whole tree, but it only gets the resource A, the resource B is missed. Signed-off-by: Lianbo Jiang --- kernel/resource.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/resource.c b/kernel/resource.c index 30e1bc68503b..f5d9fc70a04c 100644 --- a/kernel/resource.c +++ b/kernel/resource.c @@ -375,6 +375,7 @@ static int __walk_iomem_res_desc(struct resource *res, unsigned long desc, int (*func)(struct resource *, void *)) { u64 orig_end = res->end; + u64 orig_flags = res->flags; int ret = -1; while ((res->start < res->end) && @@ -385,6 +386,7 @@ static int __walk_iomem_res_desc(struct resource *res, unsigned long desc, res->start = res->end + 1; res->end = orig_end; + res->flags = orig_flags; } return ret; -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1g3Fvr-000213-9p for kexec@lists.infradead.org; Fri, 21 Sep 2018 07:32:56 +0000 From: Lianbo Jiang Subject: [PATCH 1/3 v3] resource: fix an error which walks through iomem resources Date: Fri, 21 Sep 2018 15:32:09 +0800 Message-Id: <20180921073211.20097-2-lijiang@redhat.com> In-Reply-To: <20180921073211.20097-1-lijiang@redhat.com> References: <20180921073211.20097-1-lijiang@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: linux-kernel@vger.kernel.org Cc: thomas.lendacky@amd.com, brijesh.singh@amd.com, bhe@redhat.com, tiwai@suse.de, x86@kernel.org, kexec@lists.infradead.org, mingo@redhat.com, baiyaowei@cmss.chinamobile.com, hpa@zytor.com, bhelgaas@google.com, tglx@linutronix.de, bp@suse.de, dyoung@redhat.com, akpm@linux-foundation.org, dan.j.williams@intel.com When we walk through iomem resources by calling walk_iomem_res_desc(), the values of the function parameter may be modified in the while loop of __walk_iomem_res_desc(), which will cause us to not get the desired result in some cases. At present, it only restores the original value of res->end, but it doesn't restore the original value of res->flags in the while loop of __walk_iomem _res_desc(). Whenever the find_next_iomem_res() finds a resource and returns the result, the original values of this resource will be modified, which might lead to an error in the next loop. For example: The original value of resource flags is: res->flags=0x80000200(initial value) p->flags _ 0x81000200 _ _ 0x80000200 _ / \ / \ |________|_______A________|____|_....._|______B_________|..........___| 0 0xffffffff (memory address ranges) Note: if ((p->flags & res->flags) != res->flags) continue; When the resource A is found, the original value of this resource flags will be changed to 0x81000200(res->flags=0x81000200), and continue to look for the next resource, when the loop reaches resource B, it can not get the resource B any more(you can refer to the for loop of find_next _iomem_res()), because the value of conditional expression will become true and will also jump the resource B. In fact, we should get the resource A and B when we walk through the whole tree, but it only gets the resource A, the resource B is missed. Signed-off-by: Lianbo Jiang --- kernel/resource.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/resource.c b/kernel/resource.c index 30e1bc68503b..f5d9fc70a04c 100644 --- a/kernel/resource.c +++ b/kernel/resource.c @@ -375,6 +375,7 @@ static int __walk_iomem_res_desc(struct resource *res, unsigned long desc, int (*func)(struct resource *, void *)) { u64 orig_end = res->end; + u64 orig_flags = res->flags; int ret = -1; while ((res->start < res->end) && @@ -385,6 +386,7 @@ static int __walk_iomem_res_desc(struct resource *res, unsigned long desc, res->start = res->end + 1; res->end = orig_end; + res->flags = orig_flags; } return ret; -- 2.17.1 _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec