From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v3 0/2] net/failsafe: support multicast MAC
 address set
Date: Fri, 21 Sep 2018 09:43:33 -0700
Message-ID: <20180921094333.0c1e0fa3@xeon-e3>
References: <1535730814-24624-1-git-send-email-arybchenko@solarflare.com>
 <1537544182-17823-1-git-send-email-arybchenko@solarflare.com>
 <20180921092108.50830844@xeon-e3>
 <c63e428b-1cbc-8976-e9db-98a61f0d0297@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>, <dev@dpdk.org>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com
 [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 6B9471B112
 for <dev@dpdk.org>; Fri, 21 Sep 2018 18:43:42 +0200 (CEST)
Received: by mail-pf1-f193.google.com with SMTP id x17-v6so6225280pfh.5
 for <dev@dpdk.org>; Fri, 21 Sep 2018 09:43:42 -0700 (PDT)
In-Reply-To: <c63e428b-1cbc-8976-e9db-98a61f0d0297@solarflare.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 21 Sep 2018 19:33:16 +0300
Andrew Rybchenko <arybchenko@solarflare.com> wrote:

> On 9/21/18 7:21 PM, Stephen Hemminger wrote:
> > On Fri, 21 Sep 2018 16:36:19 +0100
> > Andrew Rybchenko <arybchenko@solarflare.com> wrote:
> >  
> >> v3:
> >>      - move apply on sync to fs_eth_dev_conf_apply() to apply to
> >>        a new subdevice only
> >>      - use ethdev API to apply to sub-device on sync
> >>      - remove unnecessary check the same pointer from the method
> >>        implementation in failsafe
> >>
> >> v2:
> >>      - fix setting of zero addresses since rte_realloc() returns NULL
> >>
> >> Evgeny Im (2):
> >>    net/failsafe: remove not supported multicast MAC filter
> >>    net/failsafe: support multicast address list set
> >>
> >>   doc/guides/rel_notes/release_18_11.rst  |  1 +
> >>   drivers/net/failsafe/failsafe.c         |  1 +
> >>   drivers/net/failsafe/failsafe_ether.c   | 17 +++++++++
> >>   drivers/net/failsafe/failsafe_ops.c     | 50 +++++++++++++++++++++++++
> >>   drivers/net/failsafe/failsafe_private.h |  2 +
> >>   5 files changed, 71 insertions(+)
> >>  
> > Since TAP has no filtering this doesn't really do much for the slowpath.  
> 
> Yes, I know that TAP does not support it. Is failsafe so tighly bound to 
> TAP to block it?
> 

failsafe was built to be used with tap and mlx on Azure.
It could be used with virtio and other NIC on KVM, but this is mostly theoretical.