All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Freimann <jfreimann@redhat.com>
To: "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"tiwei.bie@intel.com" <tiwei.bie@intel.com>,
	"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Subject: Re: [PATCH v5 06/11] net/virtio-user: add option to use packed queues
Date: Fri, 21 Sep 2018 12:05:38 +0200	[thread overview]
Message-ID: <20180921100538.ulbm4l2qrvmeda56@jenstp.localdomain> (raw)
In-Reply-To: <VI1PR08MB3167F43284CD3CAE034520D68F050@VI1PR08MB3167.eurprd08.prod.outlook.com>

On Mon, Sep 10, 2018 at 06:32:09AM +0000, Gavin Hu (Arm Technology China) wrote:
>
>
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Jens Freimann
>> Sent: Friday, September 7, 2018 2:20 AM
>> To: dev@dpdk.org
>> Cc: tiwei.bie@intel.com; maxime.coquelin@redhat.com
>> Subject: [dpdk-dev] [PATCH v5 06/11] net/virtio-user: add option to use
>> packed queues
>>
>> From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>>
>> Add option to enable packed queue support for virtio-user devices.
>>
>> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>> ---
>>  drivers/net/virtio/virtio_user/virtio_user_dev.c | 10 ++++++++--
>> drivers/net/virtio/virtio_user/virtio_user_dev.h |  2 +-
>>  drivers/net/virtio/virtio_user_ethdev.c          | 14 +++++++++++++-
>>  3 files changed, 22 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c
>> b/drivers/net/virtio/virtio_user/virtio_user_dev.c
>> index 7df600b02..9979bea0d 100644
>> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
>> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
>> @@ -372,12 +372,13 @@ virtio_user_dev_setup(struct virtio_user_dev *dev)
>>   1ULL << VIRTIO_NET_F_GUEST_TSO4|\
>>   1ULL << VIRTIO_NET_F_GUEST_TSO6|\
>>   1ULL << VIRTIO_F_IN_ORDER|\
>> - 1ULL << VIRTIO_F_VERSION_1)
>> + 1ULL << VIRTIO_F_VERSION_1|\
>> + 1ULL << VIRTIO_F_RING_PACKED)
>>
>>  int
>>  virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,
>>       int cq, int queue_size, const char *mac, char **ifname,
>> -     int mrg_rxbuf, int in_order)
>> +     int mrg_rxbuf, int in_order, int packed_vq)
>>  {
>>  pthread_mutex_init(&dev->mutex, NULL);
>>  snprintf(dev->path, PATH_MAX, "%s", path); @@ -432,6 +433,11
>> @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int
>> queues,
>>  dev->unsupported_features |= (1ull <<
>> VIRTIO_F_IN_ORDER);
>>  }
>>
>> +if (packed_vq)
>> +dev->device_features |= (1ull << VIRTIO_F_RING_PACKED);
>> +else
>> +dev->device_features &= ~(1ull <<
>> VIRTIO_F_RING_PACKED);
>> +
>
>unsupported_features should be initialized also like following F_MAC.

Fixed it. Thanks!

regards,
Jens 

  reply	other threads:[~2018-09-21 10:05 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-06 18:19 [PATCH v5 00/11] implement packed virtqueues Jens Freimann
2018-09-06 18:19 ` [PATCH v5 01/11] net/virtio: vring init for packed queues Jens Freimann
2018-09-10  5:48   ` Gavin Hu (Arm Technology China)
2018-09-12  8:02   ` Maxime Coquelin
2018-09-12  9:04     ` Jens Freimann
2018-09-06 18:19 ` [PATCH v5 02/11] net/virtio: add virtio 1.1 defines Jens Freimann
2018-09-10  5:22   ` Gavin Hu (Arm Technology China)
2018-09-10  6:07     ` Tiwei Bie
2018-09-11  7:18     ` Jens Freimann
2018-09-06 18:19 ` [PATCH v5 03/11] net/virtio: add packed virtqueue helpers Jens Freimann
2018-09-12  8:25   ` Maxime Coquelin
2018-09-12  9:04     ` Jens Freimann
2018-09-06 18:19 ` [PATCH v5 04/11] net/virtio: flush packed receive virtqueues Jens Freimann
2018-09-12  9:12   ` Maxime Coquelin
2018-09-12  9:49     ` Jens Freimann
2018-09-06 18:19 ` [PATCH v5 05/11] net/virtio: dump packed virtqueue data Jens Freimann
2018-09-10  6:02   ` Gavin Hu (Arm Technology China)
2018-09-10  6:18     ` Tiwei Bie
2018-09-11  7:16       ` Jens Freimann
2018-09-12  9:13   ` Maxime Coquelin
2018-09-06 18:19 ` [PATCH v5 06/11] net/virtio-user: add option to use packed queues Jens Freimann
2018-09-10  6:32   ` Gavin Hu (Arm Technology China)
2018-09-21 10:05     ` Jens Freimann [this message]
2018-09-12  9:25   ` Maxime Coquelin
2018-09-06 18:19 ` [PATCH v5 07/11] net/virtio: implement transmit path for " Jens Freimann
2018-09-10  7:13   ` Gavin Hu (Arm Technology China)
2018-09-10  9:39   ` Gavin Hu (Arm Technology China)
2018-09-12 14:58   ` Maxime Coquelin
2018-09-13  9:15   ` Tiwei Bie
2018-09-06 18:19 ` [PATCH v5 08/11] net/virtio: implement receive " Jens Freimann
2018-09-10 10:56   ` Gavin Hu (Arm Technology China)
2018-09-06 18:19 ` [PATCH v5 09/11] net/virtio: disable ctrl virtqueue for packed rings Jens Freimann
2018-09-14  5:32   ` Tiwei Bie
2018-09-17  9:11     ` Jens Freimann
2018-09-06 18:19 ` [PATCH v5 10/11] net/virtio: add support for mergeable buffers with packed virtqueues Jens Freimann
2018-09-06 18:19 ` [PATCH v5 11/11] net/virtio: add support for event suppression Jens Freimann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180921100538.ulbm4l2qrvmeda56@jenstp.localdomain \
    --to=jfreimann@redhat.com \
    --cc=Gavin.Hu@arm.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=tiwei.bie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.