From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 7/8] drm/i915: Move programming plane scaler
 to its own function.
Date: Fri, 21 Sep 2018 18:29:20 +0300
Message-ID: <20180921152920.GD5565@intel.com>
References: <20180920102711.4184-1-maarten.lankhorst@linux.intel.com>
 <20180920102711.4184-8-maarten.lankhorst@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 3A8A66E82D
 for <intel-gfx@lists.freedesktop.org>; Fri, 21 Sep 2018 15:29:24 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20180920102711.4184-8-maarten.lankhorst@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBTZXAgMjAsIDIwMTggYXQgMTI6Mjc6MTBQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y
c3Qgd3JvdGU6Cj4gVGhpcyBjbGVhbnMgdGhlIGNvZGUgdXAgc2xpZ2h0bHksIGFuZCB3aWxsIG1h
a2Ugb3RoZXIgY2hhbmdlcyBlYXNpZXIuCj4gCj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5r
aG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgfCA5MCArKysrKysrKysrKysrKysrKy0tLS0t
LS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNTIgaW5zZXJ0aW9ucygrKSwgMzggZGVsZXRpb25z
KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5j
IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiBpbmRleCBkNGM4ZTEwZmM5
MGIuLjdkM2M3NDY5ZDI3MSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl
bF9zcHJpdGUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4g
QEAgLTI4MCwxMyArMjgwLDYzIEBAIHNrbF9wbGFuZV9tYXhfc3RyaWRlKHN0cnVjdCBpbnRlbF9w
bGFuZSAqcGxhbmUsCj4gIAkJcmV0dXJuIG1pbig4MTkyICogY3BwLCAzMjc2OCk7Cj4gIH0KPiAg
Cj4gK3N0YXRpYyB2b2lkCj4gK3NrbF9wcm9ncmFtX3NjYWxlcihzdHJ1Y3QgZHJtX2k5MTVfcHJp
dmF0ZSAqZGV2X3ByaXYsCj4gKwkJICAgc3RydWN0IGludGVsX3BsYW5lICpwbGFuZSwKCkNvdWxk
IGhhdmUgZHVnIHRoZXNlIG91dCBmcm9tIHRoZSBzdGF0ZXMgcmF0aGVyIHRoYW4gcGFzc2luZyBp
bgpleHBsaWNpdGx5LiBJIHByZWZlciBtaW5pbWxpc20gd2hlbiBpdCBjb21lcyB0byBmdW5jdGlv
biBhcmd1bWVudHMuCgo+ICsJCSAgIGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRj
X3N0YXRlLAo+ICsJCSAgIGNvbnN0IHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3Rh
dGUpCj4gK3sKPiArCWVudW0gcGxhbmVfaWQgcGxhbmVfaWQgPSBwbGFuZS0+aWQ7Cj4gKwllbnVt
IHBpcGUgcGlwZSA9IHBsYW5lLT5waXBlOwo+ICsJaW50IHNjYWxlcl9pZCA9IHBsYW5lX3N0YXRl
LT5zY2FsZXJfaWQ7Cj4gKwljb25zdCBzdHJ1Y3QgaW50ZWxfc2NhbGVyICpzY2FsZXIgPQo+ICsJ
CSZjcnRjX3N0YXRlLT5zY2FsZXJfc3RhdGUuc2NhbGVyc1tzY2FsZXJfaWRdOwo+ICsJaW50IGNy
dGNfeCA9IHBsYW5lX3N0YXRlLT5iYXNlLmRzdC54MTsKPiArCWludCBjcnRjX3kgPSBwbGFuZV9z
dGF0ZS0+YmFzZS5kc3QueTE7Cj4gKwl1aW50MzJfdCBjcnRjX3cgPSBkcm1fcmVjdF93aWR0aCgm
cGxhbmVfc3RhdGUtPmJhc2UuZHN0KTsKPiArCXVpbnQzMl90IGNydGNfaCA9IGRybV9yZWN0X2hl
aWdodCgmcGxhbmVfc3RhdGUtPmJhc2UuZHN0KTsKPiArCXUxNiB5X2hwaGFzZSwgdXZfcmdiX2hw
aGFzZTsKPiArCXUxNiB5X3ZwaGFzZSwgdXZfcmdiX3ZwaGFzZTsKPiArCj4gKwkvKiBTaXplcyBh
cmUgMCBiYXNlZCAqLwo+ICsJY3J0Y193LS07Cj4gKwljcnRjX2gtLTsKPiArCj4gKwkvKiBUT0RP
OiBoYW5kbGUgc3ViLXBpeGVsIGNvb3JkaW5hdGVzICovCj4gKwlpZiAocGxhbmVfc3RhdGUtPmJh
c2UuZmItPmZvcm1hdC0+Zm9ybWF0ID09IERSTV9GT1JNQVRfTlYxMikgewo+ICsJCXlfaHBoYXNl
ID0gc2tsX3NjYWxlcl9jYWxjX3BoYXNlKDEsIGZhbHNlKTsKPiArCQl5X3ZwaGFzZSA9IHNrbF9z
Y2FsZXJfY2FsY19waGFzZSgxLCBmYWxzZSk7Cj4gKwo+ICsJCS8qIE1QRUcyIGNocm9tYSBzaXRp
bmcgY29udmVudGlvbiAqLwo+ICsJCXV2X3JnYl9ocGhhc2UgPSBza2xfc2NhbGVyX2NhbGNfcGhh
c2UoMiwgdHJ1ZSk7Cj4gKwkJdXZfcmdiX3ZwaGFzZSA9IHNrbF9zY2FsZXJfY2FsY19waGFzZSgy
LCBmYWxzZSk7Cj4gKwl9IGVsc2Ugewo+ICsJCS8qIG5vdCB1c2VkICovCj4gKwkJeV9ocGhhc2Ug
PSAwOwo+ICsJCXlfdnBoYXNlID0gMDsKPiArCj4gKwkJdXZfcmdiX2hwaGFzZSA9IHNrbF9zY2Fs
ZXJfY2FsY19waGFzZSgxLCBmYWxzZSk7Cj4gKwkJdXZfcmdiX3ZwaGFzZSA9IHNrbF9zY2FsZXJf
Y2FsY19waGFzZSgxLCBmYWxzZSk7Cj4gKwl9Cj4gKwo+ICsJSTkxNV9XUklURV9GVyhTS0xfUFNf
Q1RSTChwaXBlLCBzY2FsZXJfaWQpLAo+ICsJCSAgICAgIFBTX1NDQUxFUl9FTiB8IFBTX1BMQU5F
X1NFTChwbGFuZV9pZCkgfCBzY2FsZXItPm1vZGUpOwo+ICsJSTkxNV9XUklURV9GVyhTS0xfUFNf
UFdSX0dBVEUocGlwZSwgc2NhbGVyX2lkKSwgMCk7Cj4gKwlJOTE1X1dSSVRFX0ZXKFNLTF9QU19W
UEhBU0UocGlwZSwgc2NhbGVyX2lkKSwKPiArCQkgICAgICBQU19ZX1BIQVNFKHlfdnBoYXNlKSB8
IFBTX1VWX1JHQl9QSEFTRSh1dl9yZ2JfdnBoYXNlKSk7Cj4gKwlJOTE1X1dSSVRFX0ZXKFNLTF9Q
U19IUEhBU0UocGlwZSwgc2NhbGVyX2lkKSwKPiArCQkgICAgICBQU19ZX1BIQVNFKHlfaHBoYXNl
KSB8IFBTX1VWX1JHQl9QSEFTRSh1dl9yZ2JfaHBoYXNlKSk7Cj4gKwlJOTE1X1dSSVRFX0ZXKFNL
TF9QU19XSU5fUE9TKHBpcGUsIHNjYWxlcl9pZCksIChjcnRjX3ggPDwgMTYpIHwgY3J0Y195KTsK
PiArCUk5MTVfV1JJVEVfRlcoU0tMX1BTX1dJTl9TWihwaXBlLCBzY2FsZXJfaWQpLAo+ICsJCSAg
ICAgICgoY3J0Y193ICsgMSkgPDwgMTYpfChjcnRjX2ggKyAxKSk7Cj4gK30KPiArCj4gIHZvaWQK
PiAgc2tsX3VwZGF0ZV9wbGFuZShzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lLAo+ICAJCSBjb25z
dCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPiAgCQkgY29uc3Qgc3RydWN0
IGludGVsX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZSkKPiAgewo+ICAJc3RydWN0IGRybV9pOTE1
X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShwbGFuZS0+YmFzZS5kZXYpOwo+IC0JY29uc3Qg
c3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIgPSBwbGFuZV9zdGF0ZS0+YmFzZS5mYjsKPiAgCWVu
dW0gcGxhbmVfaWQgcGxhbmVfaWQgPSBwbGFuZS0+aWQ7Cj4gIAllbnVtIHBpcGUgcGlwZSA9IHBs
YW5lLT5waXBlOwo+ICAJdTMyIHBsYW5lX2N0bCA9IHBsYW5lX3N0YXRlLT5jdGw7Cj4gQEAgLTI5
Niw4ICszNDYsNiBAQCBza2xfdXBkYXRlX3BsYW5lKHN0cnVjdCBpbnRlbF9wbGFuZSAqcGxhbmUs
Cj4gIAl1MzIgYXV4X3N0cmlkZSA9IHNrbF9wbGFuZV9zdHJpZGUocGxhbmVfc3RhdGUsIDEpOwo+
ICAJaW50IGNydGNfeCA9IHBsYW5lX3N0YXRlLT5iYXNlLmRzdC54MTsKPiAgCWludCBjcnRjX3kg
PSBwbGFuZV9zdGF0ZS0+YmFzZS5kc3QueTE7Cj4gLQl1aW50MzJfdCBjcnRjX3cgPSBkcm1fcmVj
dF93aWR0aCgmcGxhbmVfc3RhdGUtPmJhc2UuZHN0KTsKPiAtCXVpbnQzMl90IGNydGNfaCA9IGRy
bV9yZWN0X2hlaWdodCgmcGxhbmVfc3RhdGUtPmJhc2UuZHN0KTsKPiAgCXVpbnQzMl90IHggPSBw
bGFuZV9zdGF0ZS0+Y29sb3JfcGxhbmVbMF0ueDsKPiAgCXVpbnQzMl90IHkgPSBwbGFuZV9zdGF0
ZS0+Y29sb3JfcGxhbmVbMF0ueTsKPiAgCXVpbnQzMl90IHNyY193ID0gZHJtX3JlY3Rfd2lkdGgo
JnBsYW5lX3N0YXRlLT5iYXNlLnNyYykgPj4gMTY7Cj4gQEAgLTMwNyw4ICszNTUsNiBAQCBza2xf
dXBkYXRlX3BsYW5lKHN0cnVjdCBpbnRlbF9wbGFuZSAqcGxhbmUsCj4gIAkvKiBTaXplcyBhcmUg
MCBiYXNlZCAqLwo+ICAJc3JjX3ctLTsKPiAgCXNyY19oLS07Cj4gLQljcnRjX3ctLTsKPiAtCWNy
dGNfaC0tOwo+ICAKPiAgCXNwaW5fbG9ja19pcnFzYXZlKCZkZXZfcHJpdi0+dW5jb3JlLmxvY2ss
IGlycWZsYWdzKTsKPiAgCj4gQEAgLTMzMywzOSArMzc5LDcgQEAgc2tsX3VwZGF0ZV9wbGFuZShz
dHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lLAo+ICAKPiAgCS8qIHByb2dyYW0gcGxhbmUgc2NhbGVy
ICovCj4gIAlpZiAocGxhbmVfc3RhdGUtPnNjYWxlcl9pZCA+PSAwKSB7Cj4gLQkJaW50IHNjYWxl
cl9pZCA9IHBsYW5lX3N0YXRlLT5zY2FsZXJfaWQ7Cj4gLQkJY29uc3Qgc3RydWN0IGludGVsX3Nj
YWxlciAqc2NhbGVyID0KPiAtCQkJJmNydGNfc3RhdGUtPnNjYWxlcl9zdGF0ZS5zY2FsZXJzW3Nj
YWxlcl9pZF07Cj4gLQkJdTE2IHlfaHBoYXNlLCB1dl9yZ2JfaHBoYXNlOwo+IC0JCXUxNiB5X3Zw
aGFzZSwgdXZfcmdiX3ZwaGFzZTsKPiAtCj4gLQkJLyogVE9ETzogaGFuZGxlIHN1Yi1waXhlbCBj
b29yZGluYXRlcyAqLwo+IC0JCWlmIChmYi0+Zm9ybWF0LT5mb3JtYXQgPT0gRFJNX0ZPUk1BVF9O
VjEyKSB7Cj4gLQkJCXlfaHBoYXNlID0gc2tsX3NjYWxlcl9jYWxjX3BoYXNlKDEsIGZhbHNlKTsK
PiAtCQkJeV92cGhhc2UgPSBza2xfc2NhbGVyX2NhbGNfcGhhc2UoMSwgZmFsc2UpOwo+IC0KPiAt
CQkJLyogTVBFRzIgY2hyb21hIHNpdGluZyBjb252ZW50aW9uICovCj4gLQkJCXV2X3JnYl9ocGhh
c2UgPSBza2xfc2NhbGVyX2NhbGNfcGhhc2UoMiwgdHJ1ZSk7Cj4gLQkJCXV2X3JnYl92cGhhc2Ug
PSBza2xfc2NhbGVyX2NhbGNfcGhhc2UoMiwgZmFsc2UpOwo+IC0JCX0gZWxzZSB7Cj4gLQkJCS8q
IG5vdCB1c2VkICovCj4gLQkJCXlfaHBoYXNlID0gMDsKPiAtCQkJeV92cGhhc2UgPSAwOwo+IC0K
PiAtCQkJdXZfcmdiX2hwaGFzZSA9IHNrbF9zY2FsZXJfY2FsY19waGFzZSgxLCBmYWxzZSk7Cj4g
LQkJCXV2X3JnYl92cGhhc2UgPSBza2xfc2NhbGVyX2NhbGNfcGhhc2UoMSwgZmFsc2UpOwo+IC0J
CX0KPiAtCj4gLQkJSTkxNV9XUklURV9GVyhTS0xfUFNfQ1RSTChwaXBlLCBzY2FsZXJfaWQpLAo+
IC0JCQkgICAgICBQU19TQ0FMRVJfRU4gfCBQU19QTEFORV9TRUwocGxhbmVfaWQpIHwgc2NhbGVy
LT5tb2RlKTsKPiAtCQlJOTE1X1dSSVRFX0ZXKFNLTF9QU19QV1JfR0FURShwaXBlLCBzY2FsZXJf
aWQpLCAwKTsKPiAtCQlJOTE1X1dSSVRFX0ZXKFNLTF9QU19WUEhBU0UocGlwZSwgc2NhbGVyX2lk
KSwKPiAtCQkJICAgICAgUFNfWV9QSEFTRSh5X3ZwaGFzZSkgfCBQU19VVl9SR0JfUEhBU0UodXZf
cmdiX3ZwaGFzZSkpOwo+IC0JCUk5MTVfV1JJVEVfRlcoU0tMX1BTX0hQSEFTRShwaXBlLCBzY2Fs
ZXJfaWQpLAo+IC0JCQkgICAgICBQU19ZX1BIQVNFKHlfaHBoYXNlKSB8IFBTX1VWX1JHQl9QSEFT
RSh1dl9yZ2JfaHBoYXNlKSk7Cj4gLQkJSTkxNV9XUklURV9GVyhTS0xfUFNfV0lOX1BPUyhwaXBl
LCBzY2FsZXJfaWQpLCAoY3J0Y194IDw8IDE2KSB8IGNydGNfeSk7Cj4gLQkJSTkxNV9XUklURV9G
VyhTS0xfUFNfV0lOX1NaKHBpcGUsIHNjYWxlcl9pZCksCj4gLQkJCSAgICAgICgoY3J0Y193ICsg
MSkgPDwgMTYpfChjcnRjX2ggKyAxKSk7Cj4gKwkJc2tsX3Byb2dyYW1fc2NhbGVyKGRldl9wcml2
LCBwbGFuZSwgY3J0Y19zdGF0ZSwgcGxhbmVfc3RhdGUpOwo+ICAKPiAgCQlJOTE1X1dSSVRFX0ZX
KFBMQU5FX1BPUyhwaXBlLCBwbGFuZV9pZCksIDApOwo+ICAJfSBlbHNlIHsKPiAtLSAKPiAyLjE4
LjAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+
IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn
Cj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n
ZngKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz
dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v
bGlzdGluZm8vaW50ZWwtZ2Z4Cg==