From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1g3Ph5-0006lo-6Y for mharc-grub-devel@gnu.org; Fri, 21 Sep 2018 13:58:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g3Ph3-0006lf-GX for grub-devel@gnu.org; Fri, 21 Sep 2018 13:58:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g3Pgz-00024e-WF for grub-devel@gnu.org; Fri, 21 Sep 2018 13:58:17 -0400 Received: from dibed.net-space.pl ([84.10.22.86]:47283) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.71) (envelope-from ) id 1g3Pgz-00021u-Jw for grub-devel@gnu.org; Fri, 21 Sep 2018 13:58:13 -0400 Received: (from localhost user: 'dkiper' uid#4000 fake: STDIN (dkiper@dibed.net-space.pl)) by router-fw-old.i.net-space.pl id S1870762AbeIUR6G (ORCPT ); Fri, 21 Sep 2018 19:58:06 +0200 Date: Fri, 21 Sep 2018 19:58:06 +0200 From: Daniel Kiper To: Paul Menzel Cc: Daniel Kiper , grub-devel@gnu.org, Vladimir 'phcoder' Serbinenko Subject: Re: [PATCH v2] grub-install: Mention *efibootmgr* in `no-nvram` description Message-ID: <20180921175806.GA29978@router-fw-old.i.net-space.pl> References: <949fe4dd-5350-e456-0792-cb0818ef26ef@molgen.mpg.de> <20180919140821.GG7003@router-fw-old.i.net-space.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.28i X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 84.10.22.86 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2018 17:58:18 -0000 On Wed, Sep 19, 2018 at 04:18:45PM +0200, Paul Menzel wrote: > Dear Daniel, > > > On 09/19/18 16:08, Daniel Kiper wrote: > > On Thu, Sep 06, 2018 at 08:37:50PM +0300, Vladimir 'phcoder' Serbinenko wrote: > >> On Thu, 6 Sep 2018, 17:03 Paul Menzel, wrote: > >> > >>> Date: Thu, 6 Sep 2018 15:15:45 +0200 > >>> > >>> If executing `efibootmgr` fails, for example, because the system is > >>> booted in legacy mode, but with a mounted EFI System Partition, the > >>> error message mentions *efibootmgr*. To make it easier for users to work > >>> around that problem by skipping running `efibootmgr`, add the word to > >>> the description of the switch *no-nvram*, which skips the efibootmgr > >>> execution. > >>> > >>> Signed-off-by: Paul Menzel > >>> --- > >>> v2: Add Signed-off-by line > >>> > >>> util/grub-install.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/util/grub-install.c b/util/grub-install.c > >>> index a44858198..335662a58 100644 > >>> --- a/util/grub-install.c > >>> +++ b/util/grub-install.c > >>> @@ -276,7 +276,7 @@ static struct argp_option options[] = { > >>> N_("disk module to use (biosdisk or native). " > >>> "This option is only available on BIOS target."), 2}, > >>> {"no-nvram", OPTION_NO_NVRAM, 0, 0, > >>> - N_("don't update the `boot-device'/`Boot*' NVRAM variables. " > >>> + N_("don't run efibootmgr to update the `boot-device'/`Boot*' NVRAM > >>> variables. " > >>> "This option is only available on EFI and IEEE1275 targets."), 2}, > >>> > >> In case of ieee1275 this has nothing to do with efibootmgr > > > > Paul, are you going to repost the patch with relevant change in the code > > and commit message or should I fix it just before push? > > I am still thinking how to phrase it. Maybe, just add efibootmanager > after EFI? What about "don't update, e.g. using efibootmgr, the `boot-device'/`Boot*' NVRAM variables. "? Daniel