From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 6/7] drm/i915/gen11: Program the Y and UV plane for planar mode correctly. Date: Fri, 21 Sep 2018 22:01:37 +0300 Message-ID: <20180921190137.GK5565@intel.com> References: <20180921173945.6276-1-maarten.lankhorst@linux.intel.com> <20180921173945.6276-7-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 37BA86E04E for ; Fri, 21 Sep 2018 19:01:41 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180921173945.6276-7-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBTZXAgMjEsIDIwMTggYXQgMDc6Mzk6NDRQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gVGhlIFVWIHBsYW5lIGlzIHRoZSBtYXN0ZXIgcGxhbmUgdGhhdCBkb2VzIGFs bCBjb2xvciBjb3JyZWN0aW9uIGV0Yy4KPiBJdCBuZWVkcyB0byBiZSBwcm9ncmFtbWVkIHdpdGgg dGhlIGRpbWVuc2lvbnMgZm9yIGNvbG9yIHBsYW5lIDEgKFVWKS4KPiAKPiBUaGUgWSBwbGFuZSBq dXN0IGZlZWRzIHRoZSBZIHBpeGVscyB0byBpdC4gUHJvZ3JhbSB0aGUgc2NhbGVyIGZyb20gdGhl Cj4gbWFzdGVyIG9ubHksIGFuZCBzZXQgUExBTkVfQ1RMX1lVVjQyMF9ZX1BMQU5FIG9uIHRoZSBz bGF2ZSBwbGFuZS4KPiAKPiBDaGFuZ2VzIHNpbmNlIHYxOgo+IC0gTWFrZSBhIGNvbW1vbiBza2xf cHJvZ3JhbV9wbGFuZSwgYW5kIHVzZSBpdCBmb3IgYm90aCBwbGFuZSB1cGRhdGVzLgo+IAo+IFNp Z25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5p bnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggICAgIHwg IDEgKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYyB8IDUwICsrKysrKysr KysrKysrKysrKysrKy0tLS0tLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgMzggaW5zZXJ0aW9ucygr KSwgMTMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfcmVnLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gaW5kZXggYjYx NGEwNmI2NmM0Li5hMzEyOWE0YzE1Y2MgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9yZWcuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiBA QCAtNjUxMSw2ICs2NTExLDcgQEAgZW51bSB7Cj4gICNkZWZpbmUgICBQTEFORV9DVExfS0VZX0VO QUJMRV9ERVNUSU5BVElPTgkoMiA8PCAyMSkKPiAgI2RlZmluZSAgIFBMQU5FX0NUTF9PUkRFUl9C R1JYCQkJKDAgPDwgMjApCj4gICNkZWZpbmUgICBQTEFORV9DVExfT1JERVJfUkdCWAkJCSgxIDw8 IDIwKQo+ICsjZGVmaW5lICAgUExBTkVfQ1RMX1lVVjQyMF9ZX1BMQU5FCQkoMSA8PCAxOSkKPiAg I2RlZmluZSAgIFBMQU5FX0NUTF9ZVVZfVE9fUkdCX0NTQ19GT1JNQVRfQlQ3MDkJKDEgPDwgMTgp Cj4gICNkZWZpbmUgICBQTEFORV9DVExfWVVWNDIyX09SREVSX01BU0sJCSgweDMgPDwgMTYpCj4g ICNkZWZpbmUgICBQTEFORV9DVExfWVVWNDIyX1lVWVYJCQkoMCA8PCAxNikKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9zcHJpdGUuYwo+IGluZGV4IGM0ZTA1YjBiNjBiZi4uNzA4ZDJkZmQ1OWQ3IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiBAQCAtMzM5LDIzICszMzksMjMg QEAgc2tsX3Byb2dyYW1fc2NhbGVyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwK PiAgCQkgICAgICAoKGNydGNfdyArIDEpIDw8IDE2KXwoY3J0Y19oICsgMSkpOwo+ICB9Cj4gIAo+ IC12b2lkCj4gLXNrbF91cGRhdGVfcGxhbmUoc3RydWN0IGludGVsX3BsYW5lICpwbGFuZSwKPiAt CQkgY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gLQkJIGNvbnN0 IHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUpCj4gK3N0YXRpYyB2b2lkCj4g K3NrbF9wcm9ncmFtX3BsYW5lKHN0cnVjdCBpbnRlbF9wbGFuZSAqcGxhbmUsCj4gKwkJICBjb25z dCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPiArCQkgIGNvbnN0IHN0cnVj dCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUsCj4gKwkJICBpbnQgY29sb3JfcGxhbmUs IGJvb2wgc2xhdmUsIHUzMiBwbGFuZV9jdGwpCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUocGxhbmUtPmJhc2UuZGV2KTsKPiAgCWVudW0gcGxhbmVf aWQgcGxhbmVfaWQgPSBwbGFuZS0+aWQ7Cj4gIAllbnVtIHBpcGUgcGlwZSA9IHBsYW5lLT5waXBl Owo+IC0JdTMyIHBsYW5lX2N0bCA9IHBsYW5lX3N0YXRlLT5jdGw7Cj4gIAljb25zdCBzdHJ1Y3Qg ZHJtX2ludGVsX3Nwcml0ZV9jb2xvcmtleSAqa2V5ID0gJnBsYW5lX3N0YXRlLT5ja2V5Owo+IC0J dTMyIHN1cmZfYWRkciA9IHBsYW5lX3N0YXRlLT5jb2xvcl9wbGFuZVswXS5vZmZzZXQ7Cj4gLQl1 MzIgc3RyaWRlID0gc2tsX3BsYW5lX3N0cmlkZShwbGFuZV9zdGF0ZSwgMCk7Cj4gKwl1MzIgc3Vy Zl9hZGRyID0gcGxhbmVfc3RhdGUtPmNvbG9yX3BsYW5lW2NvbG9yX3BsYW5lXS5vZmZzZXQ7Cj4g Kwl1MzIgc3RyaWRlID0gc2tsX3BsYW5lX3N0cmlkZShwbGFuZV9zdGF0ZSwgY29sb3JfcGxhbmUp Owo+ICAJdTMyIGF1eF9zdHJpZGUgPSBza2xfcGxhbmVfc3RyaWRlKHBsYW5lX3N0YXRlLCAxKTsK PiAgCWludCBjcnRjX3ggPSBwbGFuZV9zdGF0ZS0+YmFzZS5kc3QueDE7Cj4gIAlpbnQgY3J0Y195 ID0gcGxhbmVfc3RhdGUtPmJhc2UuZHN0LnkxOwo+IC0JdWludDMyX3QgeCA9IHBsYW5lX3N0YXRl LT5jb2xvcl9wbGFuZVswXS54Owo+IC0JdWludDMyX3QgeSA9IHBsYW5lX3N0YXRlLT5jb2xvcl9w bGFuZVswXS55Owo+ICsJdWludDMyX3QgeCA9IHBsYW5lX3N0YXRlLT5jb2xvcl9wbGFuZVtjb2xv cl9wbGFuZV0ueDsKPiArCXVpbnQzMl90IHkgPSBwbGFuZV9zdGF0ZS0+Y29sb3JfcGxhbmVbY29s b3JfcGxhbmVdLnk7Cj4gIAl1aW50MzJfdCBzcmNfdyA9IGRybV9yZWN0X3dpZHRoKCZwbGFuZV9z dGF0ZS0+YmFzZS5zcmMpID4+IDE2Owo+ICAJdWludDMyX3Qgc3JjX2ggPSBkcm1fcmVjdF9oZWln aHQoJnBsYW5lX3N0YXRlLT5iYXNlLnNyYykgPj4gMTY7Cj4gIAlzdHJ1Y3QgaW50ZWxfcGxhbmUg KmxpbmtlZCA9IHBsYW5lX3N0YXRlLT5saW5rZWRfcGxhbmU7Cj4gQEAgLTQwOSw3ICs0MDksOSBA QCBza2xfdXBkYXRlX3BsYW5lKHN0cnVjdCBpbnRlbF9wbGFuZSAqcGxhbmUsCj4gIAo+ICAJLyog cHJvZ3JhbSBwbGFuZSBzY2FsZXIgKi8KPiAgCWlmIChwbGFuZV9zdGF0ZS0+c2NhbGVyX2lkID49 IDApIHsKPiAtCQlza2xfcHJvZ3JhbV9zY2FsZXIoZGV2X3ByaXYsIHBsYW5lLCBjcnRjX3N0YXRl LCBwbGFuZV9zdGF0ZSk7Cj4gKwkJaWYgKCFzbGF2ZSkKPiArCQkJc2tsX3Byb2dyYW1fc2NhbGVy KGRldl9wcml2LCBwbGFuZSwKPiArCQkJCQkgICBjcnRjX3N0YXRlLCBwbGFuZV9zdGF0ZSk7Cj4g IAo+ICAJCUk5MTVfV1JJVEVfRlcoUExBTkVfUE9TKHBpcGUsIHBsYW5lX2lkKSwgMCk7Cj4gIAl9 IGVsc2Ugewo+IEBAIC00MjQsNiArNDI2LDI1IEBAIHNrbF91cGRhdGVfcGxhbmUoc3RydWN0IGlu dGVsX3BsYW5lICpwbGFuZSwKPiAgCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmRldl9wcml2LT51 bmNvcmUubG9jaywgaXJxZmxhZ3MpOwo+ICB9Cj4gIAo+ICt2b2lkCj4gK3NrbF91cGRhdGVfcGxh bmUoc3RydWN0IGludGVsX3BsYW5lICpwbGFuZSwKPiArCQkgY29uc3Qgc3RydWN0IGludGVsX2Ny dGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gKwkJIGNvbnN0IHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0 ZSAqcGxhbmVfc3RhdGUpCj4gK3sKPiArCXNrbF9wcm9ncmFtX3BsYW5lKHBsYW5lLCBjcnRjX3N0 YXRlLCBwbGFuZV9zdGF0ZSwKPiArCQkJICAhIXBsYW5lX3N0YXRlLT5saW5rZWRfcGxhbmUsIGZh bHNlLAoKVGhlICEhbGlua2VkIHRoaW5nIGlzIGEgYml0IG1hZ2ljeS4gSSdkIHByb2JhYmx5IGZv cmdldCB3aGF0IGl0IG1lYW5zCmV2ZXJ5IHNpbmdsZSB0aW1lLiBTbyBJTU8gZGVzZXJ2ZXMgdG8g YmUgd3JpdHRlbiBvdXQgaW4gYSBiaXQgbW9yZQp2ZXJib3NlIHdheSBhbmQvb3IgYWNjb21wYW5p ZWQgYnkgYSBjb21tZW50LgoKPiArCQkJICBwbGFuZV9zdGF0ZS0+Y3RsKTsKPiArfQo+ICsKPiAr c3RhdGljIHZvaWQKPiAraWNsX3VwZGF0ZV9zbGF2ZShzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5l LAo+ICsJCSBjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPiArCQkg Y29uc3Qgc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZSkKPiArewo+ICsJc2ts X3Byb2dyYW1fcGxhbmUocGxhbmUsIGNydGNfc3RhdGUsIHBsYW5lX3N0YXRlLCAwLCB0cnVlLAo+ ICsJCQkgIHBsYW5lX3N0YXRlLT5jdGwgfCBQTEFORV9DVExfWVVWNDIwX1lfUExBTkUpOwoKU28g dGhhdCBvbmUgYml0IGlzIHRoZSBvbmx5IGRpZmZlcmVuY2UgKGFwYXJ0IGZyb20gdGhlIG9idmlv dXMKUExBTkVfU1VSRi9TVFJJREUvT0ZGU0VUPyBObyBuZWVkIHRvIGRlYWwgd2l0aCB0aGUgY2hy b21hIHZzLiBsdW1hIApzaXplIGRpZmZlcmVuY2UgZXRjPwoKPiArfQo+ICsKPiAgdm9pZAo+ICBz a2xfZGlzYWJsZV9wbGFuZShzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lLCBzdHJ1Y3QgaW50ZWxf Y3J0YyAqY3J0YykKPiAgewo+IEBAIC0xNzc1LDYgKzE3OTYsNyBAQCBpbnRlbF9zcHJpdGVfcGxh bmVfY3JlYXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCWNvbnN0IHVp bnQ2NF90ICptb2RpZmllcnM7Cj4gIAl1bnNpZ25lZCBpbnQgc3VwcG9ydGVkX3JvdGF0aW9uczsK PiAgCWludCBudW1fcGxhbmVfZm9ybWF0czsKPiArCWVudW0gcGxhbmVfaWQgcGxhbmVfaWQgPSBQ TEFORV9TUFJJVEUwICsgcGxhbmU7Cj4gIAlpbnQgcmV0Owo+ICAKPiAgCWludGVsX3BsYW5lID0g a3phbGxvYyhzaXplb2YoKmludGVsX3BsYW5lKSwgR0ZQX0tFUk5FTCk7Cj4gQEAgLTE3OTQsMTYg KzE4MTYsMTggQEAgaW50ZWxfc3ByaXRlX3BsYW5lX2NyZWF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYsCj4gIAkJc3RhdGUtPnNjYWxlcl9pZCA9IC0xOwo+ICAKPiAgCQlpbnRl bF9wbGFuZS0+aGFzX2NjcyA9IHNrbF9wbGFuZV9oYXNfY2NzKGRldl9wcml2LCBwaXBlLAo+IC0J CQkJCQkJIFBMQU5FX1NQUklURTAgKyBwbGFuZSk7Cj4gKwkJCQkJCQkgcGxhbmVfaWQpOwo+ICAK PiAgCQlpbnRlbF9wbGFuZS0+bWF4X3N0cmlkZSA9IHNrbF9wbGFuZV9tYXhfc3RyaWRlOwo+ICAJ CWludGVsX3BsYW5lLT51cGRhdGVfcGxhbmUgPSBza2xfdXBkYXRlX3BsYW5lOwo+ICsJCWlmIChp Y2xfaXNfbnYxMl95X3BsYW5lKHBsYW5lX2lkKSkKPiArCQkJaW50ZWxfcGxhbmUtPnVwZGF0ZV9z bGF2ZSA9IGljbF91cGRhdGVfc2xhdmU7Cj4gIAkJaW50ZWxfcGxhbmUtPmRpc2FibGVfcGxhbmUg PSBza2xfZGlzYWJsZV9wbGFuZTsKPiAgCQlpbnRlbF9wbGFuZS0+Z2V0X2h3X3N0YXRlID0gc2ts X3BsYW5lX2dldF9od19zdGF0ZTsKPiAgCQlpbnRlbF9wbGFuZS0+Y2hlY2tfcGxhbmUgPSBza2xf cGxhbmVfY2hlY2s7Cj4gIAo+ICAJCWlmIChza2xfcGxhbmVfaGFzX3BsYW5hcihkZXZfcHJpdiwg cGlwZSwKPiAtCQkJCQkgUExBTkVfU1BSSVRFMCArIHBsYW5lKSkgewo+ICsJCQkJCSBwbGFuZV9p ZCkpIHsKPiAgCQkJcGxhbmVfZm9ybWF0cyA9IHNrbF9wbGFuYXJfZm9ybWF0czsKPiAgCQkJbnVt X3BsYW5lX2Zvcm1hdHMgPSBBUlJBWV9TSVpFKHNrbF9wbGFuYXJfZm9ybWF0cyk7Cj4gIAkJfSBl bHNlIHsKPiBAQCAtMTg3Nyw3ICsxOTAxLDcgQEAgaW50ZWxfc3ByaXRlX3BsYW5lX2NyZWF0ZShz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAo+ICAJaW50ZWxfcGxhbmUtPnBp cGUgPSBwaXBlOwo+ICAJaW50ZWxfcGxhbmUtPmk5eHhfcGxhbmUgPSBwbGFuZTsKPiAtCWludGVs X3BsYW5lLT5pZCA9IFBMQU5FX1NQUklURTAgKyBwbGFuZTsKPiArCWludGVsX3BsYW5lLT5pZCA9 IHBsYW5lX2lkOwo+ICAJaW50ZWxfcGxhbmUtPmZyb250YnVmZmVyX2JpdCA9IElOVEVMX0ZST05U QlVGRkVSKHBpcGUsIGludGVsX3BsYW5lLT5pZCk7Cj4gIAo+ICAJcG9zc2libGVfY3J0Y3MgPSAo MSA8PCBwaXBlKTsKPiAtLSAKPiAyLjE4LjAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==