From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [-next] EDAC: Remove set but not used variable 'type' From: "Luck, Tony" Message-Id: <20180925171539.GA16543@agluck-desk> Date: Tue, 25 Sep 2018 10:15:39 -0700 To: Borislav Petkov Cc: YueHaibing , Mauro Carvalho Chehab , linux-edac@vger.kernel.org, kernel-janitors@vger.kernel.org List-ID: T24gVHVlLCBTZXAgMjUsIDIwMTggYXQgMTI6MTE6MDdQTSArMDIwMCwgQm9yaXNsYXYgUGV0a292 IHdyb3RlOgo+IE9uIFR1ZSwgU2VwIDI1LCAyMDE4IGF0IDAyOjM2OjA0QU0gKzAwMDAsIFl1ZUhh aWJpbmcgd3JvdGU6Cj4gPiAgCWlmICh1bmNvcnJlY3RlZF9lcnJvcikgewo+ID4gLQkJaWYgKHJp cHYpIHsKPiA+IC0JCQl0eXBlID0gIkZBVEFMIjsKPiA+ICsJCWlmIChyaXB2KQo+ID4gIAkJCXRw X2V2ZW50ID0gSFdfRVZFTlRfRVJSX0ZBVEFMOwo+ID4gLQkJfSBlbHNlIHsKPiA+IC0JCQl0eXBl ID0gIk5PTl9GQVRBTCI7Cj4gPiArCQllbHNlCj4gPiAgCQkJdHBfZXZlbnQgPSBIV19FVkVOVF9F UlJfVU5DT1JSRUNURUQ7Cj4gPiAtCQl9Cj4gPiAgCX0gZWxzZSB7Cj4gPiAtCQl0eXBlID0gIkNP UlJFQ1RFRCI7Cj4gPiAgCQl0cF9ldmVudCA9IEhXX0VWRU5UX0VSUl9DT1JSRUNURUQ7Cj4gPiAg CX0KPiAKPiBMb29rcyBsaWtlIHRoaXMgQHR5cGUgdGhpbmcgd2FzIG5ldmVyIHVzZWQuIFRvbnks IGRpZCB5b3Ugd2FudCB0byB1c2UgaXQKPiBmb3Igc29tZXRoaW5nPwoKVGhhdCBibG9jayBvZiBj b2RlIGxvb2tzIHRvIGhhdmUgYmVlbiBwYXN0ZWQgZnJvbSBzYl9lZGFjLmMsIHNvIGxpa2VseQpu ZWVkIHRoZSBzYW1lIGZpeCB0aGVyZS4KCkl0IGFsc28gbG9va3MgdG8gYmUgd3JvbmcuIFNheWlu ZyAiRkFUQUwiIGlmIG1jZ3N0YXR1cy5yaXB2IGlzIHNldApsb29rcyB3cm9uZyAoYW5kIGluY29t cGxldGUpLiBJZiBSSVBWIGlzICpOT1QqIHNldCwgdGhlbiB0aGlzIGlzIGZhdGFsLgpCdXQgaWYg aXQgaXMgc2V0LCB0aGVuIHdlIHNob3VsZCBiZSBsb29raW5nIGF0IG90aGVyIGJpdHMgKGxpa2Ug UENDCmFuZCBBUikgLi4uIG9yIG1heWJlIGp1c3QgY2FsbGluZyBtY2Vfc2V2ZXJpdHkoKT8KClBl cmhhcHMgYSBtb290IHBvaW50IHRob3VnaC4gSWYgdGhlIGVycm9yIGlzIGZhdGFsLCB0aGVuIHdl J2xsIHBhbmljCmluc3RlYWQgb2YgY2FsbGluZyB0aGUgRURBQyBkcml2ZXIuCgotVG9ueQo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luck, Tony" Date: Tue, 25 Sep 2018 17:15:39 +0000 Subject: Re: [PATCH -next] EDAC: Remove set but not used variable 'type' Message-Id: <20180925171539.GA16543@agluck-desk> List-Id: References: <1537842964-109749-1-git-send-email-yuehaibing@huawei.com> In-Reply-To: <1537842964-109749-1-git-send-email-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Borislav Petkov Cc: YueHaibing , Mauro Carvalho Chehab , linux-edac@vger.kernel.org, kernel-janitors@vger.kernel.org On Tue, Sep 25, 2018 at 12:11:07PM +0200, Borislav Petkov wrote: > On Tue, Sep 25, 2018 at 02:36:04AM +0000, YueHaibing wrote: > > if (uncorrected_error) { > > - if (ripv) { > > - type = "FATAL"; > > + if (ripv) > > tp_event = HW_EVENT_ERR_FATAL; > > - } else { > > - type = "NON_FATAL"; > > + else > > tp_event = HW_EVENT_ERR_UNCORRECTED; > > - } > > } else { > > - type = "CORRECTED"; > > tp_event = HW_EVENT_ERR_CORRECTED; > > } > > Looks like this @type thing was never used. Tony, did you want to use it > for something? That block of code looks to have been pasted from sb_edac.c, so likely need the same fix there. It also looks to be wrong. Saying "FATAL" if mcgstatus.ripv is set looks wrong (and incomplete). If RIPV is *NOT* set, then this is fatal. But if it is set, then we should be looking at other bits (like PCC and AR) ... or maybe just calling mce_severity()? Perhaps a moot point though. If the error is fatal, then we'll panic instead of calling the EDAC driver. -Tony