From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CA0EC43382 for ; Tue, 25 Sep 2018 17:50:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1993F20896 for ; Tue, 25 Sep 2018 17:50:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1993F20896 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727229AbeIYX7C (ORCPT ); Tue, 25 Sep 2018 19:59:02 -0400 Received: from mga14.intel.com ([192.55.52.115]:28323 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725918AbeIYX7C (ORCPT ); Tue, 25 Sep 2018 19:59:02 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2018 10:50:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,303,1534834800"; d="scan'208";a="73625962" Received: from agluck-desk.sc.intel.com (HELO agluck-desk) ([10.3.52.160]) by fmsmga008.fm.intel.com with ESMTP; 25 Sep 2018 10:50:23 -0700 Date: Tue, 25 Sep 2018 10:50:23 -0700 From: "Luck, Tony" To: Borislav Petkov Cc: Justin Ernst , russ.anderson@hpe.com, Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Raise maximum number of memory controllers Message-ID: <20180925175023.GA16725@agluck-desk> References: <20180925143449.284634-1-justin.ernst@hpe.com> <20180925152659.GE23986@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180925152659.GE23986@zn.tnic> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 25, 2018 at 05:26:59PM +0200, Borislav Petkov wrote: > On Tue, Sep 25, 2018 at 09:34:49AM -0500, Justin Ernst wrote: > > We observe an oops in the skx_edac module during boot. > > Examining /var/log/messages: > > [ 3401.985757] EDAC MC0: Giving out device to module skx_edac controller Skylake Socket#0 IMC#0 > > [ 3401.985887] EDAC MC1: Giving out device to module skx_edac controller Skylake Socket#0 IMC#1 > > [ 3401.986014] EDAC MC2: Giving out device to module skx_edac controller Skylake Socket#1 IMC#0 > > ... > > [ 3401.987318] EDAC MC13: Giving out device to module skx_edac controller Skylake Socket#0 IMC#1 > > [ 3401.987435] EDAC MC14: Giving out device to module skx_edac controller Skylake Socket#1 IMC#0 > > [ 3401.987556] EDAC MC15: Giving out device to module skx_edac controller Skylake Socket#1 IMC#1 > > [ 3401.987579] Too many memory controllers: 16 > > [ 3402.042614] EDAC MC: Removed device 0 for skx_edac Skylake Socket#0 IMC#0 > > > > We observe there are two memory controllers per socket, with a limit of 16. > > Raise the maximum number of memory controllers from 16 to 2 * MAX_NUMNODES (1024). > > Tony, > > can we read that out from the hardware instead of having this silly > static number? > > Leaving in the rest. There are way too many places where we use the identifier "bus" in the edac core and drivers. But I'm not sure that we need a static array mc_bus[EDAC_MAX_MCS]. Why can't we: - mci->bus = &mc_bus[mci->mc_idx]; + mci->bus = kmalloc(sizeof *(mci->bus), GFP_KERNEL); and then figure out where to kfree(mci->bus) on driver removal? Do we every do arithmetic on different mci->bus pointers that assume they are all part of a single array? -Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: Raise maximum number of memory controllers From: "Luck, Tony" Message-Id: <20180925175023.GA16725@agluck-desk> Date: Tue, 25 Sep 2018 10:50:23 -0700 To: Borislav Petkov Cc: Justin Ernst , russ.anderson@hpe.com, Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gVHVlLCBTZXAgMjUsIDIwMTggYXQgMDU6MjY6NTlQTSArMDIwMCwgQm9yaXNsYXYgUGV0a292 IHdyb3RlOgo+IE9uIFR1ZSwgU2VwIDI1LCAyMDE4IGF0IDA5OjM0OjQ5QU0gLTA1MDAsIEp1c3Rp biBFcm5zdCB3cm90ZToKPiA+IFdlIG9ic2VydmUgYW4gb29wcyBpbiB0aGUgc2t4X2VkYWMgbW9k dWxlIGR1cmluZyBib290Lgo+ID4gRXhhbWluaW5nIC92YXIvbG9nL21lc3NhZ2VzOgo+ID4gWyAz NDAxLjk4NTc1N10gRURBQyBNQzA6IEdpdmluZyBvdXQgZGV2aWNlIHRvIG1vZHVsZSBza3hfZWRh YyBjb250cm9sbGVyIFNreWxha2UgU29ja2V0IzAgSU1DIzAKPiA+IFsgMzQwMS45ODU4ODddIEVE QUMgTUMxOiBHaXZpbmcgb3V0IGRldmljZSB0byBtb2R1bGUgc2t4X2VkYWMgY29udHJvbGxlciBT a3lsYWtlIFNvY2tldCMwIElNQyMxCj4gPiBbIDM0MDEuOTg2MDE0XSBFREFDIE1DMjogR2l2aW5n IG91dCBkZXZpY2UgdG8gbW9kdWxlIHNreF9lZGFjIGNvbnRyb2xsZXIgU2t5bGFrZSBTb2NrZXQj MSBJTUMjMAo+ID4gLi4uCj4gPiBbIDM0MDEuOTg3MzE4XSBFREFDIE1DMTM6IEdpdmluZyBvdXQg ZGV2aWNlIHRvIG1vZHVsZSBza3hfZWRhYyBjb250cm9sbGVyIFNreWxha2UgU29ja2V0IzAgSU1D IzEKPiA+IFsgMzQwMS45ODc0MzVdIEVEQUMgTUMxNDogR2l2aW5nIG91dCBkZXZpY2UgdG8gbW9k dWxlIHNreF9lZGFjIGNvbnRyb2xsZXIgU2t5bGFrZSBTb2NrZXQjMSBJTUMjMAo+ID4gWyAzNDAx Ljk4NzU1Nl0gRURBQyBNQzE1OiBHaXZpbmcgb3V0IGRldmljZSB0byBtb2R1bGUgc2t4X2VkYWMg Y29udHJvbGxlciBTa3lsYWtlIFNvY2tldCMxIElNQyMxCj4gPiBbIDM0MDEuOTg3NTc5XSBUb28g bWFueSBtZW1vcnkgY29udHJvbGxlcnM6IDE2Cj4gPiBbIDM0MDIuMDQyNjE0XSBFREFDIE1DOiBS ZW1vdmVkIGRldmljZSAwIGZvciBza3hfZWRhYyBTa3lsYWtlIFNvY2tldCMwIElNQyMwCj4gPiAK PiA+IFdlIG9ic2VydmUgdGhlcmUgYXJlIHR3byBtZW1vcnkgY29udHJvbGxlcnMgcGVyIHNvY2tl dCwgd2l0aCBhIGxpbWl0IG9mIDE2Lgo+ID4gUmFpc2UgdGhlIG1heGltdW0gbnVtYmVyIG9mIG1l bW9yeSBjb250cm9sbGVycyBmcm9tIDE2IHRvIDIgKiBNQVhfTlVNTk9ERVMgKDEwMjQpLgo+IAo+ IFRvbnksCj4gCj4gY2FuIHdlIHJlYWQgdGhhdCBvdXQgZnJvbSB0aGUgaGFyZHdhcmUgaW5zdGVh ZCBvZiBoYXZpbmcgdGhpcyBzaWxseQo+IHN0YXRpYyBudW1iZXI/Cj4gCj4gTGVhdmluZyBpbiB0 aGUgcmVzdC4KClRoZXJlIGFyZSB3YXkgdG9vIG1hbnkgcGxhY2VzIHdoZXJlIHdlIHVzZSB0aGUg aWRlbnRpZmllciAiYnVzIgppbiB0aGUgZWRhYyBjb3JlIGFuZCBkcml2ZXJzLiBCdXQgSSdtIG5v dCBzdXJlIHRoYXQgd2UgbmVlZCBhCnN0YXRpYyBhcnJheSBtY19idXNbRURBQ19NQVhfTUNTXS4K CldoeSBjYW4ndCB3ZToKCgotCW1jaS0+YnVzID0gJm1jX2J1c1ttY2ktPm1jX2lkeF07CisJbWNp LT5idXMgPSBrbWFsbG9jKHNpemVvZiAqKG1jaS0+YnVzKSwgR0ZQX0tFUk5FTCk7CgphbmQgdGhl biBmaWd1cmUgb3V0IHdoZXJlIHRvIGtmcmVlKG1jaS0+YnVzKSBvbiBkcml2ZXIgcmVtb3ZhbD8K CkRvIHdlIGV2ZXJ5IGRvIGFyaXRobWV0aWMgb24gZGlmZmVyZW50IG1jaS0+YnVzIHBvaW50ZXJz IHRoYXQKYXNzdW1lIHRoZXkgYXJlIGFsbCBwYXJ0IG9mIGEgc2luZ2xlIGFycmF5PwoKLVRvbnkK