From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v3 1/8] drm/i915: Make sure fb gtt offsets stay within 32bits Date: Wed, 26 Sep 2018 12:27:40 +0300 Message-ID: <20180926092740.GO9144@intel.com> References: <20180925193714.25280-1-ville.syrjala@linux.intel.com> <20180925193714.25280-2-ville.syrjala@linux.intel.com> <153790738445.21139.17414049229386732949@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id DFE2A89E7C for ; Wed, 26 Sep 2018 09:29:54 +0000 (UTC) Content-Disposition: inline In-Reply-To: <153790738445.21139.17414049229386732949@skylake-alporthouse-com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBTZXAgMjUsIDIwMTggYXQgMDk6Mjk6NDRQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgVmlsbGUgU3lyamFsYSAoMjAxOC0wOS0yNSAyMDozNzowNykKPiA+IEZy b206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAK PiA+IExldCdzIHRyeSB0byBtYWtlIHN1cmUgdGhlIGZiIG9mZnNldCBjb21wdXRhdGlvbnMgbmV2 ZXIgaGl0Cj4gPiBhbiBpbnRlZ2VyIG92ZXJmbG93IGJ5IG1ha2luZyBzdXJlIHRoZSBlbnRpcmUg ZmIgc3RheXMKPiA+IGJlbG93IDMyYml0cy4gZnJhbWVidWZmZXJfY2hlY2soKSBpbiB0aGUgY29y ZSBhbHJlYWR5IGRvZXMKPiA+IHRoZSBzYW1lIGNoZWNrLCBidXQgYXMgaXQgZG9lc24ndCBrbm93 IGFib3V0IHRpbGluZyBzb21lIHRoaW5ncwo+ID4gY2FuIHNsaXAgdGhyb3VnaC4gUmVwZWF0IHRo ZSBjaGVjayBpbiB0aGUgZHJpdmVyIHdpdGggdGlsaW5nCj4gPiB0YWtlbiBpbnRvIGFjY291bnQu Cj4gPiAKPiA+IHYyOiBVc2UgYWRkX292ZXJmbG93cygpIGFmdGVyIG1hc3NhZ2luZyBpdCB0byB3 b3JrIGZvciBtZSAoQ2hyaXMpCj4gCj4gT2gsIGl0IGhhZCBmYWxsZW4gb3V0IG9mIHVzZS4KPiAg Cj4gPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXgu aW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV91dGlscy5o ICAgIHwgIDggKysrKy0tLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmMgfCAxOCArKysrKysrKysrKysrKysrKy0KPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDIxIGluc2Vy dGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X3V0aWxzLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3V0aWxz LmgKPiA+IGluZGV4IDM5NWRkMjUxMTU2OC4uYzQzZWM5OTNmYTkwIDEwMDY0NAo+ID4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV91dGlscy5oCj4gPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X3V0aWxzLmgKPiA+IEBAIC00NCwxMyArNDQsMTMgQEAKPiA+ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgX19zdHJpbmdpZnkoeCksIChsb25nKSh4KSkKPiA+ICAKPiA+ ICAjaWYgZGVmaW5lZChHQ0NfVkVSU0lPTikgJiYgR0NDX1ZFUlNJT04gPj0gNzAwMDAKPiA+IC0j ZGVmaW5lIGFkZF9vdmVyZmxvd3MoQSwgQikgXAo+ID4gLSAgICAgICBfX2J1aWx0aW5fYWRkX292 ZXJmbG93X3AoKEEpLCAoQiksICh0eXBlb2YoKEEpICsgKEIpKSkwKQo+ID4gKyNkZWZpbmUgYWRk X292ZXJmbG93cyhBLCBCLCBDKSBcCj4gPiArICAgICAgIF9fYnVpbHRpbl9hZGRfb3ZlcmZsb3df cCgoQSksIChCKSwgKEMpKQo+ID4gICNlbHNlCj4gPiAtI2RlZmluZSBhZGRfb3ZlcmZsb3dzKEEs IEIpICh7IFwKPiA+ICsjZGVmaW5lIGFkZF9vdmVyZmxvd3MoQSwgQiwgQykgKHsgXAo+ID4gICAg ICAgICB0eXBlb2YoQSkgYSA9IChBKTsgXAo+ID4gICAgICAgICB0eXBlb2YoQikgYiA9IChCKTsg XAo+ID4gLSAgICAgICBhICsgYiA8IGE7IFwKPiA+ICsgICAgICAgKHR5cGVvZihDKSkoYSArIGIp IDwgYTsgXAo+ID4gIH0pCj4gPiAgI2VuZGlmCj4gPiAgCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jCj4gPiBpbmRleCA0YzVjMmIzOWU2NWMuLmEzYWUyNGUwMzMxNiAxMDA2NDQK PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBAQCAtMjQwMCwxMCArMjQw MCwyNiBAQCBzdGF0aWMgaW50IGludGVsX2ZiX29mZnNldF90b194eShpbnQgKngsIGludCAqeSwK PiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCBjb2xvcl9wbGFuZSkKPiA+ ICB7Cj4gPiAgICAgICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5 MTUoZmItPmRldik7Cj4gPiArICAgICAgIHVuc2lnbmVkIGludCBoZWlnaHQ7Cj4gPiAgCj4gPiAg ICAgICAgIGlmIChmYi0+bW9kaWZpZXIgIT0gRFJNX0ZPUk1BVF9NT0RfTElORUFSICYmCj4gPiAt ICAgICAgICAgICBmYi0+b2Zmc2V0c1tjb2xvcl9wbGFuZV0gJSBpbnRlbF90aWxlX3NpemUoZGV2 X3ByaXYpKQo+ID4gKyAgICAgICAgICAgZmItPm9mZnNldHNbY29sb3JfcGxhbmVdICUgaW50ZWxf dGlsZV9zaXplKGRldl9wcml2KSkgewo+ID4gKyAgICAgICAgICAgICAgIERSTV9ERUJVR19LTVMo Ik1pc2FsaWduZWQgb2Zmc2V0IDB4JTA4eCBmb3IgY29sb3IgcGxhbmUgJWRcbiIsCj4gPiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBmYi0+b2Zmc2V0c1tjb2xvcl9wbGFuZV0sIGNvbG9y X3BsYW5lKTsKPiA+ICAgICAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKPiA+ICsgICAgICAg fQo+ID4gKwo+ID4gKyAgICAgICBoZWlnaHQgPSBkcm1fZnJhbWVidWZmZXJfcGxhbmVfaGVpZ2h0 KGZiLT5oZWlnaHQsIGZiLCBjb2xvcl9wbGFuZSk7Cj4gPiArICAgICAgIGhlaWdodCA9IEFMSUdO KGhlaWdodCwgaW50ZWxfdGlsZV9oZWlnaHQoZmIsIGNvbG9yX3BsYW5lKSk7Cj4gPiArCj4gPiAr ICAgICAgIC8qIENhdGNoIHBvdGVudGlhbCBvdmVyZmxvd3MgZWFybHkgKi8KPiA+ICsgICAgICAg aWYgKGFkZF9vdmVyZmxvd3MobXVsX3UzMl91MzIoaGVpZ2h0LCBmYi0+cGl0Y2hlc1tjb2xvcl9w bGFuZV0pLAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICBmYi0+b2Zmc2V0c1tjb2xvcl9w bGFuZV0sICh1MzIpMCkpIHsKPiAKPiBTaG91bGQgd2UganVzdCBwYXNzIHR5cGU/IEF0bSB3ZSBh cmVuJ3QgdXNpbmcgdGhlIHZhbHVlIGZvciBhbnl0aGluZy4KPiBUaGVuIGl0IHdvdWxkIGJlIGFk ZF9vdmVyZmxvd3NfdChhLCBiLCBUKSB3aXRoIHRoZSBvYnZpb3VzIHdyYXBwaW5nIGZvcgo+IGFk ZF9vdmVyZmxvd3MoYSwgYikuIEFsdGhvdWdoIHRvIGJlIGNvbnNpc3RlbnQgd2l0aCBtaW5fdCwg cGVyaGFwcwo+IGFkZF9vdmVyZmxvd3NfdChULCBhLCBiKS4KCkluZGVlZCwgdGhhdCBkb2VzIHNl ZW0gYSBiaXQgbW9yZSBjb25zaXN0ZW50IHdpdGggZXhpc3Rpbmcgc3R1ZmYuCgotLSAKVmlsbGUg U3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo=