From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 345CBC43382 for ; Wed, 26 Sep 2018 10:36:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EDB7C20843 for ; Wed, 26 Sep 2018 10:36:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EDB7C20843 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727620AbeIZQsT (ORCPT ); Wed, 26 Sep 2018 12:48:19 -0400 Received: from mail.bootlin.com ([62.4.15.54]:41489 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726593AbeIZQsT (ORCPT ); Wed, 26 Sep 2018 12:48:19 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 10AEC20711; Wed, 26 Sep 2018 12:35:58 +0200 (CEST) Received: from localhost (nat-240.udc.es [193.144.61.240]) by mail.bootlin.com (Postfix) with ESMTPSA id 89CF02074F; Wed, 26 Sep 2018 12:35:47 +0200 (CEST) From: maxime.ripard@bootlin.com Date: Wed, 26 Sep 2018 12:35:47 +0200 To: Laurent Pinchart Cc: Yong Deng , Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Chen-Yu Tsai , "\"David S. Miller" , Greg Kroah-Hartman , Andrew Morton , Arnd Bergmann , Hans Verkuil , Geert Uytterhoeven , Jacob Chen , Neil Armstrong , Thierry Reding , Philipp Zabel , Todor Tomov , Sakari Ailus , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v11 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI) Message-ID: <20180926103547.5ubb6xjkl7xngmfg@flea> References: <1537951204-24672-1-git-send-email-yong.deng@magewell.com> <7197338.mhOH8fQaEM@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7197338.mhOH8fQaEM@avalon> gFrom: Maxime Ripard User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 26, 2018 at 01:19:34PM +0300, Laurent Pinchart wrote: > > +Endpoint node properties for CSI1 > > +--------------------------------- > > Should you list the CSI0 properties as well ? As the driver in patch 2/2 > doesn't support the CSI-2 interface I assume you have left out CSI0 for now, > but it should still be listed in the bindings. I'm fine with fixing this as a > follow-up patch to avoid missing the v4.20 merge window, but if you end up > resubmitting the series, could you please address the problem ? That driver is not available, and the documentation isn't either, so there's no easy way to tell which properties are going to be needed before doing the actual work of reverse engineering it and writing a driver for it. Unfortunately... Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org Subject: Re: [PATCH v11 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI) Date: Wed, 26 Sep 2018 12:35:47 +0200 Message-ID: <20180926103547.5ubb6xjkl7xngmfg@flea> References: <1537951204-24672-1-git-send-email-yong.deng@magewell.com> <7197338.mhOH8fQaEM@avalon> Reply-To: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <7197338.mhOH8fQaEM@avalon> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Laurent Pinchart Cc: Yong Deng , Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Chen-Yu Tsai , "\"David S. Miller" , Greg Kroah-Hartman , Andrew Morton , Arnd Bergmann , Hans Verkuil , Geert Uytterhoeven , Jacob Chen , Neil Armstrong , Thierry Reding , Philipp Zabel , Todor Tomov , Sakari Ailus , linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, Sep 26, 2018 at 01:19:34PM +0300, Laurent Pinchart wrote: > > +Endpoint node properties for CSI1 > > +--------------------------------- > > Should you list the CSI0 properties as well ? As the driver in patch 2/2 > doesn't support the CSI-2 interface I assume you have left out CSI0 for now, > but it should still be listed in the bindings. I'm fine with fixing this as a > follow-up patch to avoid missing the v4.20 merge window, but if you end up > resubmitting the series, could you please address the problem ? That driver is not available, and the documentation isn't either, so there's no easy way to tell which properties are going to be needed before doing the actual work of reverse engineering it and writing a driver for it. Unfortunately... Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@bootlin.com (maxime.ripard at bootlin.com) Date: Wed, 26 Sep 2018 12:35:47 +0200 Subject: [PATCH v11 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI) In-Reply-To: <7197338.mhOH8fQaEM@avalon> References: <1537951204-24672-1-git-send-email-yong.deng@magewell.com> <7197338.mhOH8fQaEM@avalon> Message-ID: <20180926103547.5ubb6xjkl7xngmfg@flea> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Sep 26, 2018 at 01:19:34PM +0300, Laurent Pinchart wrote: > > +Endpoint node properties for CSI1 > > +--------------------------------- > > Should you list the CSI0 properties as well ? As the driver in patch 2/2 > doesn't support the CSI-2 interface I assume you have left out CSI0 for now, > but it should still be listed in the bindings. I'm fine with fixing this as a > follow-up patch to avoid missing the v4.20 merge window, but if you end up > resubmitting the series, could you please address the problem ? That driver is not available, and the documentation isn't either, so there's no easy way to tell which properties are going to be needed before doing the actual work of reverse engineering it and writing a driver for it. Unfortunately... Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com