From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B33BCC43382 for ; Wed, 26 Sep 2018 16:04:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63DDB214FE for ; Wed, 26 Sep 2018 16:04:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="OG8jmaxH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63DDB214FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728351AbeIZWRx (ORCPT ); Wed, 26 Sep 2018 18:17:53 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:39006 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726937AbeIZWRx (ORCPT ); Wed, 26 Sep 2018 18:17:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Q8nj6Cz6qYjqMbSyswMYR+TkejBFwd3zGhfhneJ7gKk=; b=OG8jmaxHJTAn33+MPYqCXltHZ BDEqhf1njkQ9uDI6VYHTud8lgM5Pf5xuhBQMHOLHHboKZZ+6EfqjwnvuQaorvyRvhlgrRViiApIbE 0dk+NTqdot1HZvkQP38c0waInHYUnrS26FwiR3hMo7XF45u3SdckoBxhhFeML9/bHCN4bcT2C080d kIGR7x9ffoBiuVwgirV4nfgShs2VodXudbs3WAog9zmf9WKOQQf5hRbooJ99QAJtzeq64Lxj4hujx D+R4M8hdbPrdLb6uvngskzTNK8hEVgBDGe8GUTfzgfTj96l5vnHCJzUPIO9/vkoeEFcDP1b4OgvaI sJ6bwaHNQ==; Received: from 177.43.23.201.dynamic.adsl.gvt.net.br ([177.43.23.201] helo=coco.lan) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1g5CHz-0005Aq-B2; Wed, 26 Sep 2018 16:04:07 +0000 Date: Wed, 26 Sep 2018 13:03:40 -0300 From: Mauro Carvalho Chehab To: Borislav Petkov Cc: "Luck, Tony" , Greg KH , Justin Ernst , russ.anderson@hpe.com, Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Aristeu Rozanski Filho Subject: Re: [PATCH] Raise maximum number of memory controllers Message-ID: <20180926130340.6b22918b@coco.lan> In-Reply-To: <20180926152752.GG5584@zn.tnic> References: <20180925143449.284634-1-justin.ernst@hpe.com> <20180925152659.GE23986@zn.tnic> <20180925175023.GA16725@agluck-desk> <20180925180458.GG23986@zn.tnic> <20180926093510.GA5584@zn.tnic> <20180926152752.GG5584@zn.tnic> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, 26 Sep 2018 17:27:52 +0200 Borislav Petkov escreveu: > On Wed, Sep 26, 2018 at 11:35:11AM +0200, Borislav Petkov wrote: > > * or Greg coming and saying, you're using bus_type all wrong and you > > shouldn't and you should remove it completely! :-) > > Yap, and so he did! :-) > > It looks like we can remove the whole per-MC bus thing, see below. I guess this is/was needed to create things like this: lrwxrwxrwx 1 root root 0 set 26 05:24 /sys/bus/edac/devices/mc -> ../../../devices/system/edac/mc (I don't test this logic for a while). > Patch > seems to work here and grepping sysfs hierarchy before and after: > > find /sys/ | grep -i edac > ... > > doesn't show any differences. > > Tony, I'd appreciate running this on one of your big boxes to check > nothing is missing in sysfs... There are a few EDAC drivers for old server chipsets that create error report mechanisms for PCI bus controllers. I don't remember the specifics anymore. I *suspect* those are the drivers that do such usage: $ git grep -l edac_pci_add_device drivers/edac/amd8111_edac.c drivers/edac/amd8131_edac.c drivers/edac/edac_pci.c drivers/edac/edac_pci.h drivers/edac/mpc85xx_edac.c drivers/edac/mv64x60_edac.c drivers/edac/octeon_edac-pci.c None of them use Intel chipsets. Last time I tried to test it (more than 5 years ago), it was hard to find such systems at the labs I had access on that time. Anyway, as this is a more unusual usage of EDAC API, it could be worth to double-check if this patch won't break it, maybe doing some test on such machines before/after this patch in order to verify that this won't cause regressions there. In thesis, it shouldn't affect, as the changes are happening at edac_mc*.c, but I won't doubt that it might have a hidden dependency somewhere. > > Thx. > > --- > drivers/edac/edac_mc.c | 9 +-------- > drivers/edac/edac_mc_sysfs.c | 30 ++---------------------------- > include/linux/edac.h | 6 ------ > 3 files changed, 3 insertions(+), 42 deletions(-) > > diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c > index 7d3edd713932..13594ffadcb3 100644 > --- a/drivers/edac/edac_mc.c > +++ b/drivers/edac/edac_mc.c > @@ -55,8 +55,6 @@ static LIST_HEAD(mc_devices); > */ > static const char *edac_mc_owner; > > -static struct bus_type mc_bus[EDAC_MAX_MCS]; > - > int edac_get_report_status(void) > { > return edac_report; > @@ -716,11 +714,6 @@ int edac_mc_add_mc_with_groups(struct mem_ctl_info *mci, > int ret = -EINVAL; > edac_dbg(0, "\n"); > > - if (mci->mc_idx >= EDAC_MAX_MCS) { > - pr_warn_once("Too many memory controllers: %d\n", mci->mc_idx); > - return -ENODEV; > - } > - > #ifdef CONFIG_EDAC_DEBUG > if (edac_debug_level >= 3) > edac_mc_dump_mci(mci); > @@ -760,7 +753,7 @@ int edac_mc_add_mc_with_groups(struct mem_ctl_info *mci, > /* set load time so that error rate can be tracked */ > mci->start_time = jiffies; > > - mci->bus = &mc_bus[mci->mc_idx]; > + mci->bus = edac_get_sysfs_subsys(); > > if (edac_create_sysfs_mci_device(mci, groups)) { > edac_mc_printk(mci, KERN_WARNING, > diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c > index 20374b8248f0..2ca2012f2857 100644 > --- a/drivers/edac/edac_mc_sysfs.c > +++ b/drivers/edac/edac_mc_sysfs.c > @@ -914,27 +914,8 @@ static const struct device_type mci_attr_type = { > int edac_create_sysfs_mci_device(struct mem_ctl_info *mci, > const struct attribute_group **groups) > { > - char *name; > int i, err; > > - /* > - * The memory controller needs its own bus, in order to avoid > - * namespace conflicts at /sys/bus/edac. > - */ > - name = kasprintf(GFP_KERNEL, "mc%d", mci->mc_idx); > - if (!name) > - return -ENOMEM; > - > - mci->bus->name = name; > - > - edac_dbg(0, "creating bus %s\n", mci->bus->name); > - > - err = bus_register(mci->bus); > - if (err < 0) { > - kfree(name); > - return err; > - } > - > /* get the /sys/devices/system/edac subsys reference */ > mci->dev.type = &mci_attr_type; > device_initialize(&mci->dev); > @@ -950,7 +931,7 @@ int edac_create_sysfs_mci_device(struct mem_ctl_info *mci, > err = device_add(&mci->dev); > if (err < 0) { > edac_dbg(1, "failure: create device %s\n", dev_name(&mci->dev)); > - goto fail_unregister_bus; > + goto out; > } > > /* > @@ -998,10 +979,8 @@ int edac_create_sysfs_mci_device(struct mem_ctl_info *mci, > device_unregister(&dimm->dev); > } > device_unregister(&mci->dev); > -fail_unregister_bus: > - bus_unregister(mci->bus); > - kfree(name); > > +out: > return err; > } > > @@ -1032,13 +1011,8 @@ void edac_remove_sysfs_mci_device(struct mem_ctl_info *mci) > > void edac_unregister_sysfs(struct mem_ctl_info *mci) > { > - struct bus_type *bus = mci->bus; > - const char *name = mci->bus->name; > - > edac_dbg(1, "Unregistering device %s\n", dev_name(&mci->dev)); > device_unregister(&mci->dev); > - bus_unregister(bus); > - kfree(name); > } > > static void mc_attr_release(struct device *dev) > diff --git a/include/linux/edac.h b/include/linux/edac.h > index a45ce1f84bfc..dd8d006f1837 100644 > --- a/include/linux/edac.h > +++ b/include/linux/edac.h > @@ -668,10 +668,4 @@ struct mem_ctl_info { > bool fake_inject_ue; > u16 fake_inject_count; > }; > - > -/* > - * Maximum number of memory controllers in the coherent fabric. > - */ > -#define EDAC_MAX_MCS 16 > - > #endif Thanks, Mauro From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: Raise maximum number of memory controllers From: Mauro Carvalho Chehab Message-Id: <20180926130340.6b22918b@coco.lan> Date: Wed, 26 Sep 2018 13:03:40 -0300 To: Borislav Petkov Cc: "Luck, Tony" , Greg KH , Justin Ernst , russ.anderson@hpe.com, Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Aristeu Rozanski Filho List-ID: RW0gV2VkLCAyNiBTZXAgMjAxOCAxNzoyNzo1MiArMDIwMApCb3Jpc2xhdiBQZXRrb3YgPGJwQGFs aWVuOC5kZT4gZXNjcmV2ZXU6Cgo+IE9uIFdlZCwgU2VwIDI2LCAyMDE4IGF0IDExOjM1OjExQU0g KzAyMDAsIEJvcmlzbGF2IFBldGtvdiB3cm90ZToKPiA+ICogb3IgR3JlZyBjb21pbmcgYW5kIHNh eWluZywgeW91J3JlIHVzaW5nIGJ1c190eXBlIGFsbCB3cm9uZyBhbmQgeW91Cj4gPiBzaG91bGRu J3QgYW5kIHlvdSBzaG91bGQgcmVtb3ZlIGl0IGNvbXBsZXRlbHkhIDotKSAgCj4gCj4gWWFwLCBh bmQgc28gaGUgZGlkISA6LSkKPiAKPiBJdCBsb29rcyBsaWtlIHdlIGNhbiByZW1vdmUgdGhlIHdo b2xlIHBlci1NQyBidXMgdGhpbmcsIHNlZSBiZWxvdy4gCgpJIGd1ZXNzIHRoaXMgaXMvd2FzIG5l ZWRlZCB0byBjcmVhdGUgdGhpbmdzIGxpa2UgdGhpczoKCglscnd4cnd4cnd4IDEgcm9vdCByb290 IDAgc2V0IDI2IDA1OjI0IC9zeXMvYnVzL2VkYWMvZGV2aWNlcy9tYyAtPiAuLi8uLi8uLi9kZXZp Y2VzL3N5c3RlbS9lZGFjL21jCgooSSBkb24ndCB0ZXN0IHRoaXMgbG9naWMgZm9yIGEgd2hpbGUp LgoKPiBQYXRjaAo+IHNlZW1zIHRvIHdvcmsgaGVyZSBhbmQgZ3JlcHBpbmcgc3lzZnMgaGllcmFy Y2h5IGJlZm9yZSBhbmQgYWZ0ZXI6Cj4gCj4gZmluZCAvc3lzLyB8IGdyZXAgLWkgZWRhYyA+IC4u Lgo+IAo+IGRvZXNuJ3Qgc2hvdyBhbnkgZGlmZmVyZW5jZXMuCj4gCj4gVG9ueSwgSSdkIGFwcHJl Y2lhdGUgcnVubmluZyB0aGlzIG9uIG9uZSBvZiB5b3VyIGJpZyBib3hlcyB0byBjaGVjawo+IG5v dGhpbmcgaXMgbWlzc2luZyBpbiBzeXNmcy4uLgoKVGhlcmUgYXJlIGEgZmV3IEVEQUMgZHJpdmVy cyBmb3Igb2xkIHNlcnZlciBjaGlwc2V0cyB0aGF0IGNyZWF0ZQplcnJvciByZXBvcnQgbWVjaGFu aXNtcyBmb3IgUENJIGJ1cyBjb250cm9sbGVycy4gSSBkb24ndCByZW1lbWJlcgp0aGUgc3BlY2lm aWNzIGFueW1vcmUuIEkgKnN1c3BlY3QqIHRob3NlIGFyZSB0aGUgZHJpdmVycyB0aGF0CmRvIHN1 Y2ggdXNhZ2U6CgoJJCBnaXQgZ3JlcCAtbCBlZGFjX3BjaV9hZGRfZGV2aWNlCglkcml2ZXJzL2Vk YWMvYW1kODExMV9lZGFjLmMKCWRyaXZlcnMvZWRhYy9hbWQ4MTMxX2VkYWMuYwoJZHJpdmVycy9l ZGFjL2VkYWNfcGNpLmMKCWRyaXZlcnMvZWRhYy9lZGFjX3BjaS5oCglkcml2ZXJzL2VkYWMvbXBj ODV4eF9lZGFjLmMKCWRyaXZlcnMvZWRhYy9tdjY0eDYwX2VkYWMuYwoJZHJpdmVycy9lZGFjL29j dGVvbl9lZGFjLXBjaS5jCgpOb25lIG9mIHRoZW0gdXNlIEludGVsIGNoaXBzZXRzLgoKTGFzdCB0 aW1lIEkgdHJpZWQgdG8gdGVzdCBpdCAobW9yZSB0aGFuIDUgeWVhcnMgYWdvKSwgaXQgd2FzCmhh cmQgdG8gZmluZCBzdWNoIHN5c3RlbXMgYXQgdGhlIGxhYnMgSSBoYWQgYWNjZXNzIG9uIHRoYXQg dGltZS4KCkFueXdheSwgYXMgdGhpcyBpcyBhIG1vcmUgdW51c3VhbCB1c2FnZSBvZiBFREFDIEFQ SSwgaXQgY291bGQgYmUKd29ydGggdG8gZG91YmxlLWNoZWNrIGlmIHRoaXMgcGF0Y2ggd29uJ3Qg YnJlYWsgaXQsIG1heWJlIGRvaW5nCnNvbWUgdGVzdCBvbiBzdWNoIG1hY2hpbmVzIGJlZm9yZS9h ZnRlciB0aGlzIHBhdGNoIGluIG9yZGVyIHRvIAp2ZXJpZnkgdGhhdCB0aGlzIHdvbid0IGNhdXNl IHJlZ3Jlc3Npb25zIHRoZXJlLgoKSW4gdGhlc2lzLCBpdCBzaG91bGRuJ3QgYWZmZWN0LCBhcyB0 aGUgY2hhbmdlcyBhcmUgaGFwcGVuaW5nIGF0CmVkYWNfbWMqLmMsIGJ1dCBJIHdvbid0IGRvdWJ0 IHRoYXQgaXQgbWlnaHQgaGF2ZSBhIGhpZGRlbiBkZXBlbmRlbmN5CnNvbWV3aGVyZS4KCj4gCj4g VGh4Lgo+IAo+IC0tLQo+ICBkcml2ZXJzL2VkYWMvZWRhY19tYy5jICAgICAgIHwgIDkgKy0tLS0t LS0tCj4gIGRyaXZlcnMvZWRhYy9lZGFjX21jX3N5c2ZzLmMgfCAzMCArKy0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0KPiAgaW5jbHVkZS9saW51eC9lZGFjLmggICAgICAgICB8ICA2IC0tLS0t LQo+ICAzIGZpbGVzIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgNDIgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZWRhYy9lZGFjX21jLmMgYi9kcml2ZXJzL2VkYWMvZWRh Y19tYy5jCj4gaW5kZXggN2QzZWRkNzEzOTMyLi4xMzU5NGZmYWRjYjMgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9lZGFjL2VkYWNfbWMuYwo+ICsrKyBiL2RyaXZlcnMvZWRhYy9lZGFjX21jLmMKPiBA QCAtNTUsOCArNTUsNiBAQCBzdGF0aWMgTElTVF9IRUFEKG1jX2RldmljZXMpOwo+ICAgKi8KPiAg c3RhdGljIGNvbnN0IGNoYXIgKmVkYWNfbWNfb3duZXI7Cj4gIAo+IC1zdGF0aWMgc3RydWN0IGJ1 c190eXBlIG1jX2J1c1tFREFDX01BWF9NQ1NdOwo+IC0KPiAgaW50IGVkYWNfZ2V0X3JlcG9ydF9z dGF0dXModm9pZCkKPiAgewo+ICAJcmV0dXJuIGVkYWNfcmVwb3J0Owo+IEBAIC03MTYsMTEgKzcx NCw2IEBAIGludCBlZGFjX21jX2FkZF9tY193aXRoX2dyb3VwcyhzdHJ1Y3QgbWVtX2N0bF9pbmZv ICptY2ksCj4gIAlpbnQgcmV0ID0gLUVJTlZBTDsKPiAgCWVkYWNfZGJnKDAsICJcbiIpOwo+ICAK PiAtCWlmIChtY2ktPm1jX2lkeCA+PSBFREFDX01BWF9NQ1MpIHsKPiAtCQlwcl93YXJuX29uY2Uo IlRvbyBtYW55IG1lbW9yeSBjb250cm9sbGVyczogJWRcbiIsIG1jaS0+bWNfaWR4KTsKPiAtCQly ZXR1cm4gLUVOT0RFVjsKPiAtCX0KPiAtCj4gICNpZmRlZiBDT05GSUdfRURBQ19ERUJVRwo+ICAJ aWYgKGVkYWNfZGVidWdfbGV2ZWwgPj0gMykKPiAgCQllZGFjX21jX2R1bXBfbWNpKG1jaSk7Cj4g QEAgLTc2MCw3ICs3NTMsNyBAQCBpbnQgZWRhY19tY19hZGRfbWNfd2l0aF9ncm91cHMoc3RydWN0 IG1lbV9jdGxfaW5mbyAqbWNpLAo+ICAJLyogc2V0IGxvYWQgdGltZSBzbyB0aGF0IGVycm9yIHJh dGUgY2FuIGJlIHRyYWNrZWQgKi8KPiAgCW1jaS0+c3RhcnRfdGltZSA9IGppZmZpZXM7Cj4gIAo+ IC0JbWNpLT5idXMgPSAmbWNfYnVzW21jaS0+bWNfaWR4XTsKPiArCW1jaS0+YnVzID0gZWRhY19n ZXRfc3lzZnNfc3Vic3lzKCk7Cj4gIAo+ICAJaWYgKGVkYWNfY3JlYXRlX3N5c2ZzX21jaV9kZXZp Y2UobWNpLCBncm91cHMpKSB7Cj4gIAkJZWRhY19tY19wcmludGsobWNpLCBLRVJOX1dBUk5JTkcs Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZWRhYy9lZGFjX21jX3N5c2ZzLmMgYi9kcml2ZXJzL2Vk YWMvZWRhY19tY19zeXNmcy5jCj4gaW5kZXggMjAzNzRiODI0OGYwLi4yY2EyMDEyZjI4NTcgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9lZGFjL2VkYWNfbWNfc3lzZnMuYwo+ICsrKyBiL2RyaXZlcnMv ZWRhYy9lZGFjX21jX3N5c2ZzLmMKPiBAQCAtOTE0LDI3ICs5MTQsOCBAQCBzdGF0aWMgY29uc3Qg c3RydWN0IGRldmljZV90eXBlIG1jaV9hdHRyX3R5cGUgPSB7Cj4gIGludCBlZGFjX2NyZWF0ZV9z eXNmc19tY2lfZGV2aWNlKHN0cnVjdCBtZW1fY3RsX2luZm8gKm1jaSwKPiAgCQkJCSBjb25zdCBz dHJ1Y3QgYXR0cmlidXRlX2dyb3VwICoqZ3JvdXBzKQo+ICB7Cj4gLQljaGFyICpuYW1lOwo+ICAJ aW50IGksIGVycjsKPiAgCj4gLQkvKgo+IC0JICogVGhlIG1lbW9yeSBjb250cm9sbGVyIG5lZWRz IGl0cyBvd24gYnVzLCBpbiBvcmRlciB0byBhdm9pZAo+IC0JICogbmFtZXNwYWNlIGNvbmZsaWN0 cyBhdCAvc3lzL2J1cy9lZGFjLgo+IC0JICovCj4gLQluYW1lID0ga2FzcHJpbnRmKEdGUF9LRVJO RUwsICJtYyVkIiwgbWNpLT5tY19pZHgpOwo+IC0JaWYgKCFuYW1lKQo+IC0JCXJldHVybiAtRU5P TUVNOwo+IC0KPiAtCW1jaS0+YnVzLT5uYW1lID0gbmFtZTsKPiAtCj4gLQllZGFjX2RiZygwLCAi Y3JlYXRpbmcgYnVzICVzXG4iLCBtY2ktPmJ1cy0+bmFtZSk7Cj4gLQo+IC0JZXJyID0gYnVzX3Jl Z2lzdGVyKG1jaS0+YnVzKTsKPiAtCWlmIChlcnIgPCAwKSB7Cj4gLQkJa2ZyZWUobmFtZSk7Cj4g LQkJcmV0dXJuIGVycjsKPiAtCX0KPiAtCj4gIAkvKiBnZXQgdGhlIC9zeXMvZGV2aWNlcy9zeXN0 ZW0vZWRhYyBzdWJzeXMgcmVmZXJlbmNlICovCj4gIAltY2ktPmRldi50eXBlID0gJm1jaV9hdHRy X3R5cGU7Cj4gIAlkZXZpY2VfaW5pdGlhbGl6ZSgmbWNpLT5kZXYpOwo+IEBAIC05NTAsNyArOTMx LDcgQEAgaW50IGVkYWNfY3JlYXRlX3N5c2ZzX21jaV9kZXZpY2Uoc3RydWN0IG1lbV9jdGxfaW5m byAqbWNpLAo+ICAJZXJyID0gZGV2aWNlX2FkZCgmbWNpLT5kZXYpOwo+ICAJaWYgKGVyciA8IDAp IHsKPiAgCQllZGFjX2RiZygxLCAiZmFpbHVyZTogY3JlYXRlIGRldmljZSAlc1xuIiwgZGV2X25h bWUoJm1jaS0+ZGV2KSk7Cj4gLQkJZ290byBmYWlsX3VucmVnaXN0ZXJfYnVzOwo+ICsJCWdvdG8g b3V0Owo+ICAJfQo+ICAKPiAgCS8qCj4gQEAgLTk5OCwxMCArOTc5LDggQEAgaW50IGVkYWNfY3Jl YXRlX3N5c2ZzX21jaV9kZXZpY2Uoc3RydWN0IG1lbV9jdGxfaW5mbyAqbWNpLAo+ICAJCWRldmlj ZV91bnJlZ2lzdGVyKCZkaW1tLT5kZXYpOwo+ICAJfQo+ICAJZGV2aWNlX3VucmVnaXN0ZXIoJm1j aS0+ZGV2KTsKPiAtZmFpbF91bnJlZ2lzdGVyX2J1czoKPiAtCWJ1c191bnJlZ2lzdGVyKG1jaS0+ YnVzKTsKPiAtCWtmcmVlKG5hbWUpOwo+ICAKPiArb3V0Ogo+ICAJcmV0dXJuIGVycjsKPiAgfQo+ ICAKPiBAQCAtMTAzMiwxMyArMTAxMSw4IEBAIHZvaWQgZWRhY19yZW1vdmVfc3lzZnNfbWNpX2Rl dmljZShzdHJ1Y3QgbWVtX2N0bF9pbmZvICptY2kpCj4gIAo+ICB2b2lkIGVkYWNfdW5yZWdpc3Rl cl9zeXNmcyhzdHJ1Y3QgbWVtX2N0bF9pbmZvICptY2kpCj4gIHsKPiAtCXN0cnVjdCBidXNfdHlw ZSAqYnVzID0gbWNpLT5idXM7Cj4gLQljb25zdCBjaGFyICpuYW1lID0gbWNpLT5idXMtPm5hbWU7 Cj4gLQo+ICAJZWRhY19kYmcoMSwgIlVucmVnaXN0ZXJpbmcgZGV2aWNlICVzXG4iLCBkZXZfbmFt ZSgmbWNpLT5kZXYpKTsKPiAgCWRldmljZV91bnJlZ2lzdGVyKCZtY2ktPmRldik7Cj4gLQlidXNf dW5yZWdpc3RlcihidXMpOwo+IC0Ja2ZyZWUobmFtZSk7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lk IG1jX2F0dHJfcmVsZWFzZShzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gZGlmZiAtLWdpdCBhL2luY2x1 ZGUvbGludXgvZWRhYy5oIGIvaW5jbHVkZS9saW51eC9lZGFjLmgKPiBpbmRleCBhNDVjZTFmODRi ZmMuLmRkOGQwMDZmMTgzNyAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2xpbnV4L2VkYWMuaAo+ICsr KyBiL2luY2x1ZGUvbGludXgvZWRhYy5oCj4gQEAgLTY2OCwxMCArNjY4LDQgQEAgc3RydWN0IG1l bV9jdGxfaW5mbyB7Cj4gIAlib29sIGZha2VfaW5qZWN0X3VlOwo+ICAJdTE2IGZha2VfaW5qZWN0 X2NvdW50Owo+ICB9Owo+IC0KPiAtLyoKPiAtICogTWF4aW11bSBudW1iZXIgb2YgbWVtb3J5IGNv bnRyb2xsZXJzIGluIHRoZSBjb2hlcmVudCBmYWJyaWMuCj4gLSAqLwo+IC0jZGVmaW5lIEVEQUNf TUFYX01DUwkxNgo+IC0KPiAgI2VuZGlmCgoKClRoYW5rcywKTWF1cm8K