From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-lf1-f67.google.com ([209.85.167.67]:35706 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726915AbeIZUWm (ORCPT ); Wed, 26 Sep 2018 16:22:42 -0400 Received: by mail-lf1-f67.google.com with SMTP id r191-v6so10846281lff.2 for ; Wed, 26 Sep 2018 07:09:33 -0700 (PDT) From: "Niklas =?iso-8859-1?Q?S=F6derlund?=" Date: Wed, 26 Sep 2018 16:09:30 +0200 To: Kieran Bingham Cc: Laurent Pinchart , Jacopo Mondi , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 3/3] i2c: adv748x: fix typo in comment for TXB CSI-2 transmitter power down Message-ID: <20180926140930.GG32205@bigcity.dyn.berto.se> References: <20180918014509.6394-1-niklas.soderlund+renesas@ragnatech.se> <20180918014509.6394-4-niklas.soderlund+renesas@ragnatech.se> <0a4bb79e-2f5d-f4ee-1c5a-3d9a28d75596@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0a4bb79e-2f5d-f4ee-1c5a-3d9a28d75596@ideasonboard.com> Sender: linux-media-owner@vger.kernel.org List-ID: Hi Kieran, On 2018-09-26 14:49:22 +0100, Kieran Bingham wrote: > Hi Niklas, > > On 18/09/18 02:45, Niklas Söderlund wrote: > > Fix copy-and-past error in comment for TXB CSI-2 transmitter power down > > sequence. > > > > I have collected this patch into my adv748x/for-next branch (and fixed > the typo in "copy-and-past" and submitted as a pull request for Hans and > Mauro. Thanks I will drop this patch for my v2. > > -- > Regards > > Kieran > > > > Signed-off-by: Niklas Söderlund > > --- > > drivers/media/i2c/adv748x/adv748x-core.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c > > index 9a82cdf301bccb41..86cb38f4d7cc11c6 100644 > > --- a/drivers/media/i2c/adv748x/adv748x-core.c > > +++ b/drivers/media/i2c/adv748x/adv748x-core.c > > @@ -299,7 +299,7 @@ static const struct adv748x_reg_value adv748x_power_down_txb_1lane[] = { > > > > {ADV748X_PAGE_TXB, 0x31, 0x82}, /* ADI Required Write */ > > {ADV748X_PAGE_TXB, 0x1e, 0x00}, /* ADI Required Write */ > > - {ADV748X_PAGE_TXB, 0x00, 0x81}, /* Enable 4-lane MIPI */ > > + {ADV748X_PAGE_TXB, 0x00, 0x81}, /* Enable 1-lane MIPI */ > > {ADV748X_PAGE_TXB, 0xda, 0x01}, /* i2c_mipi_pll_en - 1'b1 */ > > {ADV748X_PAGE_TXB, 0xc1, 0x3b}, /* ADI Required Write */ > > > > -- Regards, Niklas Söderlund From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f65.google.com ([209.85.167.65]:37272 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727157AbeIZUWm (ORCPT ); Wed, 26 Sep 2018 16:22:42 -0400 Received: by mail-lf1-f65.google.com with SMTP id a82-v6so7987093lfa.4 for ; Wed, 26 Sep 2018 07:09:33 -0700 (PDT) From: "Niklas =?iso-8859-1?Q?S=F6derlund?=" Date: Wed, 26 Sep 2018 16:09:30 +0200 To: Kieran Bingham Cc: Laurent Pinchart , Jacopo Mondi , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 3/3] i2c: adv748x: fix typo in comment for TXB CSI-2 transmitter power down Message-ID: <20180926140930.GG32205@bigcity.dyn.berto.se> References: <20180918014509.6394-1-niklas.soderlund+renesas@ragnatech.se> <20180918014509.6394-4-niklas.soderlund+renesas@ragnatech.se> <0a4bb79e-2f5d-f4ee-1c5a-3d9a28d75596@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0a4bb79e-2f5d-f4ee-1c5a-3d9a28d75596@ideasonboard.com> Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Kieran, On 2018-09-26 14:49:22 +0100, Kieran Bingham wrote: > Hi Niklas, > > On 18/09/18 02:45, Niklas S�derlund wrote: > > Fix copy-and-past error in comment for TXB CSI-2 transmitter power down > > sequence. > > > > I have collected this patch into my adv748x/for-next branch (and fixed > the typo in "copy-and-past" and submitted as a pull request for Hans and > Mauro. Thanks I will drop this patch for my v2. > > -- > Regards > > Kieran > > > > Signed-off-by: Niklas S�derlund > > --- > > drivers/media/i2c/adv748x/adv748x-core.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c > > index 9a82cdf301bccb41..86cb38f4d7cc11c6 100644 > > --- a/drivers/media/i2c/adv748x/adv748x-core.c > > +++ b/drivers/media/i2c/adv748x/adv748x-core.c > > @@ -299,7 +299,7 @@ static const struct adv748x_reg_value adv748x_power_down_txb_1lane[] = { > > > > {ADV748X_PAGE_TXB, 0x31, 0x82}, /* ADI Required Write */ > > {ADV748X_PAGE_TXB, 0x1e, 0x00}, /* ADI Required Write */ > > - {ADV748X_PAGE_TXB, 0x00, 0x81}, /* Enable 4-lane MIPI */ > > + {ADV748X_PAGE_TXB, 0x00, 0x81}, /* Enable 1-lane MIPI */ > > {ADV748X_PAGE_TXB, 0xda, 0x01}, /* i2c_mipi_pll_en - 1'b1 */ > > {ADV748X_PAGE_TXB, 0xc1, 0x3b}, /* ADI Required Write */ > > > > -- Regards, Niklas S�derlund