From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2CE1C43382 for ; Wed, 26 Sep 2018 18:10:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A434C21537 for ; Wed, 26 Sep 2018 18:10:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A434C21537 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727158AbeI0AYp (ORCPT ); Wed, 26 Sep 2018 20:24:45 -0400 Received: from mga07.intel.com ([134.134.136.100]:51930 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725806AbeI0AYp (ORCPT ); Wed, 26 Sep 2018 20:24:45 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2018 11:10:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,307,1534834800"; d="scan'208";a="93496241" Received: from agluck-desk.sc.intel.com (HELO agluck-desk) ([10.3.52.160]) by fmsmga001.fm.intel.com with ESMTP; 26 Sep 2018 11:10:35 -0700 Date: Wed, 26 Sep 2018 11:10:35 -0700 From: "Luck, Tony" To: Borislav Petkov Cc: Mauro Carvalho Chehab , Greg KH , Justin Ernst , russ.anderson@hpe.com, Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Aristeu Rozanski Filho Subject: Re: [PATCH] Raise maximum number of memory controllers Message-ID: <20180926181035.GA1132@agluck-desk> References: <20180925143449.284634-1-justin.ernst@hpe.com> <20180925152659.GE23986@zn.tnic> <20180925175023.GA16725@agluck-desk> <20180925180458.GG23986@zn.tnic> <20180926093510.GA5584@zn.tnic> <20180926152752.GG5584@zn.tnic> <20180926130340.6b22918b@coco.lan> <20180926161749.GI5584@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180926161749.GI5584@zn.tnic> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 26, 2018 at 06:17:49PM +0200, Borislav Petkov wrote: > On Wed, Sep 26, 2018 at 01:03:40PM -0300, Mauro Carvalho Chehab wrote: > > I guess this is/was needed to create things like this: > > > > lrwxrwxrwx 1 root root 0 set 26 05:24 /sys/bus/edac/devices/mc -> ../../../devices/system/edac/mc > > They're still there: > > $ ls -l /sys/bus/edac/devices/ > total 0 > lrwxrwxrwx 1 root root 0 Sep 26 18:15 csrow0 -> ../../../devices/system/edac/mc/mc0/csrow0 > lrwxrwxrwx 1 root root 0 Sep 26 18:15 dimm0 -> ../../../devices/system/edac/mc/mc0/dimm0 > lrwxrwxrwx 1 root root 0 Sep 26 18:15 dimm3 -> ../../../devices/system/edac/mc/mc0/dimm3 > lrwxrwxrwx 1 root root 0 Sep 26 18:15 dimm6 -> ../../../devices/system/edac/mc/mc0/dimm6 > lrwxrwxrwx 1 root root 0 Sep 26 18:15 dimm9 -> ../../../devices/system/edac/mc/mc0/dimm9 > lrwxrwxrwx 1 root root 0 Sep 26 18:15 mc -> ../../../devices/system/edac/mc > lrwxrwxrwx 1 root root 0 Sep 26 18:15 mc0 -> ../../../devices/system/edac/mc/mc0 I ran into trouble on my 4 socket broadwell server (so 8 memory controllers, a whole pile of DIMMs, running from sb_edac.c) Things start going wrong with: [ 45.216657] sysfs: cannot create duplicate filename '/bus/edac/devices/dimm0' [ 45.216663] CPU: 37 PID: 2034 Comm: systemd-udevd Not tainted 4.19.0-rc5 #1 [ 45.216665] Hardware name: Intel Corporation BRICKLAND/BRICKLAND, BIOS BRBDXSD1.86B.0338.V01.1603162127 03/16/2016 [ 45.216667] Call Trace: [ 45.216688] dump_stack+0x5c/0x7b [ 45.216697] sysfs_warn_dup+0x56/0x70 [ 45.216702] sysfs_do_create_link_sd.isra.2+0x98/0xb0 [ 45.216714] bus_add_device+0x77/0x160 [ 45.216720] device_add+0x424/0x660 [ 45.216731] edac_create_sysfs_mci_device+0xb9/0x2f0 [ 45.216738] edac_mc_add_mc_with_groups+0x111/0x2b0 [ 45.216747] sbridge_init+0x13c9/0x2000 [sb_edac] [ 45.216757] ? _raw_spin_lock+0x1d/0x20 [ 45.216765] ? free_pcppages_bulk+0x2ca/0x630 [ 45.216769] ? 0xffffffffc050f000 [ 45.216779] do_one_initcall+0x46/0x1c8 [ 45.216784] ? free_unref_page_commit+0x95/0x120 [ 45.216791] ? _cond_resched+0x15/0x40 [ 45.216798] ? kmem_cache_alloc_trace+0x153/0x1c0 [ 45.216805] do_init_module+0x5b/0x208 [ 45.216826] load_module+0x1a2d/0x1fb0 [ 45.216835] ? __do_sys_finit_module+0xe9/0x110 [ 45.216840] __do_sys_finit_module+0xe9/0x110 [ 45.216847] do_syscall_64+0x5b/0x180 [ 45.216852] entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 45.216856] RIP: 0033:0x7fcdec618bd9 and fell off a cliff after that. Going back to the old code I have a "dimm0" on each of the eight controllers: # find /sys -name dimm0 /sys/devices/system/edac/mc/mc6/dimm0 /sys/devices/system/edac/mc/mc4/dimm0 /sys/devices/system/edac/mc/mc2/dimm0 /sys/devices/system/edac/mc/mc0/dimm0 /sys/devices/system/edac/mc/mc7/dimm0 /sys/devices/system/edac/mc/mc5/dimm0 /sys/devices/system/edac/mc/mc3/dimm0 /sys/devices/system/edac/mc/mc1/dimm0 /sys/bus/mc6/devices/dimm0 /sys/bus/mc4/devices/dimm0 /sys/bus/mc2/devices/dimm0 /sys/bus/mc0/devices/dimm0 /sys/bus/mc7/devices/dimm0 /sys/bus/mc5/devices/dimm0 /sys/bus/mc3/devices/dimm0 /sys/bus/mc1/devices/dimm0 # ls -l /sys/bus/mc0/devices total 0 lrwxrwxrwx. 1 root root 0 Sep 26 11:08 csrow0 -> ../../../devices/system/edac/mc/mc0/csrow0 lrwxrwxrwx. 1 root root 0 Sep 26 11:08 dimm0 -> ../../../devices/system/edac/mc/mc0/dimm0 lrwxrwxrwx. 1 root root 0 Sep 26 11:08 dimm3 -> ../../../devices/system/edac/mc/mc0/dimm3 lrwxrwxrwx. 1 root root 0 Sep 26 11:08 dimm6 -> ../../../devices/system/edac/mc/mc0/dimm6 lrwxrwxrwx. 1 root root 0 Sep 26 11:08 dimm9 -> ../../../devices/system/edac/mc/mc0/dimm9 lrwxrwxrwx. 1 root root 0 Sep 26 11:08 mc0 -> ../../../devices/system/edac/mc/mc0 It looks like the new code isn't trying to place the dimm symlinks in the proper subdirectories. -Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: Raise maximum number of memory controllers From: "Luck, Tony" Message-Id: <20180926181035.GA1132@agluck-desk> Date: Wed, 26 Sep 2018 11:10:35 -0700 To: Borislav Petkov Cc: Mauro Carvalho Chehab , Greg KH , Justin Ernst , russ.anderson@hpe.com, Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Aristeu Rozanski Filho List-ID: T24gV2VkLCBTZXAgMjYsIDIwMTggYXQgMDY6MTc6NDlQTSArMDIwMCwgQm9yaXNsYXYgUGV0a292 IHdyb3RlOgo+IE9uIFdlZCwgU2VwIDI2LCAyMDE4IGF0IDAxOjAzOjQwUE0gLTAzMDAsIE1hdXJv IENhcnZhbGhvIENoZWhhYiB3cm90ZToKPiA+IEkgZ3Vlc3MgdGhpcyBpcy93YXMgbmVlZGVkIHRv IGNyZWF0ZSB0aGluZ3MgbGlrZSB0aGlzOgo+ID4gCj4gPiAJbHJ3eHJ3eHJ3eCAxIHJvb3Qgcm9v dCAwIHNldCAyNiAwNToyNCAvc3lzL2J1cy9lZGFjL2RldmljZXMvbWMgLT4gLi4vLi4vLi4vZGV2 aWNlcy9zeXN0ZW0vZWRhYy9tYwo+IAo+IFRoZXkncmUgc3RpbGwgdGhlcmU6Cj4gCj4gJCBscyAt bCAvc3lzL2J1cy9lZGFjL2RldmljZXMvCj4gdG90YWwgMAo+IGxyd3hyd3hyd3ggMSByb290IHJv b3QgMCBTZXAgMjYgMTg6MTUgY3Nyb3cwIC0+IC4uLy4uLy4uL2RldmljZXMvc3lzdGVtL2VkYWMv bWMvbWMwL2Nzcm93MAo+IGxyd3hyd3hyd3ggMSByb290IHJvb3QgMCBTZXAgMjYgMTg6MTUgZGlt bTAgLT4gLi4vLi4vLi4vZGV2aWNlcy9zeXN0ZW0vZWRhYy9tYy9tYzAvZGltbTAKPiBscnd4cnd4 cnd4IDEgcm9vdCByb290IDAgU2VwIDI2IDE4OjE1IGRpbW0zIC0+IC4uLy4uLy4uL2RldmljZXMv c3lzdGVtL2VkYWMvbWMvbWMwL2RpbW0zCj4gbHJ3eHJ3eHJ3eCAxIHJvb3Qgcm9vdCAwIFNlcCAy NiAxODoxNSBkaW1tNiAtPiAuLi8uLi8uLi9kZXZpY2VzL3N5c3RlbS9lZGFjL21jL21jMC9kaW1t Ngo+IGxyd3hyd3hyd3ggMSByb290IHJvb3QgMCBTZXAgMjYgMTg6MTUgZGltbTkgLT4gLi4vLi4v Li4vZGV2aWNlcy9zeXN0ZW0vZWRhYy9tYy9tYzAvZGltbTkKPiBscnd4cnd4cnd4IDEgcm9vdCBy b290IDAgU2VwIDI2IDE4OjE1IG1jIC0+IC4uLy4uLy4uL2RldmljZXMvc3lzdGVtL2VkYWMvbWMK PiBscnd4cnd4cnd4IDEgcm9vdCByb290IDAgU2VwIDI2IDE4OjE1IG1jMCAtPiAuLi8uLi8uLi9k ZXZpY2VzL3N5c3RlbS9lZGFjL21jL21jMAoKSSByYW4gaW50byB0cm91YmxlIG9uIG15IDQgc29j a2V0IGJyb2Fkd2VsbCBzZXJ2ZXIgKHNvIDggbWVtb3J5IGNvbnRyb2xsZXJzLAphIHdob2xlIHBp bGUgb2YgRElNTXMsIHJ1bm5pbmcgZnJvbSBzYl9lZGFjLmMpCgpUaGluZ3Mgc3RhcnQgZ29pbmcg d3Jvbmcgd2l0aDoKClsgICA0NS4yMTY2NTddIHN5c2ZzOiBjYW5ub3QgY3JlYXRlIGR1cGxpY2F0 ZSBmaWxlbmFtZSAnL2J1cy9lZGFjL2RldmljZXMvZGltbTAnClsgICA0NS4yMTY2NjNdIENQVTog MzcgUElEOiAyMDM0IENvbW06IHN5c3RlbWQtdWRldmQgTm90IHRhaW50ZWQgNC4xOS4wLXJjNSAj MQpbICAgNDUuMjE2NjY1XSBIYXJkd2FyZSBuYW1lOiBJbnRlbCBDb3Jwb3JhdGlvbiBCUklDS0xB TkQvQlJJQ0tMQU5ELCBCSU9TIEJSQkRYU0QxLjg2Qi4wMzM4LlYwMS4xNjAzMTYyMTI3IDAzLzE2 LzIwMTYKWyAgIDQ1LjIxNjY2N10gQ2FsbCBUcmFjZToKWyAgIDQ1LjIxNjY4OF0gIGR1bXBfc3Rh Y2srMHg1Yy8weDdiClsgICA0NS4yMTY2OTddICBzeXNmc193YXJuX2R1cCsweDU2LzB4NzAKWyAg IDQ1LjIxNjcwMl0gIHN5c2ZzX2RvX2NyZWF0ZV9saW5rX3NkLmlzcmEuMisweDk4LzB4YjAKWyAg IDQ1LjIxNjcxNF0gIGJ1c19hZGRfZGV2aWNlKzB4NzcvMHgxNjAKWyAgIDQ1LjIxNjcyMF0gIGRl dmljZV9hZGQrMHg0MjQvMHg2NjAKWyAgIDQ1LjIxNjczMV0gIGVkYWNfY3JlYXRlX3N5c2ZzX21j aV9kZXZpY2UrMHhiOS8weDJmMApbICAgNDUuMjE2NzM4XSAgZWRhY19tY19hZGRfbWNfd2l0aF9n cm91cHMrMHgxMTEvMHgyYjAKWyAgIDQ1LjIxNjc0N10gIHNicmlkZ2VfaW5pdCsweDEzYzkvMHgy MDAwIFtzYl9lZGFjXQpbICAgNDUuMjE2NzU3XSAgPyBfcmF3X3NwaW5fbG9jaysweDFkLzB4MjAK WyAgIDQ1LjIxNjc2NV0gID8gZnJlZV9wY3BwYWdlc19idWxrKzB4MmNhLzB4NjMwClsgICA0NS4y MTY3NjldICA/IDB4ZmZmZmZmZmZjMDUwZjAwMApbICAgNDUuMjE2Nzc5XSAgZG9fb25lX2luaXRj YWxsKzB4NDYvMHgxYzgKWyAgIDQ1LjIxNjc4NF0gID8gZnJlZV91bnJlZl9wYWdlX2NvbW1pdCsw eDk1LzB4MTIwClsgICA0NS4yMTY3OTFdICA/IF9jb25kX3Jlc2NoZWQrMHgxNS8weDQwClsgICA0 NS4yMTY3OThdICA/IGttZW1fY2FjaGVfYWxsb2NfdHJhY2UrMHgxNTMvMHgxYzAKWyAgIDQ1LjIx NjgwNV0gIGRvX2luaXRfbW9kdWxlKzB4NWIvMHgyMDgKWyAgIDQ1LjIxNjgyNl0gIGxvYWRfbW9k dWxlKzB4MWEyZC8weDFmYjAKWyAgIDQ1LjIxNjgzNV0gID8gX19kb19zeXNfZmluaXRfbW9kdWxl KzB4ZTkvMHgxMTAKWyAgIDQ1LjIxNjg0MF0gIF9fZG9fc3lzX2Zpbml0X21vZHVsZSsweGU5LzB4 MTEwClsgICA0NS4yMTY4NDddICBkb19zeXNjYWxsXzY0KzB4NWIvMHgxODAKWyAgIDQ1LjIxNjg1 Ml0gIGVudHJ5X1NZU0NBTExfNjRfYWZ0ZXJfaHdmcmFtZSsweDQ0LzB4YTkKWyAgIDQ1LjIxNjg1 Nl0gUklQOiAwMDMzOjB4N2ZjZGVjNjE4YmQ5CgphbmQgZmVsbCBvZmYgYSBjbGlmZiBhZnRlciB0 aGF0LgoKR29pbmcgYmFjayB0byB0aGUgb2xkIGNvZGUgSSBoYXZlIGEgImRpbW0wIiBvbiBlYWNo IG9mIHRoZSBlaWdodCBjb250cm9sbGVyczoKCiMgZmluZCAvc3lzIC1uYW1lIGRpbW0wCi9zeXMv ZGV2aWNlcy9zeXN0ZW0vZWRhYy9tYy9tYzYvZGltbTAKL3N5cy9kZXZpY2VzL3N5c3RlbS9lZGFj L21jL21jNC9kaW1tMAovc3lzL2RldmljZXMvc3lzdGVtL2VkYWMvbWMvbWMyL2RpbW0wCi9zeXMv ZGV2aWNlcy9zeXN0ZW0vZWRhYy9tYy9tYzAvZGltbTAKL3N5cy9kZXZpY2VzL3N5c3RlbS9lZGFj L21jL21jNy9kaW1tMAovc3lzL2RldmljZXMvc3lzdGVtL2VkYWMvbWMvbWM1L2RpbW0wCi9zeXMv ZGV2aWNlcy9zeXN0ZW0vZWRhYy9tYy9tYzMvZGltbTAKL3N5cy9kZXZpY2VzL3N5c3RlbS9lZGFj L21jL21jMS9kaW1tMAovc3lzL2J1cy9tYzYvZGV2aWNlcy9kaW1tMAovc3lzL2J1cy9tYzQvZGV2 aWNlcy9kaW1tMAovc3lzL2J1cy9tYzIvZGV2aWNlcy9kaW1tMAovc3lzL2J1cy9tYzAvZGV2aWNl cy9kaW1tMAovc3lzL2J1cy9tYzcvZGV2aWNlcy9kaW1tMAovc3lzL2J1cy9tYzUvZGV2aWNlcy9k aW1tMAovc3lzL2J1cy9tYzMvZGV2aWNlcy9kaW1tMAovc3lzL2J1cy9tYzEvZGV2aWNlcy9kaW1t MAojIGxzIC1sIC9zeXMvYnVzL21jMC9kZXZpY2VzCnRvdGFsIDAKbHJ3eHJ3eHJ3eC4gMSByb290 IHJvb3QgMCBTZXAgMjYgMTE6MDggY3Nyb3cwIC0+IC4uLy4uLy4uL2RldmljZXMvc3lzdGVtL2Vk YWMvbWMvbWMwL2Nzcm93MApscnd4cnd4cnd4LiAxIHJvb3Qgcm9vdCAwIFNlcCAyNiAxMTowOCBk aW1tMCAtPiAuLi8uLi8uLi9kZXZpY2VzL3N5c3RlbS9lZGFjL21jL21jMC9kaW1tMApscnd4cnd4 cnd4LiAxIHJvb3Qgcm9vdCAwIFNlcCAyNiAxMTowOCBkaW1tMyAtPiAuLi8uLi8uLi9kZXZpY2Vz L3N5c3RlbS9lZGFjL21jL21jMC9kaW1tMwpscnd4cnd4cnd4LiAxIHJvb3Qgcm9vdCAwIFNlcCAy NiAxMTowOCBkaW1tNiAtPiAuLi8uLi8uLi9kZXZpY2VzL3N5c3RlbS9lZGFjL21jL21jMC9kaW1t Ngpscnd4cnd4cnd4LiAxIHJvb3Qgcm9vdCAwIFNlcCAyNiAxMTowOCBkaW1tOSAtPiAuLi8uLi8u Li9kZXZpY2VzL3N5c3RlbS9lZGFjL21jL21jMC9kaW1tOQpscnd4cnd4cnd4LiAxIHJvb3Qgcm9v dCAwIFNlcCAyNiAxMTowOCBtYzAgLT4gLi4vLi4vLi4vZGV2aWNlcy9zeXN0ZW0vZWRhYy9tYy9t YzAKCkl0IGxvb2tzIGxpa2UgdGhlIG5ldyBjb2RlIGlzbid0IHRyeWluZyB0byBwbGFjZSB0aGUg ZGltbSBzeW1saW5rcwppbiB0aGUgcHJvcGVyIHN1YmRpcmVjdG9yaWVzLgoKLVRvbnkK