From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dominique Martinet Subject: Re: [PATCH] 9p: potential NULL dereference Date: Wed, 26 Sep 2018 23:07:26 +0200 Message-ID: <20180926210726.GA29761@nautica> References: <20180926103934.GA14535@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Eric Van Hensbergen , Matthew Wilcox , Latchesar Ionkov , "David S. Miller" , v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: Dan Carpenter Return-path: Received: from nautica.notk.org ([91.121.71.147]:59138 "EHLO nautica.notk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726463AbeI0DWb (ORCPT ); Wed, 26 Sep 2018 23:22:31 -0400 Content-Disposition: inline In-Reply-To: <20180926103934.GA14535@mwanda> Sender: netdev-owner@vger.kernel.org List-ID: Dan Carpenter wrote on Wed, Sep 26, 2018: > p9_tag_alloc() is supposed to return error pointers, but we accidentally > return a NULL here. It would cause a NULL dereference in the caller. > > Fixes: 996d5b4db4b1 ("9p: Use a slab for allocating requests") > Signed-off-by: Dan Carpenter Good catch, the culprit commit is only in -next so just adding this to the queue right away. Thanks! -- Dominique From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dominique Martinet Date: Wed, 26 Sep 2018 21:07:26 +0000 Subject: Re: [PATCH] 9p: potential NULL dereference Message-Id: <20180926210726.GA29761@nautica> List-Id: References: <20180926103934.GA14535@mwanda> In-Reply-To: <20180926103934.GA14535@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Eric Van Hensbergen , Matthew Wilcox , Latchesar Ionkov , "David S. Miller" , v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Dan Carpenter wrote on Wed, Sep 26, 2018: > p9_tag_alloc() is supposed to return error pointers, but we accidentally > return a NULL here. It would cause a NULL dereference in the caller. > > Fixes: 996d5b4db4b1 ("9p: Use a slab for allocating requests") > Signed-off-by: Dan Carpenter Good catch, the culprit commit is only in -next so just adding this to the queue right away. Thanks! -- Dominique