Hi Shawn, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v4.19-rc5 next-20180926] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Lee-Shawn-C/drm-i915-Apply-correct-ddi-translation-table-for-AML-device/20180925-190446 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: i386-randconfig-s2-201838 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/gpu//drm/i915/intel_ddi.c: In function 'kbl_get_buf_trans_dp': >> drivers/gpu//drm/i915/intel_ddi.c:645:30: error: implicit declaration of function 'IS_AML_ULX' [-Werror=implicit-function-declaration] if (IS_KBL_ULX(dev_priv) || IS_AML_ULX(dev_priv)) { ^~~~~~~~~~ cc1: some warnings being treated as errors vim +/IS_AML_ULX +645 drivers/gpu//drm/i915/intel_ddi.c 641 642 static const struct ddi_buf_trans * 643 kbl_get_buf_trans_dp(struct drm_i915_private *dev_priv, int *n_entries) 644 { > 645 if (IS_KBL_ULX(dev_priv) || IS_AML_ULX(dev_priv)) { 646 *n_entries = ARRAY_SIZE(kbl_y_ddi_translations_dp); 647 return kbl_y_ddi_translations_dp; 648 } else if (IS_KBL_ULT(dev_priv) || IS_CFL_ULT(dev_priv)) { 649 *n_entries = ARRAY_SIZE(kbl_u_ddi_translations_dp); 650 return kbl_u_ddi_translations_dp; 651 } else { 652 *n_entries = ARRAY_SIZE(kbl_ddi_translations_dp); 653 return kbl_ddi_translations_dp; 654 } 655 } 656 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation