From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE959C43382 for ; Thu, 27 Sep 2018 05:56:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9ABAD2156B for ; Thu, 27 Sep 2018 05:56:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9ABAD2156B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727130AbeI0MM4 (ORCPT ); Thu, 27 Sep 2018 08:12:56 -0400 Received: from mail.skyhub.de ([5.9.137.197]:59820 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726659AbeI0MM4 (ORCPT ); Thu, 27 Sep 2018 08:12:56 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Ts7m6w-tl98F; Thu, 27 Sep 2018 07:56:23 +0200 (CEST) Received: from zn.tnic (p200300EC2BC7FB00329C23FFFEA6A903.dip0.t-ipconnect.de [IPv6:2003:ec:2bc7:fb00:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id EE22E1EC02C1; Thu, 27 Sep 2018 07:56:22 +0200 (CEST) Date: Thu, 27 Sep 2018 07:56:25 +0200 From: Borislav Petkov To: Justin Ernst Cc: russ.anderson@hpe.com, Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Raise maximum number of memory controllers Message-ID: <20180927055625.GB30912@zn.tnic> References: <20180925143449.284634-1-justin.ernst@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180925143449.284634-1-justin.ernst@hpe.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 25, 2018 at 09:34:49AM -0500, Justin Ernst wrote: > We observe an oops in the skx_edac module during boot. > Examining /var/log/messages: > [ 3401.985757] EDAC MC0: Giving out device to module skx_edac controller Skylake Socket#0 IMC#0 > [ 3401.985887] EDAC MC1: Giving out device to module skx_edac controller Skylake Socket#0 IMC#1 > [ 3401.986014] EDAC MC2: Giving out device to module skx_edac controller Skylake Socket#1 IMC#0 > ... > [ 3401.987318] EDAC MC13: Giving out device to module skx_edac controller Skylake Socket#0 IMC#1 > [ 3401.987435] EDAC MC14: Giving out device to module skx_edac controller Skylake Socket#1 IMC#0 > [ 3401.987556] EDAC MC15: Giving out device to module skx_edac controller Skylake Socket#1 IMC#1 > [ 3401.987579] Too many memory controllers: 16 > [ 3402.042614] EDAC MC: Removed device 0 for skx_edac Skylake Socket#0 IMC#0 > > We observe there are two memory controllers per socket, with a limit of 16. > Raise the maximum number of memory controllers from 16 to 2 * MAX_NUMNODES (1024). > > Cc: Borislav Petkov > Cc: Mauro Carvalho Chehab > Cc: linux-edac@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Acked-by: Russ Anderson > Signed-off-by: Justin Ernst > --- > include/linux/edac.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied, thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: Raise maximum number of memory controllers From: Borislav Petkov Message-Id: <20180927055625.GB30912@zn.tnic> Date: Thu, 27 Sep 2018 07:56:25 +0200 To: Justin Ernst Cc: russ.anderson@hpe.com, Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gVHVlLCBTZXAgMjUsIDIwMTggYXQgMDk6MzQ6NDlBTSAtMDUwMCwgSnVzdGluIEVybnN0IHdy b3RlOgo+IFdlIG9ic2VydmUgYW4gb29wcyBpbiB0aGUgc2t4X2VkYWMgbW9kdWxlIGR1cmluZyBi b290Lgo+IEV4YW1pbmluZyAvdmFyL2xvZy9tZXNzYWdlczoKPiBbIDM0MDEuOTg1NzU3XSBFREFD IE1DMDogR2l2aW5nIG91dCBkZXZpY2UgdG8gbW9kdWxlIHNreF9lZGFjIGNvbnRyb2xsZXIgU2t5 bGFrZSBTb2NrZXQjMCBJTUMjMAo+IFsgMzQwMS45ODU4ODddIEVEQUMgTUMxOiBHaXZpbmcgb3V0 IGRldmljZSB0byBtb2R1bGUgc2t4X2VkYWMgY29udHJvbGxlciBTa3lsYWtlIFNvY2tldCMwIElN QyMxCj4gWyAzNDAxLjk4NjAxNF0gRURBQyBNQzI6IEdpdmluZyBvdXQgZGV2aWNlIHRvIG1vZHVs ZSBza3hfZWRhYyBjb250cm9sbGVyIFNreWxha2UgU29ja2V0IzEgSU1DIzAKPiAuLi4KPiBbIDM0 MDEuOTg3MzE4XSBFREFDIE1DMTM6IEdpdmluZyBvdXQgZGV2aWNlIHRvIG1vZHVsZSBza3hfZWRh YyBjb250cm9sbGVyIFNreWxha2UgU29ja2V0IzAgSU1DIzEKPiBbIDM0MDEuOTg3NDM1XSBFREFD IE1DMTQ6IEdpdmluZyBvdXQgZGV2aWNlIHRvIG1vZHVsZSBza3hfZWRhYyBjb250cm9sbGVyIFNr eWxha2UgU29ja2V0IzEgSU1DIzAKPiBbIDM0MDEuOTg3NTU2XSBFREFDIE1DMTU6IEdpdmluZyBv dXQgZGV2aWNlIHRvIG1vZHVsZSBza3hfZWRhYyBjb250cm9sbGVyIFNreWxha2UgU29ja2V0IzEg SU1DIzEKPiBbIDM0MDEuOTg3NTc5XSBUb28gbWFueSBtZW1vcnkgY29udHJvbGxlcnM6IDE2Cj4g WyAzNDAyLjA0MjYxNF0gRURBQyBNQzogUmVtb3ZlZCBkZXZpY2UgMCBmb3Igc2t4X2VkYWMgU2t5 bGFrZSBTb2NrZXQjMCBJTUMjMAo+IAo+IFdlIG9ic2VydmUgdGhlcmUgYXJlIHR3byBtZW1vcnkg Y29udHJvbGxlcnMgcGVyIHNvY2tldCwgd2l0aCBhIGxpbWl0IG9mIDE2Lgo+IFJhaXNlIHRoZSBt YXhpbXVtIG51bWJlciBvZiBtZW1vcnkgY29udHJvbGxlcnMgZnJvbSAxNiB0byAyICogTUFYX05V TU5PREVTICgxMDI0KS4KPiAKPiBDYzogQm9yaXNsYXYgUGV0a292IDxicEBhbGllbjguZGU+Cj4g Q2M6IE1hdXJvIENhcnZhbGhvIENoZWhhYiA8bWNoZWhhYkBrZXJuZWwub3JnPgo+IENjOiBsaW51 eC1lZGFjQHZnZXIua2VybmVsLm9yZwo+IENjOiBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3Jn Cj4gQWNrZWQtYnk6IFJ1c3MgQW5kZXJzb24gPHJ1c3MuYW5kZXJzb25AaHBlLmNvbT4KPiBTaWdu ZWQtb2ZmLWJ5OiBKdXN0aW4gRXJuc3QgPGp1c3Rpbi5lcm5zdEBocGUuY29tPgo+IC0tLQo+ICBp bmNsdWRlL2xpbnV4L2VkYWMuaCB8IDMgKystCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlv bnMoKyksIDEgZGVsZXRpb24oLSkKCkFwcGxpZWQsIHRoYW5rcy4K