From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEAD1C43382 for ; Thu, 27 Sep 2018 07:04:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 64E122156D for ; Thu, 27 Sep 2018 07:04:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64E122156D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727297AbeI0NV0 (ORCPT ); Thu, 27 Sep 2018 09:21:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56300 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726820AbeI0NV0 (ORCPT ); Thu, 27 Sep 2018 09:21:26 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0D59930832C2; Thu, 27 Sep 2018 07:04:41 +0000 (UTC) Received: from gondolin (ovpn-117-60.ams2.redhat.com [10.36.117.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id 103B460D5E; Thu, 27 Sep 2018 07:04:30 +0000 (UTC) Date: Thu, 27 Sep 2018 09:04:28 +0200 From: Cornelia Huck To: Christian Borntraeger Cc: Tony Krowiak , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, freude@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, pmorel@linux.vnet.ibm.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, jjherne@linux.vnet.ibm.com, thuth@redhat.com, pasic@linux.vnet.ibm.com, berrange@redhat.com, fiuczy@linux.vnet.ibm.com, buendgen@de.ibm.com, frankja@linux.ibm.com, Tony Krowiak Subject: Re: [PATCH v11 13/26] s390: vfio-ap: zeroize the AP queues Message-ID: <20180927090428.5d96d7c0.cohuck@redhat.com> In-Reply-To: References: <20180925231641.4954-1-akrowiak@linux.vnet.ibm.com> <20180925231641.4954-14-akrowiak@linux.vnet.ibm.com> <20180926153831.195af1ce.cohuck@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Thu, 27 Sep 2018 07:04:41 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 Sep 2018 20:58:41 +0200 Christian Borntraeger wrote: > On 09/26/2018 03:38 PM, Cornelia Huck wrote: > > On Tue, 25 Sep 2018 19:16:28 -0400 > > Tony Krowiak wrote: > > > >> From: Tony Krowiak > >> > >> Let's call PAPQ(ZAPQ) to zeroize a queue for each queue configured > >> for a mediated matrix device when it is released. > >> > >> Zeroizing a queue resets the queue, clears all pending > >> messages for the queue entries and disables adapter interruptions > >> associated with the queue. > >> > >> Signed-off-by: Tony Krowiak > >> Reviewed-by: Halil Pasic > >> Tested-by: Michael Mueller > >> Tested-by: Farhan Ali > >> --- > >> drivers/s390/crypto/vfio_ap_ops.c | 44 +++++++++++++++++++++++++++++++ > >> 1 file changed, 44 insertions(+) (...) > >> +static int vfio_ap_mdev_reset_queues(struct mdev_device *mdev) > >> +{ > >> + int ret; > >> + int rc = 0; > >> + unsigned long apid, apqi; > >> + struct ap_matrix_mdev *matrix_mdev = mdev_get_drvdata(mdev); > >> + > >> + for_each_set_bit_inv(apid, matrix_mdev->matrix.apm, > >> + matrix_mdev->matrix.apm_max + 1) { > >> + for_each_set_bit_inv(apqi, matrix_mdev->matrix.aqm, > >> + matrix_mdev->matrix.aqm_max + 1) { > >> + ret = vfio_ap_mdev_reset_queue(apid, apqi, 1); > > > > I'd still like to see a comment here: > > > > /* > > * Regardless whether a queue turns out to be busy, or is not > > * operational, we need to continue resetting the remaining > > * queues. > > */ > > I added your proposal to the apv11 branch. Thanks. With that added, Reviewed-by: Cornelia Huck