Re: [PATCH 01/12] drm/amdgpu: add missing error handling

From: Huang Rui <ray.huang-5C7GfCeVMHo@public.gmane.org>
To: "Christian König"
	<ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 01/12] drm/amdgpu: add missing error handling
Date: Thu, 27 Sep 2018 18:00:47 +0800	[thread overview]
Message-ID: <20180927100045.GF30495@hr-amur2> (raw)
In-Reply-To: <20180926135330.2218-1-christian.koenig-5C7GfCeVMHo@public.gmane.org>

On Wed, Sep 26, 2018 at 03:53:19PM +0200, Christian König wrote:
> We ignored the return code here.
> 
> Signed-off-by: Christian König <christian.koenig@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> index f35d7a554ad5..2420ae90047e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> @@ -959,6 +959,9 @@ static int gmc_v9_0_sw_init(void *handle)
>  	/* This interrupt is VMC page fault.*/
>  	r = amdgpu_irq_add_id(adev, SOC15_IH_CLIENTID_VMC, VMC_1_0__SRCID__VM_FAULT,
>  				&adev->gmc.vm_fault);
> +	if (r)
> +		return r;
> +
>  	r = amdgpu_irq_add_id(adev, SOC15_IH_CLIENTID_UTCL2, UTCL2_1_0__SRCID__FAULT,
>  				&adev->gmc.vm_fault);
>  

We should tear down the client source that allocated by the
SOC15_IH_CLIENTID_VMC (the last one) if it (the second one) gets failed.

Thanks,
Ray

> -- 
> 2.14.1
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx