All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aymen Qader <qader.aymen@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Wolfram Sang <wsa@the-dreams.de>,
	Aymen Qader <qader.aymen@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] staging: ks7010: Add null pointer check for skb
Date: Thu, 27 Sep 2018 16:05:44 +0100	[thread overview]
Message-ID: <20180927150544.14632-1-qader.aymen@gmail.com> (raw)

Add a null pointer check for the socket buffer in ks_hostif.c to avoid a
possible null pointer deference.

Signed-off-by: Aymen Qader <qader.aymen@gmail.com>
---
 drivers/staging/ks7010/ks_hostif.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index 0e554e3359b5..4a5bc7858ef7 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -1011,6 +1011,11 @@ int hostif_data_request(struct ks_wlan_private *priv, struct sk_buff *skb)
 	size_t size;
 	int ret;
 
+	if(!skb) {
+		ret = -ENOMEM;
+		goto err_kfree;
+	}
+
 	skb_len = skb->len;
 	if (skb_len > ETH_FRAME_LEN) {
 		netdev_err(priv->net_dev, "bad length skb_len=%d\n", skb_len);
-- 
2.17.1


             reply	other threads:[~2018-09-27 15:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-27 15:05 Aymen Qader [this message]
2018-09-27 15:09 ` [PATCH v2] staging: ks7010: Add null pointer check for skb Aymen Qader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180927150544.14632-1-qader.aymen@gmail.com \
    --to=qader.aymen@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.