All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 12/14] gst1-plugins-base: add missing license file hash
Date: Thu, 27 Sep 2018 22:18:33 +0200	[thread overview]
Message-ID: <20180927221833.5604b006@gmx.net> (raw)
In-Reply-To: <20180925231434.5e016ac4@windsurf>

Hello Thomas,

On Tue, 25 Sep 2018 23:14:34 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> Hello,
> 
> On Tue, 25 Sep 2018 22:36:16 +0200, Peter Seiderer wrote:
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > ---
> > Changes v1 -> v2:
> >   - no changes
> > ---
> >  package/gstreamer1/gst1-plugins-base/gst1-plugins-base.hash | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.hash b/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.hash
> > index a98abdf38b..6ef34594a0 100644
> > --- a/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.hash
> > +++ b/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.hash
> > @@ -1,3 +1,3 @@
> >  # From https://gstreamer.freedesktop.org/src/gst-plugins-base/gst-plugins-base-1.14.3.tar.xz.sha256sum
> >  sha256 f0b319c36be0ffc2a00380c77ba269cdf04e2b39bbc49d30b641fc35aa0b7952 gst-plugins-base-1.14.3.tar.xz
> > -sha256 78fb5977f177ab71cba77a4a127d29b93cb1ca5c25962204b31f183a20cf5c7a COPYING  
> 
> I'm not sure why you're dropping this hash. The COPYING file still
> exists, it still has the same hash, and you didn't mention it in your
> commit log. So I've reverted this part of the change when applying.

Sorry for not mentioning in the commit log, the reasoning was that COPYING is
never reverenced in the gst1-plugins-base.mk file...

Regards,
Peter

> 
> > +sha256 f445dc78b88496f7e20c7a2a461b95baba5865c8919b8289ac24ac0a80c6ce7a COPYING.LIB  
> 
> Thanks,
> 
> Thomas

  reply	other threads:[~2018-09-27 20:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-25 20:36 [Buildroot] [PATCH v2 01/14] gstreamer1: bump version to 1.14.3 Peter Seiderer
2018-09-25 20:36 ` [Buildroot] [PATCH v2 02/14] gst1-plugins-base: " Peter Seiderer
2018-09-25 20:36 ` [Buildroot] [PATCH v2 03/14] gst1-plugins-good: " Peter Seiderer
2018-09-25 20:36 ` [Buildroot] [PATCH v2 04/14] gst1-plugins-bad: " Peter Seiderer
2018-09-25 20:36 ` [Buildroot] [PATCH v2 05/14] gst1-plugins-ugly: " Peter Seiderer
2018-09-25 20:36 ` [Buildroot] [PATCH v2 06/14] gst1-validate: " Peter Seiderer
2018-09-25 20:36 ` [Buildroot] [PATCH v2 07/14] gst1-libav: " Peter Seiderer
2018-09-25 20:36 ` [Buildroot] [PATCH v2 08/14] gst1-vaapi: " Peter Seiderer
2018-09-25 20:36 ` [Buildroot] [PATCH v2 09/14] gst1-rtsp-server: " Peter Seiderer
2018-09-25 20:36 ` [Buildroot] [PATCH v2 10/14] gstreamer1-editing-services: " Peter Seiderer
2018-09-25 20:36 ` [Buildroot] [PATCH v2 11/14] gst-omx: " Peter Seiderer
2018-09-25 20:36 ` [Buildroot] [PATCH v2 12/14] gst1-plugins-base: add missing license file hash Peter Seiderer
2018-09-25 21:14   ` Thomas Petazzoni
2018-09-27 20:18     ` Peter Seiderer [this message]
2018-09-28  6:43       ` Thomas Petazzoni
2018-09-29 17:34         ` Peter Seiderer
2018-09-25 20:36 ` [Buildroot] [PATCH v2 13/14] gst1-plugins-bad: " Peter Seiderer
2018-09-25 20:36 ` [Buildroot] [PATCH v2 14/14] gst1-rtsp-server: " Peter Seiderer
2018-09-25 21:19 ` [Buildroot] [PATCH v2 01/14] gstreamer1: bump version to 1.14.3 Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180927221833.5604b006@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.